Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix compatiblity issues with IC-2024.1 #665

Closed
adietish opened this issue Mar 13, 2024 · 4 comments
Closed

fix compatiblity issues with IC-2024.1 #665

adietish opened this issue Mar 13, 2024 · 4 comments
Assignees
@adietish
Labels
bug Something isn't working IC-2024.1
Milestone
1.5.0

Comments

@adietish
Copy link
Contributor

adietish commented Mar 13, 2024 •
edited
Loading

See: https://plugins.jetbrains.com/plugin/14096-tekton-pipelines-by-red-hat/edit/versions/stable/500388
image
@adietish adietish self-assigned this Mar 13, 2024
@adietish adietish added IC-2024.1 bug Something isn't working labels Mar 13, 2024
@adietish adietish moved this to 📋 Backlog in IDE Cloudaptors Mar 13, 2024
@sbouchet
Copy link
Contributor

be careful to still support minor IJ version ( 2022.1 )

@sbouchet sbouchet added this to the 1.4.3 milestone Mar 13, 2024
@adietish
Copy link
Contributor Author

It looks as if I need to bump "since-build" to IC-2022.2.
The deprecated (marked for removal) call

PopupHandler.installPopupHandler(tree, group, ActionPlaces.POPUP, actionManager, new TektonTreePopupMenuListener());

can be replaced with the following when bumping to IC-2022.2

PopupHandler.installPopupMenu(tree, group, ActionPlaces.POPUP, new TektonTreePopupMenuListener());

Alternatively I can of course go reflection but a simple bump by 1 version seems more rational to me given that we're still supporting 1.5y old IDEAs.

adietish added a commit to adietish/intellij-tekton that referenced this issue Mar 21, 2024
@adietish
made compatible to IC-2024.1, bumped to min IC-2022.2 (redhat-develop…
7a2cca8 
…er#665)

Signed-off-by: Andre Dietisheim <adietish@redhat.com>
adietish added a commit to adietish/intellij-tekton that referenced this issue Mar 21, 2024
@adietish
refactor: made compatible to IC-2024.1, bumped to min IC-2022.2 (redh…
c4f2d2b 
…at-developer#665)

Signed-off-by: Andre Dietisheim <adietish@redhat.com>
adietish added a commit to adietish/intellij-tekton that referenced this issue Mar 21, 2024
@adietish
refactor: made compatible to IC-2024.1, bumped to min IC-2022.2 (redh…
2acd4e3 
…at-developer#665)

Signed-off-by: Andre Dietisheim <adietish@redhat.com>
@adietish
Copy link
Contributor Author

We agreed to bump the minimal IDEA version to IC-2022.2

@adietish
Copy link
Contributor Author

adietish@2acd4e3 was merged. Closing.

@github-project-automation github-project-automation bot moved this from 📋 Backlog to ✅ Done in IDE Cloudaptors Mar 25, 2024
@sbouchet sbouchet modified the milestones: 1.4.3, 1.5.0 Mar 26, 2024
adietish added a commit that referenced this issue Mar 28, 2024
@adietish
refactor: made compatible to IC-2024.1, bumped to min IC-2022.2 (#665)
84f3d26 
Signed-off-by: Andre Dietisheim <adietish@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@adietish adietish

Labels
bug Something isn't working IC-2024.1
Projects
IDE Cloudaptors
Status: ✅ Done
Milestone
1.5.0
Development

No branches or pull requests
2 participants
@adietish @sbouchet