Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(skip-release): bump sinceIdea to IU-2022.3 #669

Merged
merged 1 commit into from
Apr 16, 2024

Conversation

adietish
Copy link
Contributor

@adietish adietish commented Apr 11, 2024

Caused following change that requires sinceIdea to be bumped to IU-2022.3
redhat-developer/intellij-common#219

@adietish adietish requested a review from sbouchet April 11, 2024 08:52
@adietish adietish self-assigned this Apr 11, 2024
@adietish adietish added this to the 1.4.3 milestone Apr 11, 2024
@adietish adietish force-pushed the bump_sinceIdea_to_22.3 branch 2 times, most recently from 857ba1b to d8d1378 Compare April 11, 2024 15:22
@adietish
Copy link
Contributor Author

adietish commented Apr 12, 2024

A test is failing with the bump of base IC version:
GenericCompletionProviderTest

   public void testTaskCompletionWithoutAnyInput() {
        assertTrue(getSuggestionsForFile("task1.yaml").isEmpty());
    }

getSuggestionsForFile("task1.yaml") returns a list with "apiVersion" in it while the test asserts that the list is empty.
According to Jeff Maury the new IC has most likely changed the YAML auto-completion.

@adietish
Copy link
Contributor Author

@sbouchet: I think that we should change the assertion in the test to be valid when "apiVersion" is returned because it's a change in the default behaviour of the platform. Agree?

* bumped sinceIdea to IU-2022.3
* corrected GenericCompletionProviderTest.testTaskCompletionWithoutAnyInput to assert default completion

Signed-off-by: Andre Dietisheim <adietish@redhat.com>
@adietish
Copy link
Contributor Author

adietish commented Apr 15, 2024

@sbouchet: I introduced a switch in the test that fails starting with IU-2024.1:

        if (getIDEAVersion() >= 2024.1f) {
            assertOrderedEquals(suggestions, "apiVersion"); // default completion returns 'apiVersion'
        } else {
            assertTrue(suggestions.isEmpty());
        }

Please review.

Copy link
Contributor

@sbouchet sbouchet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@adietish adietish merged commit 4ad8dcb into redhat-developer:main Apr 16, 2024
13 checks passed
@adietish adietish deleted the bump_sinceIdea_to_22.3 branch April 16, 2024 09:35
@adietish adietish added the task label Apr 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

2 participants