Test if in/out are terminal

pkg/exec/exec.go

@@ -67,14 +67,10 @@ func (o ExecClient) ExecuteCommand(ctx context.Context, command []string, podNam
 		return stdout, stderr, err
 	}
 
-	tty := term.TTY{
-		Raw: true,
-		In:  os.Stdin,
-		Out: os.Stdout,
-	}
+	tty := setupTTY()
 
 	fn := func() error {
-		return o.platformClient.ExecCMDInContainer(ctx, containerName, podName, command, tty.Out, nil, tty.In, true)
+		return o.platformClient.ExecCMDInContainer(ctx, containerName, podName, command, tty.Out, os.Stderr, tty.In, tty.Raw)
 	}
 
 	return nil, nil, tty.Safe(fn)
@@ -116,3 +112,15 @@ func startReaderGoroutine(logWriter io.Writer, reader io.Reader, show bool, cmdO
 
 	return result
 }
+
+func setupTTY() term.TTY {
+	tty := term.TTY{
+		In:  os.Stdin,
+		Out: os.Stdout,
+	}
+	if !tty.IsTerminalIn() || !tty.IsTerminalOut() {
+		return tty
+	}
+	tty.Raw = true
+	return tty
+}

tests/integration/cmd_run_test.go

@@ -136,8 +136,7 @@ var _ = Describe("odo run command tests", func() {
 					}
 
 					By("exiting with a status 1 when the exec command fails and displaying error output", func() {
-						// Err is in stdout and not stderr, as the terminal is set in raw mode
-						out := helper.Cmd("odo", "run", "error-cmd", "--platform", platform).ShouldFail().Out()
+						out := helper.Cmd("odo", "run", "error-cmd", "--platform", platform).ShouldFail().Err()
 						Expect(out).To(ContainSubstring("No such file or directory"))
 					})
 				})