-
Notifications
You must be signed in to change notification settings - Fork 244
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Help message is overwhelming for first time users #1672
Comments
/kind enhancement |
I spend some time to analyse the issue and here are my thoughts. AFAIU Expected Output:
I really found some valid suggestions given by OP, However I don't see any valid reason to change the Subcommand list/format/indentation because this is a key feature of odo command shortcut. But still I am open to any suggestion.
+1, I am ok with this. @kadel and Team WDYT?
+1, I would suggest to use
+1, Sounds good to me. I guess some good amount of odo code will be changed. Right now I am not that comfortable to handle this within the GA time frame. It will be easy for someone who has good grip on odo code, to send a quick PR with the changes mentioned above. |
/unassign @amitkrout |
Why not just reserve this list for the help page of the subcommand ? I.e of a user does an
and then does a
which lists the components subcommands is much better than leave the user guessing what this huge So also, I suggest to test all your output against a maximum assume line length (like 120 is a typical width people often use). And, as in this example I change |
Seems @cdrage is going to take care of this issue. |
/unassign @amitkrout |
/unassign @prietyc123 |
This PR: - Modifies the output of running JUST `odo` similar to how `oc` does it. - There is now a difference between running `odo` and running `odo --help` - Removes "Normalize" for the long description since it was messing up newline formatting - Adds integration tests for help usage Closes redhat-developer#1672 Example of running JUST `odo`: ```sh (OpenShift Do) odo is a CLI tool for running OpenShift applications in a fast and automated manner. Reducing the complexity of deployment, odo adds iterative development without the worry of deploying your source code. Find more information at https://github.com/openshift/odo Get started by creating a new application: git clone https://github.com/openshift/nodejs-ex && cd nodejs-ex odo create nodejs odo push Your nodejs application has now been deployed. odo has pushed the source code, built the application and deployed it on OpenShift. You can now edit your code in real time and watch as odo automatically deploys your application. odo watch To access your application, create a URL: odo url create myurl odo push More information such as logs or what components you've deployed can be accessed with these commands: odo describe odo list odo log To see a full list of commands, run 'odo --help' ```
This PR: - Modifies the output of running JUST `odo` similar to how `oc` does it. - There is now a difference between running `odo` and running `odo --help` - Removes "Normalize" for the long description since it was messing up newline formatting - Adds integration tests for help usage Closes redhat-developer#1672 Example of running JUST `odo`: ```sh (OpenShift Do) odo is a CLI tool for running OpenShift applications in a fast and automated manner. Reducing the complexity of deployment, odo adds iterative development without the worry of deploying your source code. Find more information at https://github.com/openshift/odo Get started by creating a new application: git clone https://github.com/openshift/nodejs-ex && cd nodejs-ex odo create nodejs odo push Your nodejs application has now been deployed. odo has pushed the source code, built the application and deployed it on OpenShift. You can now edit your code in real time and watch as odo automatically deploys your application. odo watch To access your application, create a URL: odo url create myurl odo push More information such as logs or what components you've deployed can be accessed with these commands: odo describe odo list odo log To see a full list of commands, run 'odo --help' ```
* Updates the help usage of odo This PR: - Modifies the output of running JUST `odo` similar to how `oc` does it. - There is now a difference between running `odo` and running `odo --help` - Removes "Normalize" for the long description since it was messing up newline formatting - Adds integration tests for help usage Closes #1672 Example of running JUST `odo`: ```sh (OpenShift Do) odo is a CLI tool for running OpenShift applications in a fast and automated manner. Reducing the complexity of deployment, odo adds iterative development without the worry of deploying your source code. Find more information at https://github.com/openshift/odo Get started by creating a new application: git clone https://github.com/openshift/nodejs-ex && cd nodejs-ex odo create nodejs odo push Your nodejs application has now been deployed. odo has pushed the source code, built the application and deployed it on OpenShift. You can now edit your code in real time and watch as odo automatically deploys your application. odo watch To access your application, create a URL: odo url create myurl odo push More information such as logs or what components you've deployed can be accessed with these commands: odo describe odo list odo log To see a full list of commands, run 'odo --help' ``` * Update order
[kind/Enhancement]
Which functionality do you think we should update/improve?
When calling odo without argument (typical usage for first time users), one get:
Why is this needed?
suggests that you can either use odo with flags or with a command. This usage message is not very helpful
The subcommand list behind the commands (e.g. component) with up to 11 subcommands is overwhelming and not very useful also, because its hard to read and destroy the layout.
"Delete an existing component" vs. "Describe the given component" (shouldn't this be "Delete component" and "Describe component" (the shorter the better).
"Modifies configuration settings" --> "Change or view configurtion" (i.e. the 'view' subcommand is not about modification).
"Components of an application" --> "Manage components"
....
The text was updated successfully, but these errors were encountered: