Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IBM Cloud tests are failing when the PR title contains a quote #5663

Closed
feloy opened this issue Apr 14, 2022 · 7 comments
Closed

IBM Cloud tests are failing when the PR title contains a quote #5663

feloy opened this issue Apr 14, 2022 · 7 comments
Labels
area/testing Issues or PRs related to testing, Quality Assurance or Quality Engineering kind/bug Categorizes issue or PR as related to a bug. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. priority/High Important issue; should be worked on before any other issues (except priority/Critical issue(s)). triage/needs-information Indicates an issue needs more information in order to work on it.

Comments

@feloy
Copy link
Contributor

feloy commented Apr 14, 2022

/kind bug

What versions of software are you using?

Operating System:

Output of odo version:

How did you run odo exactly?

Actual behavior

When a PR title contains a quote ', the IBM Cloud tests fail with the message:

/tmp/run: 96: ./_env: Syntax error: Unterminated quoted string

Expected behavior

Any logs, error output, etc?
@openshift-ci openshift-ci bot added the kind/bug Categorizes issue or PR as related to a bug. label Apr 14, 2022
@feloy feloy mentioned this issue Jun 28, 2022
Merged
3 tasks
@rm3l rm3l added this to odo Project Oct 3, 2022
@rm3l rm3l moved this to To Do 📝 in odo Project Oct 3, 2022
@rm3l rm3l removed the status in odo Project Oct 3, 2022
@kadel kadel added priority/High Important issue; should be worked on before any other issues (except priority/Critical issue(s)). good first issue Denotes an issue ready for a new contributor. Maintainers will help mentor new contributors. area/testing Issues or PRs related to testing, Quality Assurance or Quality Engineering labels Feb 17, 2023
@anandrkskd
Copy link
Contributor

@feloy I think this is something which is handled by ibmcloud CI, do you think It's still relevant ? or should we close it

@rm3l rm3l added the triage/needs-information Indicates an issue needs more information in order to work on it. label Mar 22, 2023
@rm3l
Copy link
Member

rm3l commented Mar 22, 2023 •
edited
Loading

Needs investigation (2d)

@rm3l rm3l added this to the v3.9.0 🚀 milestone Mar 23, 2023
@ritudes
Copy link
Contributor

ritudes commented Mar 28, 2023 •
edited
Loading

I check the PR's with quotes ' as well as backquotes ` ,and they passed all the IBM cloud tests.
Here are the link to the PR's:
#6692
#6687

@ritudes ritudes moved this to In Progress 🚧 in odo Project Mar 28, 2023
@feloy
Copy link
Contributor Author

feloy commented Mar 28, 2023

This has most probably been fixed in IBM Cloud side. I'm closing the issue.

Thanks @ritudes for testing it again

@feloy feloy closed this as completed Mar 28, 2023
@github-project-automation github-project-automation bot moved this from In Progress 🚧 to Done ✅ in odo Project Mar 28, 2023
This was referenced Mar 28, 2023
Closed
Closed
@rm3l
Copy link
Member

rm3l commented May 22, 2023

I faced this issue again on #6833. PR title was: Fix flaky 'odo dev' test on Podman by randomizing component names:

Preparing to start the job...
Running on public worker: eu-depublicworker04-3
Pulling image quay.io/odo-dev/ibmcloudtest-image:v1.19-1 ...
Job execution started at Mon May 22 16:16:51 UTC 2023
Custom image
Cloning the 'main' branch from repo 'https://github.com/redhat-developer/odo.git'
2023/05/22 16:17:21 Skipping step because a previous step failed
/tmp/run: 18: export: dev test on Podman by randomizing component names: bad variable name
Repository successfully cloned
Performing Pull Request Checkout
From https://github.com/redhat-developer/odo
 * [new ref]             refs/pull/6833/head -> ids-pipeline-temp-branch-for-pr
Switched to branch 'ids-pipeline-temp-branch-for-pr'

Finished: FAILED

@rm3l rm3l reopened this May 22, 2023
@github-project-automation github-project-automation bot moved this from Done ✅ to To Do 📝 in odo Project May 22, 2023
@github-actions github-actions bot added the needs-triage Indicates an issue or PR lacks a `triage/*` and requires one. label May 22, 2023
@rm3l rm3l removed the needs-triage Indicates an issue or PR lacks a `triage/*` and requires one. label Jun 26, 2023
@rm3l rm3l removed the good first issue Denotes an issue ready for a new contributor. Maintainers will help mentor new contributors. label Jul 20, 2023
@rm3l rm3l removed this from the v3.9.0 🚀 milestone Aug 24, 2023
@rm3l rm3l removed the status in odo Project Aug 24, 2023
@github-actions GitHub Actions
Copy link
Contributor

A friendly reminder that this issue had no activity for 90 days. Stale issues will be closed after an additional 30 days of inactivity.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Nov 23, 2023
@github-actions GitHub Actions
Copy link
Contributor

This issue was closed because it has been inactive for 30 days since being marked as stale.

@github-actions github-actions bot added the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label Dec 24, 2023
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Dec 24, 2023
@github-project-automation github-project-automation bot moved this to Done ✅ in odo Project Dec 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/testing Issues or PRs related to testing, Quality Assurance or Quality Engineering kind/bug Categorizes issue or PR as related to a bug. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. priority/High Important issue; should be worked on before any other issues (except priority/Critical issue(s)). triage/needs-information Indicates an issue needs more information in order to work on it.
Projects
odo Project
Archived in project
Milestone
No milestone
Development

No branches or pull requests
5 participants
@kadel @rm3l @feloy @anandrkskd @ritudes