Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flaky odo dev test on Podman by randomizing component names #6833

Conversation

rm3l
Copy link
Member

@rm3l rm3l commented May 22, 2023

What type of PR is this:
/kind flake
/kind bug
/area testing

What does this PR do / why we need it:

This fixes the flakiness of the test reported in #6832, by randomizing the component names used in this test.

It also changes the signature of helper.CopyExampleDevfile so as to make sure we don't forget to set a component name when copying an example Devfile.

Which issue(s) this PR fixes:
Fixes #6832

PR acceptance criteria:

  • Unit test

  • Integration test

  • Documentation

How to test changes / Special notes to the reviewer:

@netlify
Copy link

netlify bot commented May 22, 2023

Deploy Preview for odo-docusaurus-preview canceled.

Name Link
🔨 Latest commit af2aaca
🔍 Latest deploy log https://app.netlify.com/sites/odo-docusaurus-preview/deploys/646b8e9dbf7da900084ee95f

@openshift-ci openshift-ci bot added flake Categorizes issue or PR as related to a flaky test. kind/bug Categorizes issue or PR as related to a bug. area/testing Issues or PRs related to testing, Quality Assurance or Quality Engineering labels May 22, 2023
@openshift-ci openshift-ci bot requested review from feloy and rnapoles-rh May 22, 2023 15:48
@rm3l rm3l closed this May 22, 2023
@rm3l rm3l reopened this May 22, 2023
@rm3l rm3l changed the title Fix flaky 'odo dev' test on Podman by randomizing component names Fix flaky odo dev test on Podman by randomizing component names May 22, 2023
@rm3l rm3l closed this May 22, 2023
@rm3l rm3l reopened this May 22, 2023
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@odo-robot
Copy link

odo-robot bot commented May 22, 2023

NoCluster Tests on commit 2be7f9e finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented May 22, 2023

OpenShift Unauthenticated Tests on commit 2be7f9e finished with errors.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented May 22, 2023

Unit Tests on commit 2be7f9e finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented May 22, 2023

Validate Tests on commit 2be7f9e finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented May 22, 2023

Kubernetes Tests on commit 2be7f9e finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented May 22, 2023

Windows Tests (OCP) on commit 2be7f9e finished with errors.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented May 22, 2023

OpenShift Tests on commit 2be7f9e finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented May 22, 2023

Kubernetes Docs Tests on commit db35b57 finished successfully.
View logs: TXT HTML

@rm3l rm3l requested review from valaparthvi and removed request for rnapoles-rh May 23, 2023 08:29
@valaparthvi
Copy link
Contributor

 ? What configuration do you want change? Add new environment variable
  ? Enter new environment variable name: 
  ======================
  Unexpected error:
      <*xpty.errPassthroughTimeout | 0xc000540020>: {
          error: <*errors.errorString | 0xc000540000>{
              s: "passthrough i/o timeout",
          },
      }
      passthrough i/o timeout
  occurred
  In [It] at: /go/odo_1/tests/helper/helper_interactive.go:111 @ 05/22/23 16:29:38.719
------------------------------

Summarizing 1 Failure:
  [FAIL] odo init interactive command tests label unauth personalizing Devfile configuration [It] should allow for personalizing configurations [unauth]
  /go/odo_1/tests/helper/helper_interactive.go:111

/override OpenShift-Integration-tests/OpenShift-Unauth-Integration-tests

@openshift-ci
Copy link

openshift-ci bot commented May 23, 2023

@valaparthvi: Overrode contexts on behalf of valaparthvi: OpenShift-Integration-tests/OpenShift-Unauth-Integration-tests

In response to this:

? What configuration do you want change? Add new environment variable
 ? Enter new environment variable name: 
 ======================
 Unexpected error:
     <*xpty.errPassthroughTimeout | 0xc000540020>: {
         error: <*errors.errorString | 0xc000540000>{
             s: "passthrough i/o timeout",
         },
     }
     passthrough i/o timeout
 occurred
 In [It] at: /go/odo_1/tests/helper/helper_interactive.go:111 @ 05/22/23 16:29:38.719
------------------------------

Summarizing 1 Failure:
 [FAIL] odo init interactive command tests label unauth personalizing Devfile configuration [It] should allow for personalizing configurations [unauth]
 /go/odo_1/tests/helper/helper_interactive.go:111

/override OpenShift-Integration-tests/OpenShift-Unauth-Integration-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@rm3l
Copy link
Member Author

rm3l commented May 23, 2023

  [odo]  X  stderr: 
  [odo] 
  [odo]  X  err: error while streaming command: error sending request: Post "https://c114-e.eu-de.containers.cloud.ibm.com:30329/api/v1/namespaces/cmd-describe-component-test362aft/pods/fjwtzg-app-854fcbcffd-brrrp/exec?command=tar&command=xf&command=-&command=-C&command=%2Fproject&command=--no-same-owner&container=runtime&stderr=true&stdin=true&stdout=true": dial tcp 158.177.107.50:30329: connectex: A connection attempt failed because the connected party did not properly respond after a period of time, or established connection failed because connected host has failed to respond.
  [odo] 
  [odo] I0522 11:44:53.254533   12196 status.go:34] setting inner loop State "Ready"
  [odo] 
 X  Syncing files into the container [22s]
  [odo] I0522 11:44:53.254533   12196 watch.go:428] Error from Push: watch command was unable to push component: failed to sync to component with name fjwtzg: failed to sync to component with name fjwtzg: unable push files to pod: error while streaming command: error sending request: Post "https://c114-e.eu-de.containers.cloud.ibm.com:30329/api/v1/namespaces/cmd-describe-component-test362aft/pods/fjwtzg-app-854fcbcffd-brrrp/exec?command=tar&command=xf&command=-&command=-C&command=%2Fproject&command=--no-same-owner&container=runtime&stderr=true&stdin=true&stdout=true": dial tcp 158.177.107.50:30329: connectex: A connection attempt failed because the connected party did not properly respond after a period of time, or established connection failed because connected host has failed to respond.
  [odo] Error occurred on Push - watch command was unable to push component: failed to sync to component with name fjwtzg: failed to sync to component with name fjwtzg: unable push files to pod: error while streaming command: error sending request: Post "https://c114-e.eu-de.containers.cloud.ibm.com:30329/api/v1/namespaces/cmd-describe-component-test362aft/pods/fjwtzg-app-854fcbcffd-brrrp/exec?command=tar&command=xf&command=-&command=-C&command=%2Fproject&command=--no-same-owner&container=runtime&stderr=true&stdin=true&stdout=true": dial tcp 158.177.107.50:30329: connectex: A connection attempt failed because the connected party did not properly respond after a period of time, or established connection failed because connected host has failed to respond.
...
Summarizing 1 Failure:
  [FAIL] odo describe component command tests when creating a component when running odo dev (podman=false,debug=true) JSON output when describing the component in dev mode [It] should describe the component
  C:/Users/Administrator.ANSIBLE-TEST-VS/3989/tests/helper/helper_generic.go:318

Ran 473 of 890 Specs in 1683.010 seconds
FAIL! -- 472 Passed | 1 Failed | 0 Pending | 417 Skipped

Network issues on Windows - tracked in #6838

/override windows-integration-test/Windows-test

@openshift-ci
Copy link

openshift-ci bot commented May 23, 2023

@rm3l: Overrode contexts on behalf of rm3l: windows-integration-test/Windows-test

In response to this:

 [odo]  X  stderr: 
 [odo] 
 [odo]  X  err: error while streaming command: error sending request: Post "https://c114-e.eu-de.containers.cloud.ibm.com:30329/api/v1/namespaces/cmd-describe-component-test362aft/pods/fjwtzg-app-854fcbcffd-brrrp/exec?command=tar&command=xf&command=-&command=-C&command=%2Fproject&command=--no-same-owner&container=runtime&stderr=true&stdin=true&stdout=true": dial tcp 158.177.107.50:30329: connectex: A connection attempt failed because the connected party did not properly respond after a period of time, or established connection failed because connected host has failed to respond.
 [odo] 
 [odo] I0522 11:44:53.254533   12196 status.go:34] setting inner loop State "Ready"
 [odo] 
X  Syncing files into the container [22s]
 [odo] I0522 11:44:53.254533   12196 watch.go:428] Error from Push: watch command was unable to push component: failed to sync to component with name fjwtzg: failed to sync to component with name fjwtzg: unable push files to pod: error while streaming command: error sending request: Post "https://c114-e.eu-de.containers.cloud.ibm.com:30329/api/v1/namespaces/cmd-describe-component-test362aft/pods/fjwtzg-app-854fcbcffd-brrrp/exec?command=tar&command=xf&command=-&command=-C&command=%2Fproject&command=--no-same-owner&container=runtime&stderr=true&stdin=true&stdout=true": dial tcp 158.177.107.50:30329: connectex: A connection attempt failed because the connected party did not properly respond after a period of time, or established connection failed because connected host has failed to respond.
 [odo] Error occurred on Push - watch command was unable to push component: failed to sync to component with name fjwtzg: failed to sync to component with name fjwtzg: unable push files to pod: error while streaming command: error sending request: Post "https://c114-e.eu-de.containers.cloud.ibm.com:30329/api/v1/namespaces/cmd-describe-component-test362aft/pods/fjwtzg-app-854fcbcffd-brrrp/exec?command=tar&command=xf&command=-&command=-C&command=%2Fproject&command=--no-same-owner&container=runtime&stderr=true&stdin=true&stdout=true": dial tcp 158.177.107.50:30329: connectex: A connection attempt failed because the connected party did not properly respond after a period of time, or established connection failed because connected host has failed to respond.
...
Summarizing 1 Failure:
 [FAIL] odo describe component command tests when creating a component when running odo dev (podman=false,debug=true) JSON output when describing the component in dev mode [It] should describe the component
 C:/Users/Administrator.ANSIBLE-TEST-VS/3989/tests/helper/helper_generic.go:318

Ran 473 of 890 Specs in 1683.010 seconds
FAIL! -- 472 Passed | 1 Failed | 0 Pending | 417 Skipped

Network issues on Windows - tracked in #6838

/override windows-integration-test/Windows-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label May 26, 2023
@openshift-merge-robot openshift-merge-robot merged commit b60fc5b into redhat-developer:main May 26, 2023
@rm3l rm3l deleted the 6832-flake-odo-dev-command-tests-multiple-dev-sessions-with-different-project-are-running-on-same-platform-podman branch May 26, 2023 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/testing Issues or PRs related to testing, Quality Assurance or Quality Engineering flake Categorizes issue or PR as related to a flaky test. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. Required by Prow.
Projects
None yet
4 participants