Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using HTTP(S)_PROXY in odo #6065

Closed
1 task
kadel opened this issue Aug 30, 2022 · 5 comments
Closed
1 task

Using HTTP(S)_PROXY in odo #6065

kadel opened this issue Aug 30, 2022 · 5 comments
Labels
kind/user-story An issue of user-story kind priority/Medium Nice to have issue. Getting it done before priority changes would be great.
Milestone

Comments

@kadel
Copy link
Member

kadel commented Aug 30, 2022

/kind user-story

User Story

As an odo user, my working environment is restricted, and all requests need to go via a proxy I want to be able to configure odo to use a proxy So that I can use odo.

Acceptance Criteria

  • odo should use system proxy settings (HTTP_PROXY and HTTPS_PROXY env variables) for all requests

## Notes

  • requests done using client-go should be already correctly routed via the proxy
  • devfile registry library is currently most likely not supporting proxy
  • all requests done by odo itself should go via proxy as well (including telemetry)

/kind user-story
/priority medium

@openshift-ci openshift-ci bot added kind/user-story An issue of user-story kind priority/Medium Nice to have issue. Getting it done before priority changes would be great. labels Aug 30, 2022
@kadel
Copy link
Member Author

kadel commented Sep 14, 2022

devfile registry library is currently most likely not supporting proxy

support or HTTP_PROXY was merged in devfile/library (devfile/api#897)

@valaparthvi
Copy link
Contributor

valaparthvi commented Sep 15, 2022

@valaparthvi
Copy link
Contributor

valaparthvi commented Sep 15, 2022

/status blocked
#6041

@rm3l rm3l added this to the v3.1.0 🚀 milestone Sep 30, 2022
@rm3l rm3l modified the milestones: v3.1.0 🚀, v3.2.0 🚀 Oct 12, 2022
@rm3l rm3l modified the milestones: v3.2.0 🚀, v3.3.0 🚀 Oct 26, 2022
@rm3l rm3l modified the milestones: v3.3.0 🚀, v3.4.0 🚀 Nov 14, 2022
@rm3l rm3l removed this from the v3.4.0 🚀 milestone Nov 23, 2022
@kimba74
Copy link

kimba74 commented Dec 12, 2022

Just wanted to check to see if there is a timeline for when this request makes it into the binary.

Thanks in advance.

@feloy
Copy link
Contributor

feloy commented Dec 14, 2022

devfile/registry-support#133 fixes the problem in Registry library and #6396 includes this PR.

This fixes the problem for calls to Registry.

I executed tests with a Squid proxy and iptables blocking all other outbound traffic except to proxy, all tests pass.

Closing the issue

@feloy feloy closed this as completed Dec 14, 2022
@rm3l rm3l added this to the v3.4.0 🚀 milestone Dec 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/user-story An issue of user-story kind priority/Medium Nice to have issue. Getting it done before priority changes would be great.
Projects
Archived in project
Status: Done
Status: Done
Development

No branches or pull requests

5 participants