Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

proxy support for registry #133

Merged
merged 1 commit into from
Sep 1, 2022
Merged

proxy support for registry #133

merged 1 commit into from
Sep 1, 2022

Conversation

kim-tsao
Copy link
Contributor

Signed-off-by: Kim Tsao ktsao@redhat.com

Please specify the area for this PR
/area registry

What does does this PR do / why we need it:
Introduces proxy support for the registry. Clients such as OCP allow their users to set up a proxy server (typical of air-gapped environments) but this will cause the devfile registry to be unreachable. The fix is to update our custom HTTP transport to recognize the proxy that's set in the environment.

Which issue(s) this PR fixes:

Fixes #?

devfile/api#897

PR acceptance criteria:

  • [x ] Test (WIP)

Documentation (WIP)

How to test changes / Special notes to the reviewer:

Signed-off-by: Kim Tsao <ktsao@redhat.com>
@openshift-ci
Copy link

openshift-ci bot commented Aug 31, 2022

@kim-tsao: The label(s) area/registry cannot be applied, because the repository doesn't have them.

In response to this:

Signed-off-by: Kim Tsao ktsao@redhat.com

Please specify the area for this PR
/area registry

What does does this PR do / why we need it:
Introduces proxy support for the registry. Clients such as OCP allow their users to set up a proxy server (typical of air-gapped environments) but this will cause the devfile registry to be unreachable. The fix is to update our custom HTTP transport to recognize the proxy that's set in the environment.

Which issue(s) this PR fixes:

Fixes #?

devfile/api#897

PR acceptance criteria:

  • [x ] Test (WIP)

Documentation (WIP)

How to test changes / Special notes to the reviewer:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested a review from elsony August 31, 2022 13:45
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 31, 2022
@openshift-ci
Copy link

openshift-ci bot commented Aug 31, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: johnmcollier, kim-tsao

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 31, 2022
@kim-tsao kim-tsao merged commit b579f98 into devfile:main Sep 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
2 participants