Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

send platform and experimental mode as properties to telemetry #6508

Closed
2 tasks
kadel opened this issue Jan 18, 2023 · 5 comments
Closed
2 tasks

send platform and experimental mode as properties to telemetry #6508

kadel opened this issue Jan 18, 2023 · 5 comments
Assignees
@feloy
Labels
area/telemetry Issues or PRs related to telemetry or metrics collection kind/user-story An issue of user-story kind priority/High Important issue; should be worked on before any other issues (except priority/Critical issue(s)).
Milestone
v3.7.0 🚀

Comments

@kadel
Copy link
Member

kadel commented Jan 18, 2023

/kind user-story

User Story

As a ... I want to ... So that ...

Acceptance Criteria

  • It should ....
  • It should ....

Links

  • Related Epic (mandatory):

/kind user-story
@openshift-ci openshift-ci bot added the kind/user-story An issue of user-story kind label Jan 18, 2023
@github-actions github-actions bot added the needs-triage Indicates an issue or PR lacks a `triage/*` and requires one. label Jan 18, 2023
@rm3l rm3l added this to odo Project Jan 18, 2023
@kadel kadel added the priority/High Important issue; should be worked on before any other issues (except priority/Critical issue(s)). label Jan 18, 2023
@rm3l
Copy link
Member

rm3l commented Jan 19, 2023 •
edited
Loading

Grooming (2023-01-19)

  • Experimental mode as boolean property for all commands

  • platform info should be sent regardless of the experimental mode

    • 2 new fields:
      • platform: podman, kubernetes, openshift
      • platform version: whole version, not just major
    • Send only for odo dev and odo deploy commands
    • Get rid of cluster type in code

@rm3l rm3l changed the title send platform as a property to telemetry when odo dev send platform and experimental mode as properties to telemetry Jan 19, 2023
@rm3l rm3l removed the needs-triage Indicates an issue or PR lacks a `triage/*` and requires one. label Jan 19, 2023
@feloy feloy mentioned this issue Jan 20, 2023
Merged
3 tasks
@feloy feloy self-assigned this Jan 20, 2023
@feloy feloy moved this to In Progress 🚧 in odo Project Jan 20, 2023
@feloy feloy mentioned this issue Jan 25, 2023
Merged
3 tasks
@feloy feloy moved this from In Progress 🚧 to In Review 👀 in odo Project Jan 26, 2023
@feloy
Copy link
Contributor

feloy commented Jan 26, 2023

cluster type is still sent to telemetry for commands odo create/delete/set namespace/project.

@kadel do we want to remove this telemetry info (cluster type) for these commands? Note that we did not plan to add platform and platform version for these commands.

@rm3l rm3l added the area/telemetry Issues or PRs related to telemetry or metrics collection label Jan 26, 2023
@kadel
Copy link
Member Author

kadel commented Jan 26, 2023

If it is possible, let's keep it for odo create/delete/set namespace/project as it is. If it is complicated code too much than we can remove cluster type from those commands. Currently there are no reports that use that data

@feloy feloy moved this from In Review 👀 to Done ✅ in odo Project Jan 30, 2023
@rm3l rm3l added this to the v3.7.0 🚀 milestone Jan 30, 2023
@valaparthvi
Copy link
Contributor

/close
Required work is done.

@openshift-ci openshift-ci bot closed this as completed Feb 13, 2023
@openshift-ci
Copy link

openshift-ci bot commented Feb 13, 2023

@valaparthvi: Closing this issue.

In response to this:

/close
Required work is done.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@feloy feloy

Labels
area/telemetry Issues or PRs related to telemetry or metrics collection kind/user-story An issue of user-story kind priority/High Important issue; should be worked on before any other issues (except priority/Critical issue(s)).
Projects
odo Project
Archived in project
Milestone
v3.7.0 🚀
Development

No branches or pull requests
4 participants
@kadel @rm3l @feloy @valaparthvi