-
Notifications
You must be signed in to change notification settings - Fork 244
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ComponentTypeList should be List in machine output #2230
ComponentTypeList should be List in machine output #2230
Conversation
For `odo catalog list components` machine-readable output for `Kind` should simply be `List`
/retest |
@cdrage don't we have tests that check for the json output of cc @amitkrout UPDATE: We do have tests for ServiceTypeList #2229. I think we should add for ComponentTypeList as well. 😄 |
Test has been updated for this pr - https://github.com/openshift/odo/pull/2230/files#diff-f0f2e54d32d2c1ab57020c3a3dd9a3fbR197. /approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: amitkrout The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest Please review the full test history for this PR and help us cut down flakes. |
3 similar comments
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
For
odo catalog list components
machine-readable output forKind
should simply be
List