-
Notifications
You must be signed in to change notification settings - Fork 244
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
implement 'ocdev component list' #225
Conversation
6a05518
to
76d5df8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should return that there are no components when there are no components -
$ ocdev component list
You have deployed:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This message does not make sense -
$ ocdev component list
You have deployed:
nodejs using the nodejs component
Something like the following would be better:
$ ocdev component list
Application "nodejs" has the following components:
- nodejs
- nodejs2
Why doesn't it make sense? output can also look like this:
see #191 |
updated.
|
this doesn't show what is the type of each component |
Having the following message will be clearer IMO $ ocdev component list
Application "nodejs" has the following components:
- nodejs, of type nodejs
- nodejs2, of type nodejs |
Lets clear that in the original issue #191 |
can we sort out those messages outside this PR? Right now it is implemented as it is described in the Issue. We can change those messages later. |
fixes #53
fixes #191
implements:
ocdev component list
/ocdev list
- list component names in current application and their typesTODO:
component.GetComponentType
- needs to filter according to applicationName