Update desription for ocdev create #335
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kadel
requested changes
Apr 11, 2018
cmd/create.go
Outdated
|
|
||
| If component name is not provided, component type value will be used for the name. | ||
|
|
||
| OpenShift built-in types: httpd, nodejs, perl, php, python, ruby, wildfly |
There was a problem hiding this comment.
I'm not sure if it is a good idea to have the list here. It will be hard to keep this update.
Just referring to ocdev component list is I think enough.
cdrage
force-pushed
the
improve-description-create
branch
from
8341a9a to
f543765
Compare
|
Thanks @kadel I've updated it and added one more line with regards to using Python, but that's it. You're right, since OpenShift is constantly adding new containers / build images, it'd be hard to maintain that list. |
cdrage
force-pushed
the
improve-description-create
branch
from
f543765 to
dc2a944
Compare
kadel
reviewed
Apr 12, 2018
cmd/create.go
Outdated
| # Create a Ruby component | ||
| ocdev create ruby | ||
|
|
||
| # Create a Python component |
There was a problem hiding this comment.
indentation. There should be two spaces at the beginning to alight it with everything else.
cdrage
force-pushed
the
improve-description-create
branch
from
dc2a944 to
dc13513
Compare
kadel
added
the
needs-rebase
Updates the description for ocdev create with a bit more information.
cdrage
force-pushed
the
improve-description-create
branch
from
dc13513 to
e97df08
Compare
cdrage
removed
the
needs-rebase
|
Thx! Rebased 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the description for ocdev create with a bit more information.