Fixes the problem of a better description when no component is listed during update #374
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kadel Are the error messages appropriate? |
kadel
reviewed
Apr 16, 2018
cmd/update.go
Outdated
| fmt.Println("Cannot update as no application is set as active") | ||
| os.Exit(1) | ||
| } | ||
| } | ||
| } else { | ||
| componentName = args[0] | ||
| } |
There was a problem hiding this comment.
You should also check if component exists
kadel
reviewed
Apr 16, 2018
cmd/update.go
Outdated
| fmt.Println("Cannot update as no application exists in the current project") | ||
| os.Exit(1) | ||
| } | ||
| applicationName, err = application.GetCurrent(client) |
There was a problem hiding this comment.
you are already calling application.GetCurrent(client) on line 32
mik-dass
force-pushed
the
no_active_comp
branch
from
cde3915 to
b126a50
Compare
|
@kadel Done |
kadel
reviewed
Apr 17, 2018
cmd/update.go
Outdated
| os.Exit(1) | ||
| } | ||
|
|
||
| exists, err := component.Exists(client, componentName, applicationName, projectName) |
There was a problem hiding this comment.
you should move this check to else block after line 73
…s listed during update This checks if any app exists in the current project or any app is set as active or not Signed-off-by: mdas <mrinald7@gmail.com>
mik-dass
force-pushed
the
no_active_comp
branch
from
b126a50 to
29dbb60
Compare
|
works for me, LGTM :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: mik-dass mrinald7@gmail.com
Issue : #319