Fix infinite loop in e2e tests

[ashetty1]

Fixes #368

[kadel]

why are we converting the output to int?

[ashetty1]

@kadel I need the output in int since I am doing wc -l comparison

[kadel]

then we need a different name for this function. It is really specific one command, and it won't work for anything that is not ending with wc

[ashetty1]

@kadel , how about we pass expected value in the function. Something like this:

func pingCmd(cmd string, expOut string) bool {
...
            out, err := exec.Command("/bin/sh", "-c", cmd).Output()
             if err != nil {
                  Fail(err.Error())
             }

             if string(out) == expOut {
                   return true
              }
...
}


pingCmd("curl -s getRoute  | grep -i odo | wc -l | tr -d '\n'" , "1")

[kadel]

👍 that looks better.
It might be good to change function name pingCmd doesn't really indicate what this function does.
Also, don't forget to add a comment with a description what this function is for.

[kadel]

what happens when outInt is 0 or less?

[ashetty1]

@kadel continues in the loop for 5 minutes

[kadel]

Shouldn't be this timeout shorter? 5mins is really long time.
How about 1min? Is there a chance that after 1min the command will succeed?

[ashetty1]

Sure. Have changed it to 1min for now. ALso, have changed the function name to waitForCmdOut

[kadel]

The comment should be before the function.
Check this out https://blog.golang.org/godoc-documenting-go-code

[kadel]

why \ at the end of each line?

There is a standard in go, that comment for function starts with a function name.

[ashetty1]

@kadel hope this works.