Added confirmation for storage deletion #447
Conversation
cmd/storage.go
Outdated
| if storageForceDeleteflag { | ||
| confirmDeletion = "y" | ||
| } else { | ||
| fmt.Printf("Are you sure you want to delete the application: %v? [y/N] ", storageName) |
surajnarwade
force-pushed
the
storage-del
branch
2 times, most recently
from
9b71a1a to
5f27b38
Compare
|
ping @kadel |
kadel
added
the
needs-rebase
cmd/storage.go
Outdated
| err = storage.Remove(client, storageName, applicationName, componentName) | ||
| checkError(err, "failed to delete storage") | ||
| switch storageName { | ||
| case "": |
There was a problem hiding this comment.
deleting all storage from component was removed in #463
This should be addressed in rebase
surajnarwade
removed
the
needs-rebase
kadel
added
the
needs-rebase
cmd/storage.go
Outdated
| if storageForceDeleteflag { | ||
| confirmDeletion = "y" | ||
| } else { | ||
| fmt.Printf("Are you sure you want to delete the storage: %v? [y/N] ", storageName) |
There was a problem hiding this comment.
It would be good if this would also show if the storage is mounted or not and if yes than to what component.
If not mounted:
Are you sure you want to delete the storage %v?
if mounted:
Are you sure you want to delete the storage %v mounted to %s in %s component?
For example:
Are you sure you want to delete the storage data mounted to /data in backend component?
There was a problem hiding this comment.
I've opened new issue to address this. So we don't' have to block this pr
Why only partially? |
surajnarwade
removed
the
needs-rebase
kadel
added
the
needs-rebase
|
Sorry about that. It needs another rebase :-( |
|
@kadel no worries, that was easy rebase :P |
surajnarwade
removed
the
needs-rebase
|
Great work @surajnarwade. |
fixes #228