Porting GetLabelValues & DeleteProject function to client-go
#448
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
surajnarwade
added
do-not-merge/hold
surajnarwade
force-pushed
the
port-func-go
branch
5 times, most recently
from
8f7e629 to
df9cda3
Compare
surajnarwade
changed the title
GetLabelValues function to client-goGetLabelValues & DeleteProject function to client-go
surajnarwade
force-pushed
the
port-func-go
branch
from
df9cda3 to
e9e299f
Compare
kadel
requested changes
May 14, 2018
pkg/occlient/occlient.go
Outdated
| return nil, err | ||
| } | ||
|
|
||
| appLabel, _ := c.appsClient.DeploymentConfigs(project).List(metav1.ListOptions{LabelSelector: selector}) |
There was a problem hiding this comment.
why is variable called appLabel? When it is containing List of DeploymentConfigs.
surajnarwade
force-pushed
the
port-func-go
branch
from
e9e299f to
255fdf9
Compare
Partially fixes redhat-developer#444, This PR will port `GetLabelValues` & `DeleteProject` to client-go. so that it will remove dependency of `oc` binary.
surajnarwade
force-pushed
the
port-func-go
branch
from
255fdf9 to
17f4258
Compare
surajnarwade
changed the title
GetLabelValues & DeleteProject function to client-goGetLabelValues & DeleteProject function to client-go
surajnarwade
removed
the
do-not-merge/hold
kadel
approved these changes
May 18, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially fixes #444, This PR will port
GetLabelValues&DeleteProjectto client-go. so that it will remove dependency of
ocbinary.