Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix confirmation message when deleting storage #476

Merged
merged 1 commit into from
May 28, 2018
Merged

Fix confirmation message when deleting storage #476

merged 1 commit into from
May 28, 2018

Conversation

kadel
Copy link
Member

@kadel kadel commented May 25, 2018

@kadel
Fix confirmation message when deleting storage
bd6a1df 
Also fixes descriptions for --component flag and removes this flag from
'storage delete' command
@kadel kadel requested a review from surajnarwade May 25, 2018 13:06
cdrage
cdrage approved these changes May 25, 2018
View reviewed changes
Copy link
Member

@cdrage cdrage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kadel kadel merged commit f42498a into redhat-developer:master May 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cdrage cdrage cdrage approved these changes

@surajnarwade surajnarwade Awaiting requested review from surajnarwade

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Wrong storage info displayed in odo storage delete update description for global storage flag --component
2 participants
@kadel @cdrage