Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added confirmation before deleting URL #479

Merged
merged 1 commit into from
May 29, 2018
Merged

Added confirmation before deleting URL #479

merged 1 commit into from
May 29, 2018

Conversation

surajnarwade
Copy link
Contributor

Solves #474

odo url delete nodejs
Are you sure you want to delete the url nodejs? [y/N] y
Deleted URL: nodejs

@surajnarwade
Copy link
Contributor Author

@kadel , does this output looks good ?

kadel
kadel requested changes May 28, 2018
View reviewed changes
Copy link
Member

@kadel kadel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similar to other "delete" commands there should be a -f flag to delete without asking for confirmation.

No tests failed, so it looks like we are currently not testing odo url delete in our e2e tests. Can you please add test covering this?

@surajnarwade
Copy link
Contributor Author

@kadel thanks for the review, I will add tests and code accordingly

@surajnarwade
Added confirmation before deleting URL
2051a7b 
Solves redhat-developer#474

```
odo url delete nodejs
Are you sure you want to delete the url nodejs? [y/N] y
Deleted URL: nodejs
```
@surajnarwade
Copy link
Contributor Author

@kadel tests and code added :)

mik-dass
mik-dass approved these changes May 29, 2018
View reviewed changes
Copy link
Contributor

@mik-dass mik-dass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kadel kadel merged commit bcce9f7 into redhat-developer:master May 29, 2018
@kadel kadel mentioned this pull request May 29, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mik-dass mik-dass mik-dass approved these changes

@kadel kadel kadel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@surajnarwade @kadel @mik-dass