add unit test for CreatePVC #499
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
syamgk
added
the
do-not-merge/work-in-progress
cdrage
suggested changes
Jun 4, 2018
pkg/occlient/occlient_test.go
Outdated
| // Checks for return values in positive cases | ||
| if err == nil { | ||
| createdPVC := fkclientset.Kubernetes.Actions()[0].(ktesting.CreateAction).GetObject().(*corev1.PersistentVolumeClaim) | ||
| // fmt.Println(createdPVC) |
pkg/occlient/occlient_test.go
Outdated
| if !reflect.DeepEqual(createdPVC.Labels, tt.labels) { | ||
| t.Errorf("labels in created route is not matching expected labels, expected: %v, got: %v", tt.labels, createdPVC.Labels) | ||
| } | ||
| // name and size that route is pointg to should match |
pkg/occlient/occlient_test.go
Outdated
| // name and size that route is pointg to should match | ||
| // if createdPVC.Size != tt.size { | ||
| // t.Errorf("route is not matching to expected service name, expected: %s, got %s", tt.size, createdPVC.Size) | ||
| // } |
There was a problem hiding this comment.
sorry this is a WIP and i still have to add checks for the size of createdPVC
|
@syamgk You need to add a description to all your commit messages as well! It helps when generating a changelog. |
syamgk
removed
the
do-not-merge/work-in-progress
kadel
requested changes
Jun 6, 2018
pkg/occlient/occlient_test.go
Outdated
| // Checks for error in positive cases | ||
| if !tt.wantErr == (err != nil) { | ||
| t.Errorf(" client.CreatePVC(name, size, labels) unexpected error %v, wantErr %v", err, tt.wantErr) | ||
| return |
pkg/occlient/occlient_test.go
Outdated
| // Checks for return values in positive cases | ||
| if err == nil { | ||
| createdPVC := fkclientset.Kubernetes.Actions()[0].(ktesting.CreateAction).GetObject().(*corev1.PersistentVolumeClaim) | ||
| quantity, _ := resource.ParseQuantity(tt.size) |
| labels map[string]string | ||
| wantErr bool | ||
| }{ | ||
| { |
There was a problem hiding this comment.
there should also be some tests that result in error. For example invalid size value
add unit test for CreatePVC function
kadel
approved these changes
Jun 7, 2018
surajnarwade
approved these changes
Jun 8, 2018
cdrage
approved these changes
Jun 8, 2018
This was referenced Sep 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add unit-test for CreatePVC