Add new examples #515
Add new examples #515
Conversation
cmd/create.go
Outdated
| # Create a Python component | ||
| odo create python | ||
| # List of ready-to-use examples | ||
| odo create httpd --git https://github.com/openshift/httpd-ex.git |
There was a problem hiding this comment.
Does it really make sense to list all the possibilities here?
It looks really polluted. And to be honest is there any benefit of it?
I like the docs/examples.md document. But I'm not sure about listing everything here.
Examples here should be there just for users to help them understand the command variations and structure
There was a problem hiding this comment.
We could include maybe one and a link to more examples? What do you think
There was a problem hiding this comment.
something like, For more examples....
There was a problem hiding this comment.
We could include maybe one and a link to more examples? What do you think
That would be much better.
|
LGTM :) |
cmd/create.go
Outdated
| # Create a Python component | ||
| odo create python | ||
| # List of ready-to-use examples | ||
| # for more examples, visit: https://github.com/redhat-developer/odo/blob/master/docs/examples.md |
cmd/create.go
Outdated
| odo create python | ||
| # List of ready-to-use examples | ||
| # for more examples, visit: https://github.com/redhat-developer/odo/blob/master/docs/examples.md | ||
| odo create php --git https://github.com/openshift/cakephp-ex.git |
There was a problem hiding this comment.
Would it make sense to remove this completely and just keep the note above?
There was a problem hiding this comment.
IMO adding something that is not NodeJS would help with our diversification of languages (showcase that all languages are first-class citizens)
Adds a list of different examples (using each language that OpenShift catalog supports) as well as updates the `create.go` command to list each and every one of them!
cdrage
force-pushed
the
add-more-examples
branch
from
e795f86 to
b77f742
Compare
|
@kadel Updated! |
Adds a list of different examples (using each language that OpenShift
catalog supports) as well as updates the
create.gocommand to listeach and every one of them!