Adds a warning/error message when pushing local component #573
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kadel
requested changes
Jul 11, 2018
cmd/push.go
Outdated
| @@ -61,6 +61,10 @@ var pushCmd = &cobra.Command{ | |||
| case "local", "binary": | |||
| // use value of '--dir' as source if it was used | |||
| if len(componentLocal) != 0 { | |||
| if sourceType == "binary" { | |||
| fmt.Println("unable to push local directory:" + componentLocal + " to component " + componentName + " that uses binary " + sourcePath) | |||
There was a problem hiding this comment.
Please use fmt.Printf. The message should be a sentence starting with the capital letter and ending with '.',
…ent with a git repo or binary file as source in buildConfig Signed-off-by: mdas <mrinald7@gmail.com>
mik-dass
force-pushed
the
warn_push_source
branch
from
5c40914 to
40e5c78
Compare
|
This LGTM |
|
@mik-dass Please update your commit message / PR description :) |
|
@cdrage Done |
|
@mik-dass Your commit message still doesn't match your PR description. Use Your current commit message is: …ent with a git repo or binary file as source in buildConfig |
|
@cdrage But I guess my current commit message is Even |
kadel
approved these changes
Jul 25, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #571
Signed-off-by: mdas mrinald7@gmail.com
Adds a warning/error message when pushing local component to a component with a git repo or binary file as source in buildConfig