Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename configEnvName & func getOcdevConfigFile in config.go #583

Merged
merged 1 commit into from
Jul 23, 2018

Conversation

syamgk
Copy link
Member

@syamgk syamgk commented Jul 13, 2018

rename configEnvName in config.go to ODOCONFIG

rename func getOcdevConfigFile in config.go to getOdoConfigFile

@syamgk syamgk changed the title rename configEnvName in config.go to ODOCONFIG rename configEnvName & func getOcdevConfigFile in config.go Jul 16, 2018
@cdrage
Copy link
Member

cdrage commented Jul 18, 2018

LGTM

Copy link
Contributor

@mik-dass mik-dass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@mik-dass
Copy link
Contributor

@syamgk Please squash the commits into one before merging

rename configEnvName in config.go to `ODOCONFIG`

rename func getOcdevConfigFile in config.go to getOdoConfigFile
@syamgk syamgk force-pushed the rename-env-ocdevconfig branch from d17503d to 9864b74 Compare July 23, 2018 05:24
@surajnarwade
Copy link
Contributor

LGTM

@surajnarwade surajnarwade merged commit e619a46 into redhat-developer:master Jul 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants