Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a file to track latest release version #613

Merged
merged 5 commits into from
Aug 23, 2018
Merged

Add a file to track latest release version #613

merged 5 commits into from
Aug 23, 2018

Conversation

syamgk
Copy link
Member

@syamgk syamgk commented Aug 2, 2018

add a file to track latest release version
as mentioned in #593 (comment)

@syamgk
Add a file to track latest release version
547a791 
add a file to track latest release version
as mentioned in redhat-developer#593 (comment)
@syamgk syamgk force-pushed the addreleasedversion branch from 1f9600e to 547a791 Compare August 2, 2018 12:25
@syamgk syamgk changed the title Add file to track latest release version Add a file to track latest release version Aug 2, 2018
mik-dass
mik-dass previously approved these changes Aug 7, 2018
View reviewed changes
Copy link
Contributor

@mik-dass mik-dass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@syamgk syamgk requested a review from kadel August 8, 2018 10:28
kadel
kadel requested changes Aug 8, 2018
View reviewed changes
Copy link
Member

@kadel kadel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there is a section in contribution.md document describing how to do release that needs to be updated and also scripts/bump-version.sh should be updated to modify this file

scripts/.latest-release Outdated
@@ -0,0 +1 @@
v0.0.8
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

v0.0.9

@surajnarwade
Copy link
Contributor

@syamgk , as per @kadel suggestion, look into scripts/bump-version.sh
we should not manually edit this kind of version files

@syamgk
Copy link
Member Author

syamgk commented Aug 9, 2018 •
edited
Loading

@kadel @surajnarwade as per #593 (comment)
what I understood is that on step number 2 bump-version.sh will change the version before binary becomes available, so we have to keep the version in a separate file which we can update once the binary becomes available
Is that correct?

what do you guys think?

@kadel
Copy link
Member

kadel commented Aug 10, 2018

Good point @syamgk you are right.
We will have to update this as the last step in the release process. Can you please update development.md docs and add this as the step in the release process? It might be also worth adding a message/reminder to the bump-version.sh script, I believe that something similar is already there regarding homebrew package.

@kadel kadel requested review from cdrage and surajnarwade August 14, 2018 09:00
mik-dass
mik-dass approved these changes Aug 14, 2018
View reviewed changes
Copy link
Contributor

@mik-dass mik-dass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kadel
Copy link
Member

kadel commented Aug 14, 2018

Ah, I didn't notice that it is scripts/.latest-release. Shouldn't it be better if this would be in root directory (.latest-release)?

cdrage
cdrage reviewed Aug 15, 2018
View reviewed changes
scripts/.latest-release Outdated
@@ -0,0 +1 @@
v0.0.9
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe instead using a build dir within the root similar to https://github.com/kubernetes/kompose/blob/master/build/VERSION which will contain a RELEASE.md on instructions how to release?

@kadel

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yp, that would also work

@syamgk syamgk force-pushed the addreleasedversion branch from e72dbd8 to 6929b21 Compare August 16, 2018 09:10
cdrage
cdrage suggested changes Aug 17, 2018
View reviewed changes
build/VERSION Outdated
@@ -0,0 +1 @@
v0.0.9
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need to remove the v

surajnarwade
surajnarwade approved these changes Aug 23, 2018
View reviewed changes
Copy link
Contributor

@surajnarwade surajnarwade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@syamgk syamgk mentioned this pull request Aug 23, 2018
Merged
@cdrage
Copy link
Member

cdrage commented Aug 23, 2018

2 LGTM's. Merging.

@cdrage cdrage merged commit 52baa85 into redhat-developer:master Aug 23, 2018
@surajnarwade surajnarwade mentioned this pull request Aug 24, 2018
Merged
@syamgk syamgk mentioned this pull request Sep 5, 2018
Closed
@cdrage cdrage mentioned this pull request Sep 5, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kadel kadel kadel approved these changes

@surajnarwade surajnarwade surajnarwade approved these changes

@mik-dass mik-dass mik-dass approved these changes

@cdrage cdrage cdrage approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@syamgk @surajnarwade @kadel @cdrage @mik-dass