Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Corrected spelling mistakes and some grammatical errors. #650

Merged
merged 2 commits into from
Aug 23, 2018

Conversation

acgoliyan
Copy link
Contributor

Made the verbal part grammatically correct and corrected some misspelled words.

@acgoliyan acgoliyan closed this Aug 19, 2018
@acgoliyan acgoliyan reopened this Aug 19, 2018
@kadel
Copy link
Member

kadel commented Aug 20, 2018

Thank you, @acgoliyan.

@@ -12,8 +12,8 @@ import (
"github.com/redhat-developer/odo/pkg/project"
)

// getDefaultAppName returns application name to be used as a default name in the case where users doesn't provide a name
// In future this function should generate name with uniq suffix (app-xy1h), because there might be multiple applications.
// getDefaultAppName returns application name to be used as a default name in case of user doesn't provide a name.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess it should be "... in case the user doesn't provide"

Copy link
Contributor Author

@acgoliyan acgoliyan Aug 20, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thankyou @mik-dass for reviewing. Yes you are right, "USERS" should be replaced by "USER".
plus here i made it to "in case of" which means what should be done in case of something might happen(possibility "user doesn't provide file name").
here is the reference.
http://englishstudypage.com/grammar/in-case-of-vs-in-the-case-of-in-english/

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@acgoliyan Thanks for contributing 👍 But I was suggesting in case the user not in the case of. I think in case should be used here because http://speakspeak.com/resources/english-grammar-rules/various-grammar-rules/in-case-in-case-of

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mik-dass Sorry i misunderstood. You are absolutely right "in case" is right to use here.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@acgoliyan No problem thanks again for the contribution 👍

Copy link
Contributor

@surajnarwade surajnarwade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for your contribution :)

Copy link
Contributor

@mik-dass mik-dass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mik-dass mik-dass merged commit 5371e1d into redhat-developer:master Aug 23, 2018
@surajnarwade surajnarwade mentioned this pull request Aug 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants