-
Notifications
You must be signed in to change notification settings - Fork 244
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Corrected spelling mistakes and some grammatical errors. #650
Conversation
Thank you, @acgoliyan. |
pkg/application/application.go
Outdated
@@ -12,8 +12,8 @@ import ( | |||
"github.com/redhat-developer/odo/pkg/project" | |||
) | |||
|
|||
// getDefaultAppName returns application name to be used as a default name in the case where users doesn't provide a name | |||
// In future this function should generate name with uniq suffix (app-xy1h), because there might be multiple applications. | |||
// getDefaultAppName returns application name to be used as a default name in case of user doesn't provide a name. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess it should be "... in case the user doesn't provide"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thankyou @mik-dass for reviewing. Yes you are right, "USERS" should be replaced by "USER".
plus here i made it to "in case of" which means what should be done in case of something might happen(possibility "user doesn't provide file name").
here is the reference.
http://englishstudypage.com/grammar/in-case-of-vs-in-the-case-of-in-english/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@acgoliyan Thanks for contributing 👍 But I was suggesting in case the user not in the case of. I think in case should be used here because http://speakspeak.com/resources/english-grammar-rules/various-grammar-rules/in-case-in-case-of
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mik-dass Sorry i misunderstood. You are absolutely right "in case" is right to use here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@acgoliyan No problem thanks again for the contribution 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for your contribution :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Made the verbal part grammatically correct and corrected some misspelled words.