Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run Docs tests on CI/CD #6521

Merged
merged 3 commits into from
Jan 25, 2023
Merged

Run Docs tests on CI/CD #6521

merged 3 commits into from
Jan 25, 2023

Conversation

feloy
Copy link
Contributor

@feloy feloy commented Jan 20, 2023 •
edited
Loading

What type of PR is this:
/kind tests

What does this PR do / why we need it:

Docs tests are executed on the same Kubernetes cluster as the Kubernetes integration tests, at the same time.

These docs tests are exectued one at a time, it should not impact the integration tests.

Which issue(s) this PR fixes:

Fixes #6517

PR acceptance criteria:

  • Unit test

  • Integration test

  • Documentation

How to test changes / Special notes to the reviewer:

@netlify
Copy link

netlify bot commented Jan 20, 2023 •
edited
Loading

✅ Deploy Preview for odo-docusaurus-preview canceled.

Name Link
🔨 Latest commit 49f562c
🔍 Latest deploy log https://app.netlify.com/sites/odo-docusaurus-preview/deploys/63d0fb53c31524000adda719

@feloy feloy mentioned this pull request Jan 20, 2023
Closed
3 tasks
@feloy feloy requested review from rm3l and anandrkskd and removed request for anandrkskd January 20, 2023 15:46
@odo-robot
Copy link

odo-robot bot commented Jan 20, 2023 •
edited
Loading

OpenShift Tests on commit 2d4ef3a finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Jan 20, 2023 •
edited
Loading

NoCluster Tests on commit 2d4ef3a finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Jan 20, 2023 •
edited
Loading

Kubernetes Tests on commit 2d4ef3a finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Jan 20, 2023 •
edited
Loading

Unit Tests on commit 2d4ef3a finished successfully.
View logs: TXT HTML

@feloy feloy closed this Jan 20, 2023
@feloy feloy reopened this Jan 20, 2023
@odo-robot
Copy link

odo-robot bot commented Jan 20, 2023 •
edited
Loading

Validate Tests on commit 2d4ef3a finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Jan 20, 2023 •
edited
Loading

Windows Tests (OCP) on commit 2d4ef3a finished successfully.
View logs: TXT HTML

@valaparthvi valaparthvi reopened this Jan 23, 2023
@feloy feloy changed the title Run Docs tests on CI/CD [WIP] Run Docs tests on CI/CD Jan 23, 2023
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. Required by Prow. label Jan 23, 2023
@valaparthvi valaparthvi reopened this Jan 24, 2023
@feloy feloy reopened this Jan 24, 2023
anandrkskd
anandrkskd reviewed Jan 24, 2023
View reviewed changes
.ibm/pipelines/kubernetes-tests.sh Outdated
@@ -16,6 +16,7 @@ export SKIP_USER_LOGIN_TESTS=true
echo Using Devfile proxy: ${DEVFILE_PROXY}
make install
make test-integration-cluster
make test-doc-automation
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@feloy why do we need to run make test-doc-automation on both file?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, I'm checking on which one it passes. I'll remove one of them when the other one passes

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Understood, Thanks Philippe

@feloy feloy closed this Jan 25, 2023
@feloy feloy reopened this Jan 25, 2023
@feloy feloy force-pushed the cicd-doc-tests-main branch from ad4aef2 to b42d30c Compare January 25, 2023 08:44
@feloy feloy force-pushed the cicd-doc-tests-main branch from 4d04380 to 49f562c Compare January 25, 2023 09:50
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@feloy feloy changed the title [WIP] Run Docs tests on CI/CD Run Docs tests on CI/CD Jan 25, 2023
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. Required by Prow. label Jan 25, 2023
@feloy feloy requested a review from anandrkskd January 25, 2023 10:11
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Jan 25, 2023
@feloy
Copy link
Contributor Author

feloy commented Jan 25, 2023

/override ci/prow/v4.11-integration-e2e
Not related

@openshift-ci
Copy link

openshift-ci bot commented Jan 25, 2023

@feloy: Overrode contexts on behalf of feloy: ci/prow/v4.11-integration-e2e

In response to this:

/override ci/prow/v4.11-integration-e2e
Not related

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@feloy
Copy link
Contributor Author

feloy commented Jan 25, 2023

/override ci/prow/v4.11-integration-e2e
Flaky e2e test

@openshift-ci
Copy link

openshift-ci bot commented Jan 25, 2023

@feloy: Overrode contexts on behalf of feloy: ci/prow/v4.11-integration-e2e

In response to this:

/override ci/prow/v4.11-integration-e2e
Flaky e2e test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot openshift-merge-robot merged commit facfb79 into redhat-developer:main Jan 25, 2023
@rm3l rm3l mentioned this pull request Feb 20, 2023
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rm3l rm3l rm3l approved these changes

@valaparthvi valaparthvi Awaiting requested review from valaparthvi

@anandrkskd anandrkskd Awaiting requested review from anandrkskd

Assignees

@rm3l rm3l

Labels
lgtm Indicates that a PR is ready to be merged. Required by Prow.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Setup IBM or prow jobs for the doc tests to run on every PR.
5 participants
@feloy @rm3l @anandrkskd @valaparthvi @openshift-merge-robot