Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release PR for v3.6.0 #6529

Merged
merged 6 commits into from
Jan 31, 2023
Merged

Release PR for v3.6.0 #6529

merged 6 commits into from
Jan 31, 2023

Conversation

github-actions[bot]
Copy link
Contributor

/area documentation
/area release-eng
/hold

Draft PR for new release: v3.6.0

Fixes #

Feel free to edit and push to this branch.

NOTE: Remove the hold and consider merging this PR only when binaries for this release are publicly available on developers.redhat.com.

@github-actions github-actions bot requested a review from valaparthvi January 24, 2023 08:31
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. Required by Prow. label Jan 24, 2023
@netlify
Copy link

netlify bot commented Jan 24, 2023 •
edited
Loading

✅ Deploy Preview for odo-docusaurus-preview ready!

Name Link
🔨 Latest commit ceff10d
🔍 Latest deploy log https://app.netlify.com/sites/odo-docusaurus-preview/deploys/63d91b9edc29650008b90427
😎 Deploy Preview https://deploy-preview-6529--odo-docusaurus-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@openshift-ci openshift-ci bot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. Required by Prow. area/documentation Issues or PRs related to documentation or the 'odo.dev' website area/release-eng Issues or PRs related to the Release Engineering needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. Required by Prow. labels Jan 24, 2023
@openshift-ci
Copy link

openshift-ci bot commented Jan 24, 2023

Hi @github-actions[bot]. Thanks for your PR.

I'm waiting for a redhat-developer member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@rm3l rm3l added this to the v3.6.0 🚀 milestone Jan 24, 2023
@odo-robot
Copy link

odo-robot bot commented Jan 24, 2023 •
edited
Loading

NoCluster Tests on commit bd0e36e finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Jan 24, 2023 •
edited
Loading

OpenShift Tests on commit bd0e36e finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Jan 24, 2023 •
edited
Loading

Unit Tests on commit bd0e36e finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Jan 24, 2023 •
edited
Loading

Validate Tests on commit bd0e36e finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Jan 24, 2023 •
edited
Loading

Kubernetes Tests on commit bd0e36e finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Jan 24, 2023 •
edited
Loading

Windows Tests (OCP) on commit bd0e36e finished successfully.
View logs: TXT HTML

@valaparthvi
Update the release blog
6618a9c 
Signed-off-by: Parthvi Vala <pvala@redhat.com>
@valaparthvi valaparthvi changed the title [WIP] Release PR for v3.6.0 Release PR for v3.6.0 Jan 31, 2023
@valaparthvi
Copy link
Contributor

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. Required by Prow. label Jan 31, 2023
@valaparthvi
Copy link
Contributor

/ok-to-test

@openshift-ci openshift-ci bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. Required by Prow. labels Jan 31, 2023
@valaparthvi valaparthvi removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. Required by Prow. label Jan 31, 2023
@valaparthvi valaparthvi marked this pull request as ready for review January 31, 2023 11:55
@openshift-ci openshift-ci bot requested a review from feloy January 31, 2023 11:55
rm3l
rm3l reviewed Jan 31, 2023
View reviewed changes
docs/website/blog/2023-01-24-odo-v3.6.0.md
### Features

#### Extend pod and container specification with Devfile attributes `pod-overrides` and `container-overrides`
It is now possible to extend a pod and its container specification by using `pod-overrides` and `container-overrides` Devfile attributes.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just wondering if this shouldn't be documented also on the Devfile.io website, so we can link to that page here.. Maybe I missed it, but is it documented there?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR for devfile is still a WIP. I can update the blog once the PR goes in.
devfile/devfile-web#70

docs/website/blog/2023-01-24-odo-v3.6.0.md Outdated Show resolved Hide resolved
docs/website/blog/2023-01-24-odo-v3.6.0.md Outdated Show resolved Hide resolved
@valaparthvi @rm3l
Update docs/website/blog/2023-01-24-odo-v3.6.0.md
5093864 
Co-authored-by: Armel Soro <asoro@redhat.com>
@valaparthvi
Add note about attributes defined at both the levels
ceff10d 
Signed-off-by: Parthvi Vala <pvala@redhat.com>
@valaparthvi valaparthvi requested a review from rm3l January 31, 2023 13:46
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

rm3l
rm3l approved these changes Jan 31, 2023
View reviewed changes
Copy link
Member

@rm3l rm3l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks!

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Jan 31, 2023
@feloy
Copy link
Contributor

feloy commented Jan 31, 2023

/override ci/prow/v4.11-integration-e2e
Not related

@openshift-ci
Copy link

openshift-ci bot commented Jan 31, 2023

@feloy: Overrode contexts on behalf of feloy: ci/prow/v4.11-integration-e2e

In response to this:

/override ci/prow/v4.11-integration-e2e
Not related

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot openshift-merge-robot merged commit d2665c0 into main Jan 31, 2023
@rm3l rm3l deleted the blog_post_v3.6.0 branch February 20, 2023 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rm3l rm3l rm3l approved these changes

@valaparthvi valaparthvi Awaiting requested review from valaparthvi

@feloy feloy Awaiting requested review from feloy

Assignees

@rm3l rm3l

Labels
area/documentation Issues or PRs related to documentation or the 'odo.dev' website area/release-eng Issues or PRs related to the Release Engineering lgtm Indicates that a PR is ready to be merged. Required by Prow. ok-to-test Indicates a non-member PR verified by an org member that is safe to test.
Projects
None yet
Milestone
v3.6.0 🚀
Development

Successfully merging this pull request may close these issues.
4 participants
@valaparthvi @feloy @rm3l @openshift-merge-robot