Make sure to delete the component resources after each "delete component" test spec #6541
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…component" test spec Otherwise, "odo delete component --running-in $mode" might leave some resources running (on Podman especially). For example, the Podman test that runs "delete component --running-in deploy" (after starting and killing a Dev Session abruptly) might leave those Dev resources running. This has been alleviated in CI via 9ebf766 by ensuring Ginkgo does not hang indefinitely and by deleting those leftover resources. But the issue was still persisting locally.
✅ Deploy Preview for odo-docusaurus-preview ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
openshift-ci
bot
added
kind/tests
area/testing
|
Kudos, SonarCloud Quality Gate passed!
|
feloy
approved these changes
Jan 26, 2023
openshift-ci
bot
added
the
lgtm
|
/override ci/prow/v4.11-integration-e2e Flaky E2E test (reported in #6463) |
|
@rm3l: Overrode contexts on behalf of rm3l: ci/prow/v4.11-integration-e2e In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
rm3l
deleted the
make_sure_to_delete_component_resources_after_each_delete_component_test
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this:
/kind tests
/area testing
What does this PR do / why we need it:
Which issue(s) this PR fixes:
Otherwise, "odo delete component --running-in $mode" might leave some resources running
(on Podman especially).
For example, the Podman test that runs "delete component --running-in deploy"
(after starting and killing a Dev Session abruptly) might leave those Dev resources running.
This has been alleviated in CI via 9ebf766 by ensuring Ginkgo does not hang indefinitely and
by deleting those leftover resources.
But the issue was still persisting locally.
PR acceptance criteria:
Unit test
Integration test
Documentation
How to test changes / Special notes to the reviewer: