Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump version to v3.7.0 #6596

Conversation

rm3l
Copy link
Member

@rm3l rm3l commented Feb 15, 2023

What type of PR is this:

What does this PR do / why we need it:

Which issue(s) this PR fixes:
Relates to #6413

PR acceptance criteria:

  • Unit test

  • Integration test

  • Documentation

How to test changes / Special notes to the reviewer:

@rm3l rm3l added the area/release-eng Issues or PRs related to the Release Engineering label Feb 15, 2023
@netlify
Copy link

netlify bot commented Feb 15, 2023

Deploy Preview for odo-docusaurus-preview ready!

Name Link
🔨 Latest commit 1a11d7d
🔍 Latest deploy log https://app.netlify.com/sites/odo-docusaurus-preview/deploys/63ecc4022159b500077047fe
😎 Deploy Preview https://deploy-preview-6596--odo-docusaurus-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@rm3l rm3l requested review from feloy and removed request for rnapoles-rh February 15, 2023 10:38
@odo-robot
Copy link

odo-robot bot commented Feb 15, 2023

OpenShift Unauthenticated Tests on commit e983fec finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Feb 15, 2023

NoCluster Tests on commit e983fec finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Feb 15, 2023

Unit Tests on commit e983fec finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Feb 15, 2023

Validate Tests on commit e983fec finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Feb 15, 2023

Kubernetes Tests on commit e983fec finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Feb 15, 2023

Windows Tests (OCP) on commit e983fec finished with errors.
View logs: TXT HTML

@rm3l
Copy link
Member Author

rm3l commented Feb 15, 2023

Expected
      <*url.Error | 0xc00038af30>: {
          Op: "Post",
          URL: "http://127.0.0.1:61285/api/newuser",
          Err: <*errors.errorString | 0xc00007c130>{s: "EOF"},
      }
  to be nil
  In [It] at: C:/Users/Administrator.ANSIBLE-TEST-VS/3255/tests/e2escenarios/e2e_test.go:306

  There were additional failures detected after the initial failure.  Here's a summary - for full details run Ginkgo in verbose mode:
    [FAILED] in [AfterEach] at C:/Users/Administrator.ANSIBLE-TEST-VS/3255/tests/helper/helper_filesystem.go:49
------------------------------


Summarizing 1 Failure:
  [FAIL] E2E Test starting with non-empty Directory add Binding [It] should verify developer workflow of using binding as env in innerloop
  C:/Users/Administrator.ANSIBLE-TEST-VS/3255/tests/e2escenarios/e2e_test.go:306

/override windows-integration-test/Windows-test

Flaky E2E test - following up in #6582

@odo-robot
Copy link

odo-robot bot commented Feb 15, 2023

OpenShift Tests on commit e983fec finished successfully.
View logs: TXT HTML

@openshift-ci
Copy link

openshift-ci bot commented Feb 15, 2023

@rm3l: Overrode contexts on behalf of rm3l: windows-integration-test/Windows-test

In response to this:

Expected
     <*url.Error | 0xc00038af30>: {
         Op: "Post",
         URL: "http://127.0.0.1:61285/api/newuser",
         Err: <*errors.errorString | 0xc00007c130>{s: "EOF"},
     }
 to be nil
 In [It] at: C:/Users/Administrator.ANSIBLE-TEST-VS/3255/tests/e2escenarios/e2e_test.go:306

 There were additional failures detected after the initial failure.  Here's a summary - for full details run Ginkgo in verbose mode:
   [FAILED] in [AfterEach] at C:/Users/Administrator.ANSIBLE-TEST-VS/3255/tests/helper/helper_filesystem.go:49
------------------------------


Summarizing 1 Failure:
 [FAIL] E2E Test starting with non-empty Directory add Binding [It] should verify developer workflow of using binding as env in innerloop
 C:/Users/Administrator.ANSIBLE-TEST-VS/3255/tests/e2escenarios/e2e_test.go:306

/override windows-integration-test/Windows-test

Flaky E2E test - following up in #6582

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@odo-robot
Copy link

odo-robot bot commented Feb 15, 2023

Kubernetes Docs Tests on commit 96e9adf finished successfully.
View logs: TXT HTML

@feloy
Copy link
Contributor

feloy commented Feb 15, 2023

You would need to update some doc to make the tests pass, for example:

 Expected
      <string>:   strings.Join({
        	... // 93 identical bytes
        	"me my-nodejs-app --starter nodejs-angular-starter\n__\n/  \\__     ",
        	"Initializing a new component\n\\__/  \\\n/  \\__/    odo version: v3.",
      - 	"6",
      + 	"7",
        	".0\n\\__/\n\n✓  Downloading devfile from \"https://registry.devfile",
        	".io/devfiles/nodejs-angular\" [1s]\n✓  Downloading starter proje",
        	... // 249 identical bytes
        }, "")
      
  to be empty
  In [It] at: /go/odo_1/tests/documentation/command-reference/doc_command_reference_init_test.go:123

@rm3l
Copy link
Member Author

rm3l commented Feb 15, 2023

You would need to update some doc to make the tests pass, for example:

 Expected
      <string>:   strings.Join({
        	... // 93 identical bytes
        	"me my-nodejs-app --starter nodejs-angular-starter\n__\n/  \\__     ",
        	"Initializing a new component\n\\__/  \\\n/  \\__/    odo version: v3.",
      - 	"6",
      + 	"7",
        	".0\n\\__/\n\n✓  Downloading devfile from \"https://registry.devfile",
        	".io/devfiles/nodejs-angular\" [1s]\n✓  Downloading starter proje",
        	... // 249 identical bytes
        }, "")
      
  to be empty
  In [It] at: /go/odo_1/tests/documentation/command-reference/doc_command_reference_init_test.go:123

Well, this is expected on one hand, but on the other hand, should we really update the docs at this point (at least until the 3.7.0 binaries are available)? Otherwise, this means that the docs will display 3.7.0, but this version is not published yet.

Anyway, those are "just" sample outputs, so I'll make the changes in the docs.
All tests should pass on the commit that will be tagged.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@rm3l
Copy link
Member Author

rm3l commented Feb 15, 2023

Expected
      <*url.Error | 0xc0006c9800>: {
          Op: "Post",
          URL: "http://127.0.0.1:63288/api/newuser",
          Err: <*errors.errorString | 0xc00007c130>{s: "EOF"},
      }
  to be nil
  In [It] at: C:/Users/Administrator.ANSIBLE-TEST-VS/3256/tests/e2escenarios/e2e_test.go:306

  There were additional failures detected after the initial failure.  Here's a summary - for full details run Ginkgo in verbose mode:
    [FAILED] in [AfterEach] at C:/Users/Administrator.ANSIBLE-TEST-VS/3256/tests/helper/helper_filesystem.go:49
------------------------------


Summarizing 1 Failure:
  [FAIL] E2E Test starting with non-empty Directory add Binding [It] should verify developer workflow of using binding as env in innerloop
  C:/Users/Administrator.ANSIBLE-TEST-VS/3256/tests/e2escenarios/e2e_test.go:306

Ran 7 of 7 Specs in 208.777 seconds
FAIL! -- 6 Passed | 1 Failed | 0 Pending | 0 Skipped

/override windows-integration-test/Windows-test

Flaky E2E test - following up in #6582

@openshift-ci
Copy link

openshift-ci bot commented Feb 15, 2023

@rm3l: Overrode contexts on behalf of rm3l: windows-integration-test/Windows-test

In response to this:

Expected
     <*url.Error | 0xc0006c9800>: {
         Op: "Post",
         URL: "http://127.0.0.1:63288/api/newuser",
         Err: <*errors.errorString | 0xc00007c130>{s: "EOF"},
     }
 to be nil
 In [It] at: C:/Users/Administrator.ANSIBLE-TEST-VS/3256/tests/e2escenarios/e2e_test.go:306

 There were additional failures detected after the initial failure.  Here's a summary - for full details run Ginkgo in verbose mode:
   [FAILED] in [AfterEach] at C:/Users/Administrator.ANSIBLE-TEST-VS/3256/tests/helper/helper_filesystem.go:49
------------------------------


Summarizing 1 Failure:
 [FAIL] E2E Test starting with non-empty Directory add Binding [It] should verify developer workflow of using binding as env in innerloop
 C:/Users/Administrator.ANSIBLE-TEST-VS/3256/tests/e2escenarios/e2e_test.go:306

Ran 7 of 7 Specs in 208.777 seconds
FAIL! -- 6 Passed | 1 Failed | 0 Pending | 0 Skipped

/override windows-integration-test/Windows-test

Flaky E2E test - following up in #6582

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Feb 15, 2023
@openshift-merge-robot openshift-merge-robot merged commit 262d11e into redhat-developer:main Feb 15, 2023
@rm3l rm3l deleted the 6413-release-for-sprint-231-v3.7.0 branch February 15, 2023 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/release-eng Issues or PRs related to the Release Engineering lgtm Indicates that a PR is ready to be merged. Required by Prow.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants