Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Node image compatible with Z and P environments #6626

Merged
merged 4 commits into from
Mar 1, 2023
Merged

Use Node image compatible with Z and P environments #6626

merged 4 commits into from
Mar 1, 2023

Conversation

HarshithaMS005
Copy link
Contributor

@HarshithaMS005 HarshithaMS005 commented Feb 28, 2023 •
edited by anandrkskd
Loading

What type of PR is this:

kind code-refactoring

What does this PR do / why we need it:
It fixes podman failures on Z and P environment which are due to image compatibility issue

Which issue(s) this PR fixes:

podman test cases image issue for Z and P

Fixes

  • Integration test

@netlify
Copy link

netlify bot commented Feb 28, 2023 •
edited
Loading

✅ Deploy Preview for odo-docusaurus-preview canceled.

Name Link
🔨 Latest commit c7ab039
🔍 Latest deploy log https://app.netlify.com/sites/odo-docusaurus-preview/deploys/63ff37cf04ec98000839f91f

@openshift-ci openshift-ci bot requested review from feloy and rnapoles-rh February 28, 2023 10:43
@openshift-ci openshift-ci bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. Required by Prow. label Feb 28, 2023
@openshift-ci
Copy link

openshift-ci bot commented Feb 28, 2023

Hi @HarshithaMS005. Thanks for your PR.

I'm waiting for a redhat-developer member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@odo-robot
Copy link

odo-robot bot commented Feb 28, 2023 •
edited
Loading

OpenShift Unauthenticated Tests on commit 9be5676 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Feb 28, 2023 •
edited
Loading

NoCluster Tests on commit 9be5676 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Feb 28, 2023 •
edited
Loading

Unit Tests on commit 9be5676 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Feb 28, 2023 •
edited
Loading

Validate Tests on commit 9be5676 finished successfully.
View logs: TXT HTML

@anandrkskd
Copy link
Contributor

/ok-to-test

@openshift-ci openshift-ci bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. Required by Prow. labels Feb 28, 2023
@odo-robot
Copy link

odo-robot bot commented Feb 28, 2023 •
edited
Loading

Kubernetes Tests on commit 9be5676 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Feb 28, 2023 •
edited
Loading

Windows Tests (OCP) on commit 9be5676 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Feb 28, 2023 •
edited
Loading

OpenShift Tests on commit 9be5676 finished with errors.
View logs: TXT HTML

@feloy
Copy link
Contributor

feloy commented Feb 28, 2023

as discussed in cabal, please pull this image to quay.io to avoid rate milits on Docker Hub. Thanks

@feloy
Copy link
Contributor

feloy commented Feb 28, 2023

For reproducibility, please also add a tag to the image

@odo-robot
Copy link

odo-robot bot commented Mar 1, 2023 •
edited
Loading

Kubernetes Docs Tests on commit 99d6450 finished successfully.
View logs: TXT HTML

rm3l
rm3l requested changes Mar 1, 2023
View reviewed changes
tests/examples/source/nodejs/Dockerfile Outdated Show resolved Hide resolved
@sonarqubecloud
Copy link

sonarqubecloud bot commented Mar 1, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Mar 1, 2023
@rm3l
Copy link
Member

rm3l commented Mar 1, 2023 

...

  Timed out after 360.000s.
  Expected
      <string>:   __
       /  \__     Developing using the "vmahxq" Devfile
       \__/  \    Namespace: cmd-logs-test143sdy
       /  \__/    odo version: v3.7.0
       \__/
      
      ↪ Running on the cluster in Dev mode
       •  Waiting for Kubernetes resources  ...
       •  Creating resource Pod/myapp-inner  ...
      
 ✓  Creating resource Pod/myapp-inner 
       ⚠  Pod is Pending
       •  Deleting resources not present in the Devfile: PodMetrics/myapp-inner  ...
      
 ✓  Deleting resources not present in the Devfile: PodMetrics/myapp-inner [1s]
      Error occurred on Push - watch command was unable to push component: unable to delete remote resources: unable to delete resource: PodMetrics/myapp-inner: the server does not allow this method on the requested resource
      
       •  Deleting resources not present in the Devfile: PodMetrics/myapp-inner  ...

...
Summarizing 1 Failure:
  [FAIL] odo logs command tests when component is created and odo logs is executed when running in Dev mode [BeforeEach] should successfully show logs of the running component
  /go/odo_1/tests/helper/helper_run.go:51

Ran 422 of 772 Specs in 1411.725 seconds
FAIL! -- 421 Passed | 1 Failed | 0 Pending | 350 Skipped

Flaky test - already tracked in #6475

/override OpenShift-Integration-tests/OpenShift-Integration-tests

@openshift-ci
Copy link

openshift-ci bot commented Mar 1, 2023

@rm3l: Overrode contexts on behalf of rm3l: OpenShift-Integration-tests/OpenShift-Integration-tests

In response to this:

...

 Timed out after 360.000s.
 Expected
     <string>:   __
      /  \__     Developing using the "vmahxq" Devfile
      \__/  \    Namespace: cmd-logs-test143sdy
      /  \__/    odo version: v3.7.0
      \__/
     
     ↪ Running on the cluster in Dev mode
      •  Waiting for Kubernetes resources  ...
      •  Creating resource Pod/myapp-inner  ...
     
✓  Creating resource Pod/myapp-inner 
      ⚠  Pod is Pending
      •  Deleting resources not present in the Devfile: PodMetrics/myapp-inner  ...
     
✓  Deleting resources not present in the Devfile: PodMetrics/myapp-inner [1s]
     Error occurred on Push - watch command was unable to push component: unable to delete remote resources: unable to delete resource: PodMetrics/myapp-inner: the server does not allow this method on the requested resource
     
      •  Deleting resources not present in the Devfile: PodMetrics/myapp-inner  ...

...
Summarizing 1 Failure:
 [FAIL] odo logs command tests when component is created and odo logs is executed when running in Dev mode [BeforeEach] should successfully show logs of the running component
 /go/odo_1/tests/helper/helper_run.go:51

Ran 422 of 772 Specs in 1411.725 seconds
FAIL! -- 421 Passed | 1 Failed | 0 Pending | 350 Skipped

Flaky test - already tracked in #6475

/override OpenShift-Integration-tests/OpenShift-Integration-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@rm3l rm3l changed the title nodejs-compatible-image-to-resolve-podman-testcases-issues Use Node image compatible with Z and P environments Mar 1, 2023
@rm3l rm3l added the area/testing Issues or PRs related to testing, Quality Assurance or Quality Engineering label Mar 1, 2023
@rm3l rm3l added this to the v3.8.0 🚀 milestone Mar 1, 2023
@openshift-merge-robot openshift-merge-robot merged commit 463c15d into redhat-developer:main Mar 1, 2023
anandrkskd pushed a commit to anandrkskd/odo that referenced this pull request Mar 7, 2023
@HarshithaMS005 @harshithams05 @anandrkskd
Use Node image compatible with Z and P environments (redhat-developer…
0bf6866 
…#6626)

* nodejs-compatible-image-to-resolve-podman-testcases-issues

* Update Dockerfile

* Update Dockerfile

* Update Dockerfile

---------

Co-authored-by: HarshithaMS <M.S.Harshitha@ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anandrkskd anandrkskd anandrkskd left review comments

@rm3l rm3l rm3l approved these changes

@feloy feloy Awaiting requested review from feloy

@rnapoles-rh rnapoles-rh Awaiting requested review from rnapoles-rh

Assignees

@rm3l rm3l

Labels
area/testing Issues or PRs related to testing, Quality Assurance or Quality Engineering lgtm Indicates that a PR is ready to be merged. Required by Prow. ok-to-test Indicates a non-member PR verified by an org member that is safe to test.
Projects
None yet
Milestone
v3.8.0 🚀
Development

Successfully merging this pull request may close these issues.
6 participants
@HarshithaMS005 @anandrkskd @feloy @rm3l @openshift-merge-robot @harshithams05