Remove podman from experimental mode #6628

feloy · 2023-02-28T14:24:05Z

What type of PR is this:

/kind feature

What does this PR do / why we need it:

Which issue(s) this PR fixes:

Fixes #6592

PR acceptance criteria:

Unit test
Integration test
Documentation

How to test changes / Special notes to the reviewer:

netlify · 2023-02-28T14:24:09Z

✅ Deploy Preview for odo-docusaurus-preview ready!

Name	Link
🔨 Latest commit	`b1ebb98`
🔍 Latest deploy log	https://app.netlify.com/sites/odo-docusaurus-preview/deploys/6405bfdac1876000089eabd0
😎 Deploy Preview	https://deploy-preview-6628--odo-docusaurus-preview.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

odo-robot · 2023-02-28T14:30:09Z

OpenShift Unauthenticated Tests on commit fee9482 finished successfully.
View logs: TXT HTML

odo-robot · 2023-02-28T14:30:33Z

NoCluster Tests on commit fee9482 finished successfully.
View logs: TXT HTML

odo-robot · 2023-02-28T14:32:01Z

Unit Tests on commit fee9482 finished successfully.
View logs: TXT HTML

odo-robot · 2023-02-28T14:38:12Z

Windows Tests (OCP) on commit fee9482 finished with errors.
View logs: TXT HTML

odo-robot · 2023-02-28T14:40:16Z

Validate Tests on commit fee9482 finished successfully.
View logs: TXT HTML

odo-robot · 2023-02-28T14:55:51Z

Kubernetes Tests on commit fee9482 finished successfully.
View logs: TXT HTML

odo-robot · 2023-02-28T15:16:10Z

OpenShift Tests on commit fee9482 finished successfully.
View logs: TXT HTML

odo-robot · 2023-02-28T15:54:31Z

Kubernetes Docs Tests on commit 851b171 finished successfully.
View logs: TXT HTML

feloy · 2023-03-03T12:48:07Z

This PR is ready for review. I would like to work on the latest task (add documentation explaining the limitations of podman implementations) on a different PR.

docs/website/docs/command-reference/delete-component.md

docs/website/docs/command-reference/describe-component.md

docs/website/docs/command-reference/list-component.md

docs/website/docs/command-reference/logs.md

docs/website/docs/command-reference/dev.md

valaparthvi · 2023-03-06T08:32:02Z

docs/website/blog/2023-01-30-local-container-dev-on-podman.md

@@ -146,9 +146,8 @@ If you skipped Step 0 and selected "starter project", your output will be slight
 ### Step 2. Enabling the experimental mode


Can we remove this section entirely now?

I would prefer not to, by changing only the strict minimum the blog posts (here, we need to remove the links to the removed experimental-mode page, to make the website build)

valaparthvi · 2023-03-06T08:32:26Z

docs/website/blog/2023-02-15-odo-v3.7.0.md

@@ -28,8 +28,6 @@ Similarly to how `odo dev` requires specifying the target platform (using the `-
 ODO_EXPERIMENTAL_MODE=t odo logs --platform podman
 ```

-As a reminder, Podman support in `odo` is still [experimental](../docs/user-guides/advanced/experimental-mode) and requires you to [opt in](../docs/user-guides/advanced/experimental-mode#enabling-the-experimental-mode) if you want to try it out.


I would keep this as is since at the time of v3.7.0 podman was still in experimental mode.

I'm reverting it, and only removing links

valaparthvi · 2023-03-06T08:52:19Z

docs/website/docs/command-reference/describe-component.md

@@ -2,7 +2,7 @@
 title: odo describe component
 ---

-`odo describe component` command is useful for getting information about a component managed by `odo`. 
+`odo describe component` command is useful for getting information about a component. 


This is still true, no?

No, it isn't anymore since #6615

valaparthvi · 2023-03-06T08:55:08Z

docs/website/docs/overview/configure.md

@@ -190,7 +190,6 @@ Options here are mostly used for debugging and testing `odo` behavior.
 | `DEVFILE_PROXY`            | Integration tests will use this address as Devfile registry instead of `registry.stage.devfile.io`                                                                                                                                                                                                                                                                             | v3.0.0-beta3  | `my-registry.example.com`       |
 | `TELEMETRY_CALLER`         | Caller identifier passed to [telemetry](https://github.com/redhat-developer/odo/blob/main/USAGE_DATA.md). Case-insensitive. Acceptable values: `vscode`, `intellij`, `jboss`.                                                                                                                                                                                                  | v3.1.0        | `intellij`                      |
 | `ODO_TRACKING_CONSENT`     | Useful for controlling [telemetry](https://github.com/redhat-developer/odo/blob/main/USAGE_DATA.md). Acceptable values: `yes` ([enables telemetry](https://github.com/redhat-developer/odo/blob/main/USAGE_DATA.md) and skips consent prompt), `no` (disables telemetry and consent prompt). Takes precedence over the [`ConsentTelemetry`](#preference-key-table) preference. | v3.2.0        | `yes`                           |
-| `ODO_EXPERIMENTAL_MODE`    | Whether to enable experimental features. See [Experimental Mode](../user-guides/advanced/experimental-mode) for more details. Acceptable values: boolean values<sup>(1)</sup>                                                                                                                                                                                                  | v3.3.0        | `true`                          |


Can you comment this instead of completely removing it?

I notice that this makes the build fail, even when the link is into a comment (https://app.netlify.com/sites/odo-docusaurus-preview/deploys/6405b74c3f18100008d06cfd):

- On source page path = /docs/overview/configure: -> linking to ../user-guides/advanced/experimental-mode (resolved as: /docs/user-guides/advanced/experimental-mode)

I think it might be because you renamed the experimental-mode.md file. I would remove the link like you've done at other places.

The comment is not recognized as expected:

I'm reverting to remove completely the line. The commit is accessible if we want to revert the deletion

valaparthvi · 2023-03-06T08:57:17Z

/hold cancel

valaparthvi · 2023-03-06T08:58:07Z

docs/website/blog/2022-12-13-odo-v3.4.0.md

@@ -50,7 +50,6 @@ Example:
 #### Using `odo` with Podman

 Based on your valuable feedback, we have worked on improving the experience of using `odo` with Podman.
-Note that this is still [experimental](../docs/user-guides/advanced/experimental-mode) and requires you to [opt in](../docs/user-guides/advanced/experimental-mode#enabling-the-experimental-mode) if you want to try it out.


I believe it's fine to keep this as it is (by removing link to the experimental mode doc) since at the time of v3.4.0 Podman was still in the experimental mode.

I'm reverting it, and only removing links

Co-authored-by: Armel Soro <armel@rm3l.org>

valaparthvi · 2023-03-06T10:06:47Z

Broken links:
On source page path = /docs/overview/configure:
3:20:48 PM: -> linking to ../user-guides/advanced/experimental-mode (resolved as: /docs/user-guides/advanced/experimental-mode)

feloy · 2023-03-06T10:07:22Z

Broken links: On source page path = /docs/overview/configure: 3:20:48 PM: -> linking to ../user-guides/advanced/experimental-mode (resolved as: /docs/user-guides/advanced/experimental-mode)

See #6628 (comment)

sonarqubecloud · 2023-03-06T10:28:16Z

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication

feloy · 2023-03-06T13:05:06Z

/override windows-integration-test/Windows-test
Flaky e2e test

openshift-ci · 2023-03-06T13:05:10Z

@feloy: Overrode contexts on behalf of feloy: windows-integration-test/Windows-test

In response to this:

/override windows-integration-test/Windows-test
Flaky e2e test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

* Remove podman from experimental mode * Remove env var for odo dev * Cleanup tests and sources about experimental mode * Hide "Experimental mode" doc page * Cleanup latest commit * doc odo dev --platform podman * Doc other commands * Apply suggestions from code review Co-authored-by: Armel Soro <armel@rm3l.org> * Remove more ODO_EXPERIMENTAL_MODE from latest commits on main * Remove reference to Experimental mode from blog posts --------- Co-authored-by: Armel Soro <armel@rm3l.org>

openshift-ci bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. Required by Prow. kind/feature Categorizes issue as a feature request. For PRs, that means that the PR is the implementation labels Feb 28, 2023

openshift-ci bot requested review from rnapoles-rh and valaparthvi February 28, 2023 14:24

feloy force-pushed the feature-6592/podman-not-experimental branch from aa4164c to 28695f9 Compare February 28, 2023 15:21

feloy force-pushed the feature-6592/podman-not-experimental branch from 28695f9 to 5f12466 Compare February 28, 2023 15:55

feloy closed this Mar 2, 2023

feloy reopened this Mar 2, 2023

feloy force-pushed the feature-6592/podman-not-experimental branch from 2621fdf to 613b2c7 Compare March 2, 2023 14:35

feloy requested review from rm3l and removed request for rnapoles-rh March 3, 2023 12:47

feloy changed the title ~~[wip] Remove podman from experimental mode~~ Remove podman from experimental mode Mar 3, 2023

feloy removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. Required by Prow. label Mar 3, 2023

rm3l requested changes Mar 3, 2023

View reviewed changes

openshift-ci bot assigned rm3l Mar 3, 2023

feloy requested a review from rm3l March 6, 2023 07:10

feloy force-pushed the feature-6592/podman-not-experimental branch from d3c0d8a to b8e1946 Compare March 6, 2023 08:19

feloy added 3 commits March 6, 2023 09:21

Remove podman from experimental mode

f9e130a

Remove env var for odo dev

35038de

Cleanup tests and sources about experimental mode

8c9f79e

openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Mar 6, 2023

valaparthvi suggested changes Mar 6, 2023

View reviewed changes

openshift-ci bot assigned valaparthvi Mar 6, 2023

openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. Required by Prow. label Mar 6, 2023

valaparthvi reviewed Mar 6, 2023

View reviewed changes

feloy force-pushed the feature-6592/podman-not-experimental branch from b8e1946 to 90342a4 Compare March 6, 2023 09:38

feloy and others added 3 commits March 6, 2023 10:40

Apply suggestions from code review

5fc1a6d

Co-authored-by: Armel Soro <armel@rm3l.org>

Remove more ODO_EXPERIMENTAL_MODE from latest commits on main

b04be14

Remove reference to Experimental mode from blog posts

b1ebb98

feloy force-pushed the feature-6592/podman-not-experimental branch from 90342a4 to 536bedc Compare March 6, 2023 09:50

feloy requested review from valaparthvi and rm3l March 6, 2023 09:50

valaparthvi approved these changes Mar 6, 2023

View reviewed changes

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Mar 6, 2023

feloy force-pushed the feature-6592/podman-not-experimental branch from 536bedc to 6fe424a Compare March 6, 2023 10:14

openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Mar 6, 2023

feloy force-pushed the feature-6592/podman-not-experimental branch from 6fe424a to b1ebb98 Compare March 6, 2023 10:26

feloy requested a review from valaparthvi March 6, 2023 11:58

rm3l approved these changes Mar 6, 2023

View reviewed changes

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Mar 6, 2023

openshift-merge-robot merged commit 26c90d7 into redhat-developer:main Mar 6, 2023

rm3l added this to the v3.8.0 🚀 milestone Mar 6, 2023

rm3l added the area/odo-on-podman Issues or PRs related to running odo against Podman label Mar 7, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Remove podman from experimental mode #6628

Remove podman from experimental mode #6628

feloy commented Feb 28, 2023

netlify bot commented Feb 28, 2023 •

edited

Loading

odo-robot bot commented Feb 28, 2023 •

edited

Loading

odo-robot bot commented Feb 28, 2023 •

edited

Loading

odo-robot bot commented Feb 28, 2023 •

edited

Loading

odo-robot bot commented Feb 28, 2023 •

edited

Loading

odo-robot bot commented Feb 28, 2023 •

edited

Loading

odo-robot bot commented Feb 28, 2023 •

edited

Loading

odo-robot bot commented Feb 28, 2023 •

edited

Loading

odo-robot bot commented Feb 28, 2023 •

edited

Loading

feloy commented Mar 3, 2023

valaparthvi Mar 6, 2023

feloy Mar 6, 2023

valaparthvi Mar 6, 2023

feloy Mar 6, 2023

valaparthvi Mar 6, 2023

feloy Mar 6, 2023

valaparthvi Mar 6, 2023

feloy Mar 6, 2023

feloy Mar 6, 2023

valaparthvi Mar 6, 2023

feloy Mar 6, 2023

feloy Mar 6, 2023

valaparthvi commented Mar 6, 2023

valaparthvi Mar 6, 2023

feloy Mar 6, 2023

valaparthvi commented Mar 6, 2023

feloy commented Mar 6, 2023

sonarqubecloud bot commented Mar 6, 2023

feloy commented Mar 6, 2023

openshift-ci bot commented Mar 6, 2023

		@@ -146,9 +146,8 @@ If you skipped Step 0 and selected "starter project", your output will be slight
		### Step 2. Enabling the experimental mode

Remove podman from experimental mode #6628

Remove podman from experimental mode #6628

Conversation

feloy commented Feb 28, 2023

netlify bot commented Feb 28, 2023 • edited Loading

✅ Deploy Preview for odo-docusaurus-preview ready!

odo-robot bot commented Feb 28, 2023 • edited Loading

odo-robot bot commented Feb 28, 2023 • edited Loading

odo-robot bot commented Feb 28, 2023 • edited Loading

odo-robot bot commented Feb 28, 2023 • edited Loading

odo-robot bot commented Feb 28, 2023 • edited Loading

odo-robot bot commented Feb 28, 2023 • edited Loading

odo-robot bot commented Feb 28, 2023 • edited Loading

odo-robot bot commented Feb 28, 2023 • edited Loading

feloy commented Mar 3, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

valaparthvi commented Mar 6, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

valaparthvi commented Mar 6, 2023

feloy commented Mar 6, 2023

sonarqubecloud bot commented Mar 6, 2023

feloy commented Mar 6, 2023

openshift-ci bot commented Mar 6, 2023

netlify bot commented Feb 28, 2023 •

edited

Loading

odo-robot bot commented Feb 28, 2023 •

edited

Loading

odo-robot bot commented Feb 28, 2023 •

edited

Loading

odo-robot bot commented Feb 28, 2023 •

edited

Loading

odo-robot bot commented Feb 28, 2023 •

edited

Loading

odo-robot bot commented Feb 28, 2023 •

edited

Loading

odo-robot bot commented Feb 28, 2023 •

edited

Loading

odo-robot bot commented Feb 28, 2023 •

edited

Loading

odo-robot bot commented Feb 28, 2023 •

edited

Loading