Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support autoBuild and deployByDefault on Image and Kubernetes/OpenShift components #6654

Merged
merged 23 commits into from
Apr 5, 2023
Merged

Support autoBuild and deployByDefault on Image and Kubernetes/OpenShift components #6654

merged 23 commits into from
Apr 5, 2023

Commits on Apr 4, 2023

  1. Add sample Devfile with multiple autoBuild/deployByDefault combinations 

    It will be used for integration tests.
    @rm3l
    rm3l committed Apr 4, 2023
    Configuration menu
    Copy the full SHA
    dddb2dc View commit details
    Browse the repository at this point in the history

  2. Add helper function to update a given Devfile Command Group 

    This will allow supporting cases where we need to run a custom command,
but this is not implemented yet on odo (cases with 'odo dev --debug'
and 'odo deploy').
In this case, this helper will allow updating the Devfile for example to
unmark the current default command as non-default, and mark the custom
one as default.
    @rm3l
    rm3l committed Apr 4, 2023
    Configuration menu
    Copy the full SHA
    d3a9420 View commit details
    Browse the repository at this point in the history

  3. Add test cases for 'odo dev'

    @rm3l
    rm3l committed Apr 4, 2023
    Configuration menu
    Copy the full SHA
    35a6e50 View commit details
    Browse the repository at this point in the history

  4. Add test cases for 'odo deploy'

    @rm3l
    rm3l committed Apr 4, 2023
    Configuration menu
    Copy the full SHA
    125ff54 View commit details
    Browse the repository at this point in the history

  5. Add test cases for 'odo build-images' 

    'odo build-images' should build all images regardless of the 'autoBuild' property.
    @rm3l
    rm3l committed Apr 4, 2023
    Configuration menu
    Copy the full SHA
    510c5db View commit details
    Browse the repository at this point in the history

  6. Display the spinner when creating or updating Kubernetes resources 

    This helps understand what resources are being patched.
    @rm3l
    rm3l committed Apr 4, 2023
    Configuration menu
    Copy the full SHA
    344879a View commit details
    Browse the repository at this point in the history

  7. Handle deployByDefault on K8s and OpenShift components

    @rm3l
    rm3l committed Apr 4, 2023
    Configuration menu
    Copy the full SHA
    cbbd52a View commit details
    Browse the repository at this point in the history

  8. Add 'devfile.GetImageComponentsToPush' functions that returns the lis… 

    …t of image components to auto-create

See devfile/api#852 (comment) for more context.
    @rm3l
    rm3l committed Apr 4, 2023
    Configuration menu
    Copy the full SHA
    399b42c View commit details
    Browse the repository at this point in the history

  9. Handle automatic image component creation for 'odo dev' on Kubernetes

    @rm3l
    rm3l committed Apr 4, 2023
    Configuration menu
    Copy the full SHA
    669b6a8 View commit details
    Browse the repository at this point in the history

  10. Handle automatic image component creation for 'odo dev' on Podman

    @rm3l
    rm3l committed Apr 4, 2023
    Configuration menu
    Copy the full SHA
    b14213a View commit details
    Browse the repository at this point in the history

  11. Handle automatic image and K8s/OpenShift component creation for 'odo … 

    …deploy'
    @rm3l
    rm3l committed Apr 4, 2023
    Configuration menu
    Copy the full SHA
    3058f5a View commit details
    Browse the repository at this point in the history

  12. Bump Devfile library to the latest commit at this time (c1b23d2) 

    This includes the fix for [1], which provides a way not to set default values automatically

[1] devfile/api#1067
    @rm3l
    rm3l committed Apr 4, 2023
    Configuration menu
    Copy the full SHA
    035e826 View commit details
    Browse the repository at this point in the history

  13. Do not set default values when parsing a Devfile 

    See [1] for the rationale

[1] https://github.com/redhat-developer/odo/issues/5694\#issuecomment-1465778398
    @rm3l
    rm3l committed Apr 4, 2023
    Configuration menu
    Copy the full SHA
    0760872 View commit details
    Browse the repository at this point in the history

  14. Add documentation in the Devfile reference page

    @rm3l
    rm3l committed Apr 4, 2023
    Configuration menu
    Copy the full SHA
    228c704 View commit details
    Browse the repository at this point in the history

  15. Revert "Display the spinner when creating or updating Kubernetes reso… 

    …urces"

This reverts commit 6ad073e63cb0e685f165eed767619a90997393a3.
    @rm3l
    rm3l committed Apr 4, 2023
    Configuration menu
    Copy the full SHA
    5ef6655 View commit details
    Browse the repository at this point in the history

  16. Avoid re-applying Image components multiple times 

    'adapter#Push' might get called several times when there are
state transitions (either on the Deployment in the cluster,
or from 'odo').
It might be confusing to apply Image components over and over again
(and also it can be slower if we need to push images to remote registries).
    @rm3l
    rm3l committed Apr 4, 2023
    Configuration menu
    Copy the full SHA
    d027561 View commit details
    Browse the repository at this point in the history

  17. Move GetK8sAndOcComponentsToPush and GetImageComponentsToPush to libd… 

    …evfile package

As suggested in review, this should be the responsibility of the devfile library

Co-authored-by: Philippe Martin <phmartin@redhat.com>
    @rm3l @feloy
    rm3l and feloy committed Apr 4, 2023
    Configuration menu
    Copy the full SHA
    2ad44e8 View commit details
    Browse the repository at this point in the history

  18. fixup! Handle automatic image and K8s/OpenShift component creation fo… 

    …r 'odo deploy'
    @rm3l
    rm3l committed Apr 4, 2023
    Configuration menu
    Copy the full SHA
    bba3c88 View commit details
    Browse the repository at this point in the history

  19. fixup! Handle automatic image component creation for 'odo dev' on Podman

    @rm3l
    rm3l committed Apr 4, 2023
    Configuration menu
    Copy the full SHA
    f6887b5 View commit details
    Browse the repository at this point in the history

  20. fixup! Avoid re-applying Image components multiple times

    @rm3l
    rm3l committed Apr 4, 2023
    Configuration menu
    Copy the full SHA
    71e0ba2 View commit details
    Browse the repository at this point in the history

  21. Apply suggestions from code review 

    Co-authored-by: Parthvi Vala <pvala@redhat.com>
    @rm3l @valaparthvi
    rm3l and valaparthvi authored Apr 4, 2023
    Configuration menu
    Copy the full SHA
    7a1f1a0 View commit details
    Browse the repository at this point in the history

  22. fixup! Do not set default values when parsing a Devfile

    @rm3l
    rm3l committed Apr 4, 2023
    Configuration menu
    Copy the full SHA
    3673d01 View commit details
    Browse the repository at this point in the history

  23. Fix devfile-deploy-functional-pods.yaml (used in 'odo logs' tests) 

    Set deployByDefault to false on innerloop-pod component.
Otherwise, since it is not referenced by any apply command,
it will be automatically created by *both* 'odo dev' and 'odo deploy'.
    @rm3l
    rm3l committed Apr 4, 2023
    Configuration menu
    Copy the full SHA
    dc0fe61 View commit details
    Browse the repository at this point in the history