Pod Security Admission support for odo deploy

[feloy]

What type of PR is this:

/kind feature

What does this PR do / why we need it:

Which issue(s) this PR fixes:

Fixes #6339

PR acceptance criteria:

• Unit test

• Integration test

• Documentation

How to test changes / Special notes to the reviewer:

[netlify]

✅ Deploy Preview for odo-docusaurus-preview canceled.

Name	Link
🔨 Latest commit	78d1a19
🔍 Latest deploy log	https://app.netlify.com/sites/odo-docusaurus-preview/deploys/6422c805d49c6a000828c3c0

[odo-robot]

NoCluster Tests on commit 8841d99 finished successfully.
View logs: TXT HTML

[odo-robot]

Unit Tests on commit 8841d99 finished successfully.
View logs: TXT HTML

[odo-robot]

Validate Tests on commit 8841d99 finished successfully.
View logs: TXT HTML

[odo-robot]

Kubernetes Tests on commit 8841d99 finished successfully.
View logs: TXT HTML

[odo-robot]

Windows Tests (OCP) on commit 8841d99 finished with errors.
View logs: TXT HTML

[odo-robot]

OpenShift Tests on commit 8841d99 finished successfully.
View logs: TXT HTML

[odo-robot]

OpenShift Unauthenticated Tests on commit 8841d99 finished successfully.
View logs: TXT HTML

[odo-robot]

Kubernetes Docs Tests on commit d0edfb6 finished successfully.
View logs: TXT HTML

[valaparthvi]

The changes lgtm and it seems to be working fine, but what I am curious about is, why does it still show warning.

➜  go-deploy odo deploy
  __
 /  \__     Running the application in Deploy mode using nodejs-prj1-api-abhz Devfile
 \__/  \    Namespace: myns
 /  \__/    odo version: v3.8.0
 \__/

↪ Executing command:
 ◐  Executing command in container (command: deploy...W0327 16:33:12.911351   69916 warnings.go:70] would violate PodSecurity "restricted:latest": seccompProfile (pod or container "runtime" must set securityContext.seccompProfile.type to "RuntimeDefault" or "Localhost")
 ✓  Executing command in container (command: deploy-exec) [7s]

↪ Executing command:
 ◐  Executing command in container (command: deploy-exec-2)W0327 16:36:37.410775   70704 warnings.go:70] would violate PodSecurity "restricted:latest": seccompProfile (pod or container "runtime" must set securityContext.seccompProfile.type to "RuntimeDefault" or "Localhost")
 ✓  Executing command in container (command: deploy-exec-2) [7s]

Your Devfile has been successfully deployed

[feloy]

The changes lgtm and it seems to be working fine, but what I am curious about is, why does it still show warning.

@valaparthvi If you have only the "Warn" label on the namespace, the pod won't be modified (it will be modified only if the "enforce" label is set).

[sonarqubecloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication

[rm3l]

Thanks for the changes!

[feloy]

/override windows-integration-test/Windows-test

Non related failing test due to network error:

+ [FAILED] [21.675 seconds]
odo dev command tests [BeforeEach] when Devfile contains metadata.projectType invalid as a label value when odo deploy is executed should set the correct value in labels of deployed resources
  [BeforeEach] C:/Users/Administrator.ANSIBLE-TEST-VS/3514/tests/integration/cmd_dev_test.go:39
  [It] C:/Users/Administrator.ANSIBLE-TEST-VS/3514/tests/integration/cmd_dev_test.go:3283

  Timeline >>
  Created dir: C:\Users\Administrator.ANSIBLE-TEST-VS\AppData\Local\Temp\3899180349
  Created dir: C:\Users\Administrator.ANSIBLE-TEST-VS\AppData\Local\Temp\3694594853
  Setting KUBECONFIG=C:\Users\Administrator.ANSIBLE-TEST-VS\AppData\Local\Temp\3694594853\config
  Creating a new project: cmd-dev-test3283eho
  Running oc.exe with args [oc new-project cmd-dev-test3283eho] and odo env: []
  [oc] Unable to connect to the server: dial tcp 161.156.12.82:31700: connectex: A connection attempt failed because the connected party did not properly respond after a period of time, or established connection failed because connected host has failed to respond.

[openshift-ci]

@feloy: Overrode contexts on behalf of feloy: windows-integration-test/Windows-test

In response to this:

/override windows-integration-test/Windows-test

Non related failing test due to network error:

+ [FAILED] [21.675 seconds]
odo dev command tests [BeforeEach] when Devfile contains metadata.projectType invalid as a label value when odo deploy is executed should set the correct value in labels of deployed resources
 [BeforeEach] C:/Users/Administrator.ANSIBLE-TEST-VS/3514/tests/integration/cmd_dev_test.go:39
 [It] C:/Users/Administrator.ANSIBLE-TEST-VS/3514/tests/integration/cmd_dev_test.go:3283

 Timeline >>
 Created dir: C:\Users\Administrator.ANSIBLE-TEST-VS\AppData\Local\Temp\3899180349
 Created dir: C:\Users\Administrator.ANSIBLE-TEST-VS\AppData\Local\Temp\3694594853
 Setting KUBECONFIG=C:\Users\Administrator.ANSIBLE-TEST-VS\AppData\Local\Temp\3694594853\config
 Creating a new project: cmd-dev-test3283eho
 Running oc.exe with args [oc new-project cmd-dev-test3283eho] and odo env: []
 [oc] Unable to connect to the server: dial tcp 161.156.12.82:31700: connectex: A connection attempt failed because the connected party did not properly respond after a period of time, or established connection failed because connected host has failed to respond.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.