Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: odo init does not ask for starter project if the Devfile stack contains extra files #6684

Conversation

valaparthvi
Copy link
Contributor

What type of PR is this:
/kind bug

What does this PR do / why we need it:

Which issue(s) this PR fixes:

Fixes #6638

PR acceptance criteria:

  • Unit test

  • Integration test

  • Documentation

How to test changes / Special notes to the reviewer:

  1. odo init in interactive mode from an empty dir and select latest Go/Java Springboot/Python devfile that has extra stack files. Ensure that you are asked to select a starter project.

…ontains extra files

Signed-off-by: Parthvi Vala <pvala@redhat.com>
@netlify
Copy link

netlify bot commented Mar 24, 2023

Deploy Preview for odo-docusaurus-preview ready!

Name Link
🔨 Latest commit e92c45b
🔍 Latest deploy log https://app.netlify.com/sites/odo-docusaurus-preview/deploys/641e0abefeee8100084083c4
😎 Deploy Preview https://deploy-preview-6684--odo-docusaurus-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@openshift-ci openshift-ci bot added the kind/bug Categorizes issue or PR as related to a bug. label Mar 24, 2023
@openshift-ci openshift-ci bot requested review from anandrkskd and feloy March 24, 2023 20:40
@valaparthvi valaparthvi reopened this Mar 26, 2023
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.3% 0.3% Duplication

@odo-robot
Copy link

odo-robot bot commented Mar 26, 2023

OpenShift Unauthenticated Tests on commit c8226af finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Mar 26, 2023

NoCluster Tests on commit c8226af finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Mar 26, 2023

Unit Tests on commit c8226af finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Mar 26, 2023

Validate Tests on commit c8226af finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Mar 26, 2023

Kubernetes Tests on commit c8226af finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Mar 26, 2023

Windows Tests (OCP) on commit c8226af finished with errors.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Mar 26, 2023

OpenShift Tests on commit c8226af finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Mar 26, 2023

Kubernetes Docs Tests on commit 6af2f9d finished successfully.
View logs: TXT HTML

@valaparthvi
Copy link
Contributor Author

/override windows-integration-test/Windows-test

  [FAIL] odo describe/list binding command tests when creating a component with a spec binding and envvars (service in namespace "") when Starting a Pg service when running dev session [It] should list the binding

@openshift-ci
Copy link

openshift-ci bot commented Mar 27, 2023

@valaparthvi: Overrode contexts on behalf of valaparthvi: windows-integration-test/Windows-test

In response to this:

/override windows-integration-test/Windows-test

 [FAIL] odo describe/list binding command tests when creating a component with a spec binding and envvars (service in namespace "") when Starting a Pg service when running dev session [It] should list the binding

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Contributor

@feloy feloy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Mar 27, 2023
@openshift-merge-robot openshift-merge-robot merged commit c70aaff into redhat-developer:main Mar 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. Required by Prow.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

odo init does not ask for starter project if the Devfile stack contains extra files
3 participants