odo dev/deploy should display a warning about default namespace on cluster #6688
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for odo-docusaurus-preview canceled.
|
…uster Signed-off-by: Parthvi Vala <pvala@redhat.com>
rm3l
requested changes
Mar 27, 2023
Signed-off-by: Parthvi Vala <pvala@redhat.com>
…er or podman Signed-off-by: Parthvi Vala <pvala@redhat.com> Co-authored-by: Armel Soro <armel@rm3l.org> Signed-off-by: Parthvi Vala <pvala@redhat.com>
rm3l
requested changes
Mar 28, 2023
There was a problem hiding this comment.
In terms of UX, what do you think about adding an empty line between the header and the warning message? Maybe it's just me, but I currently find the warning to be too close to the logo:
$ odo deploy
__
/ \__ Running the application in Deploy mode using warning-default-ns-test Devfile
\__/ \ Namespace: default
/ \__/ odo version: v3.8.0
\__/
⚠ You are using "default" project, odo may not work as expected in the default project.
⚠ You may set a new project by running `odo create project <name>`, or set an existing one by running `odo set project <name>`
↪ Executing command:
[...]
…d of default Signed-off-by: Parthvi Vala <pvala@redhat.com>
|
Kudos, SonarCloud Quality Gate passed!
|
openshift-ci
bot
added
the
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this:
/kind bug
What does this PR do / why we need it:
This PR adds a warning if the user is using a default namespace.
This PR also modifies
helper.IsKubernetesClusterto work ifKUBERNETES=true,t,1,T,true,True,TRUE.Which issue(s) this PR fixes:
Fixes #5591
PR acceptance criteria:
Unit test
Integration test
Documentation
How to test changes / Special notes to the reviewer:
odo set namespace defaultodo init --devfile go --starter go-starter --devfile-version latestodo devshould display the warning right awayPODMAN_CMD=echo odo deployshould display the warning right away.If you are on an OpenShift cluster, it will use
projectinstead ofnamespace.