Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix HotReloadCapable Build command #6696

Merged
merged 6 commits into from
May 4, 2023
Merged

Fix HotReloadCapable Build command #6696

merged 6 commits into from
May 4, 2023

Conversation

feloy
Copy link
Contributor

@feloy feloy commented Mar 28, 2023 •
edited
Loading

What type of PR is this:

/kind bug

What does this PR do / why we need it:

Which issue(s) this PR fixes:

Fixes #6695
Fixes partially #6657

PR acceptance criteria:

  • Unit test

  • Integration test

  • Documentation

How to test changes / Special notes to the reviewer:

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. Required by Prow. label Mar 28, 2023
@netlify
Copy link

netlify bot commented Mar 28, 2023 •
edited
Loading

✅ Deploy Preview for odo-docusaurus-preview ready!

Name Link
🔨 Latest commit 540f4c7
🔍 Latest deploy log https://app.netlify.com/sites/odo-docusaurus-preview/deploys/6453a832f344b30008c96946
😎 Deploy Preview https://deploy-preview-6696--odo-docusaurus-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@openshift-ci openshift-ci bot added the kind/bug Categorizes issue or PR as related to a bug. label Mar 28, 2023
@openshift-ci openshift-ci bot requested review from rm3l and valaparthvi March 28, 2023 16:36
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@odo-robot
Copy link

odo-robot bot commented Mar 28, 2023 •
edited
Loading

OpenShift Unauthenticated Tests on commit a18f5d9 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Mar 28, 2023 •
edited
Loading

NoCluster Tests on commit a18f5d9 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Mar 28, 2023 •
edited
Loading

Unit Tests on commit a18f5d9 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Mar 28, 2023 •
edited
Loading

Validate Tests on commit a18f5d9 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Mar 28, 2023 •
edited
Loading

Windows Tests (OCP) on commit a18f5d9 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Mar 28, 2023 •
edited
Loading

OpenShift Tests on commit a18f5d9 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Mar 28, 2023 •
edited
Loading

Kubernetes Tests on commit a18f5d9 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Mar 28, 2023 •
edited
Loading

Kubernetes Docs Tests on commit 6241a66 finished successfully.
View logs: TXT HTML

@feloy feloy changed the title [WIP] Always run Build command, even if Run command is hotReloadCapable Always run Build command, even if Run command is hotReloadCapable Mar 29, 2023
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. Required by Prow. label Mar 29, 2023
@feloy feloy changed the title Always run Build command, even if Run command is hotReloadCapable [WIP] Always run Build command, even if Run command is hotReloadCapable Mar 29, 2023
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. Required by Prow. label Mar 29, 2023
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. Required by Prow. label Apr 25, 2023
@feloy feloy force-pushed the bugfix-run-hotreload-build branch from 99b9c92 to b5ac956 Compare May 3, 2023 11:37
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. Required by Prow. label May 3, 2023
@feloy feloy force-pushed the bugfix-run-hotreload-build branch from ae31c46 to 21e8770 Compare May 3, 2023 13:21
@feloy feloy changed the title [WIP] Always run Build command, even if Run command is hotReloadCapable Fix HotReloadCapable Build command May 3, 2023
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. Required by Prow. label May 3, 2023
rm3l
rm3l requested changes May 4, 2023
View reviewed changes
Copy link
Member

@rm3l rm3l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall - just some minor suggestions...

docs/website/docs/command-reference/dev.md Outdated Show resolved Hide resolved
pkg/component/exec_handler.go Show resolved Hide resolved
@feloy feloy requested a review from rm3l May 4, 2023 12:42
@sonarqubecloud
Copy link

sonarqubecloud bot commented May 4, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label May 4, 2023
@openshift-merge-robot openshift-merge-robot merged commit 56d0b6f into redhat-developer:main May 4, 2023
@rm3l rm3l added this to the v3.11.0 🚀 milestone May 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rm3l rm3l rm3l approved these changes

@valaparthvi valaparthvi Awaiting requested review from valaparthvi

Assignees

@rm3l rm3l

Labels
kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. Required by Prow.
Projects
None yet
Milestone
v3.11.0 🚀
Development

Successfully merging this pull request may close these issues.

On cluster, when run is hotReloadCapable, the Build command is not called after source sync
3 participants
@feloy @rm3l @openshift-merge-robot