Allow users to define custom port-mappings for port forwarding [Kubernetes] #6704
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci
bot
added
the
do-not-merge/work-in-progress
✅ Deploy Preview for odo-docusaurus-preview ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
openshift-ci
bot
added
the
kind/feature
valaparthvi
force-pushed
the
6479-custom-port-mapping-for-port-forwarding
branch
from
a33e0dc to
a3d667e
Compare
valaparthvi
changed the title
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
8 tasks
valaparthvi
changed the title
openshift-ci
bot
added
the
do-not-merge/work-in-progress
valaparthvi
changed the title
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
feloy
reviewed
Apr 3, 2023
valaparthvi
changed the title
openshift-ci
bot
added
the
do-not-merge/work-in-progress
valaparthvi
force-pushed
the
6479-custom-port-mapping-for-port-forwarding
branch
from
ffa7662 to
3cf0901
Compare
Merged
3 tasks
valaparthvi
force-pushed
the
6479-custom-port-mapping-for-port-forwarding
branch
2 times, most recently
from
9212408 to
e7868e7
Compare
|
windows-integration-test/Windows-test failure is due to same random port returned twice, although I am not sure why. The seed used should've made sure we get a unique port, but it did not here. Running odo.exe with args [odo dev --debug --port-forward=35507:3000 --port-forward=35507:5858] and odo env: [ODO_LOG_LEVEL=4 ODO_TRACKING_CONSENT=no]
[odo] X There are following issues with values provided by --port-forward flag:
[odo] X values for --port-forward flag are invalid
[FAILED] Timed out after 360.000s.
Expected
<string>: - local port 35507 is used more than once, please use unique local ports
to contain substring
<string>: [Ctrl+c] - Exit |
valaparthvi
force-pushed
the
6479-custom-port-mapping-for-port-forwarding
branch
from
e7868e7 to
4bfe926
Compare
Signed-off-by: Parthvi Vala <pvala@redhat.com>
Signed-off-by: Parthvi Vala <pvala@redhat.com>
Signed-off-by: Parthvi Vala <pvala@redhat.com>
…hen debugging Signed-off-by: Parthvi Vala <pvala@redhat.com>
Signed-off-by: Parthvi Vala <pvala@redhat.com> Remove the use of seed for randomzing Signed-off-by: Parthvi Vala <pvala@redhat.com>
valaparthvi
force-pushed
the
6479-custom-port-mapping-for-port-forwarding
branch
from
7bd97ec to
861a9f4
Compare
feloy
reviewed
Apr 5, 2023
tests/helper/helper_http.go
Outdated
Comment on lines
60
to
62
| if !util.IsPortFree(int(startPort)) { | ||
| return GetRandomFreePort() | ||
| } |
There was a problem hiding this comment.
I'm not sure IsPortFree is atomic here. You could just expect the port is free.
The random ports are in the range of the Ephemeral ports, in my machine it is:
$ sysctl net.ipv4.ip_local_port_range
net.ipv4.ip_local_port_range = 32768 60999
So we can consider ports below 32768 will be free.
Signed-off-by: Parthvi Vala <pvala@redhat.com>
valaparthvi
force-pushed
the
6479-custom-port-mapping-for-port-forwarding
branch
from
861a9f4 to
69c994a
Compare
|
/lgtm |
openshift-ci
bot
added
the
lgtm
rm3l
reviewed
Apr 5, 2023
Co-authored-by: Armel Soro <asoro@redhat.com>
openshift-ci
bot
removed
the
lgtm
[FAILED] in [AfterEach] - /go/odo_1/tests/helper/helper_dev.go:211 @ 04/06/23 11:22:15.369
Deleting project: cmd-dev-test1485ipw
Running oc with args [oc delete project cmd-dev-test1485ipw --wait=false] and odo env: []
[oc] project.project.openshift.io "cmd-dev-test1485ipw" deleted
Setting current dir to: /go/odo_1/tests/integration
Deleting dir: /tmp/2482955252
Deleting dir: /tmp/1006440071
<< Timeline
[FAILED] Timed out after 180.001s.
Expected process to exit. It did not.
In [AfterEach] at: /go/odo_1/tests/helper/helper_dev.go:211 @ 04/06/23 11:22:15.369
[FAIL] odo dev command tests when Starting a PostgreSQL service when creating local files and dir and running odo dev - with metadata.name [AfterEach] should correctly propagate changes to the containerOpenShift Test failure. |
rm3l
approved these changes
Apr 6, 2023
openshift-ci
bot
added
the
lgtm
|
Kudos, SonarCloud Quality Gate passed!
|
|
/override Kubernetes-Integration-Tests/Kubernetes-Integration-Tests Flaky e2e tests |
|
@feloy: Overrode contexts on behalf of feloy: Kubernetes-Integration-Tests/Kubernetes-Integration-Tests, OpenShift-Integration-tests/OpenShift-Integration-tests In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this:
/kind feature
What does this PR do / why we need it:
Which issue(s) this PR fixes:
Fixes part of #6479
PR acceptance criteria:
Unit test
Integration test [WIP]
Documentation [TBD]
How to test changes / Special notes to the reviewer:
odo dev --port-forward <localPort>:<containerPort> --port-forward <localPort>:<containerName>:<containerPort>