Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release PR for v3.9.0 #6718

Merged
merged 4 commits into from
Apr 11, 2023
Merged

Release PR for v3.9.0 #6718

merged 4 commits into from
Apr 11, 2023

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Apr 5, 2023 •
edited by rm3l
Loading

/area documentation
/area release-eng
/hold

PR for new release: v3.9.0

Announcement blog post: https://deploy-preview-6718--odo-docusaurus-preview.netlify.app/blog/odo-v3.9.0

This fixes #6643.

NOTE: Remove the hold and consider merging this PR only when binaries for this release are publicly available on developers.redhat.com.

@github-actions github-actions bot requested a review from rm3l April 5, 2023 09:15
@openshift-ci openshift-ci bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. Required by Prow. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. Required by Prow. area/documentation Issues or PRs related to documentation or the 'odo.dev' website area/release-eng Issues or PRs related to the Release Engineering needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. Required by Prow. labels Apr 5, 2023
@openshift-ci
Copy link

openshift-ci bot commented Apr 5, 2023

Hi @github-actions[bot]. Thanks for your PR.

I'm waiting for a redhat-developer member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@netlify
Copy link

netlify bot commented Apr 5, 2023 •
edited
Loading

✅ Deploy Preview for odo-docusaurus-preview ready!

Name Link
🔨 Latest commit 97a626b
🔍 Latest deploy log https://app.netlify.com/sites/odo-docusaurus-preview/deploys/642ec8cf2c9d040008c65021
😎 Deploy Preview https://deploy-preview-6718--odo-docusaurus-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@odo-robot
Copy link

odo-robot bot commented Apr 5, 2023 •
edited
Loading

NoCluster Tests on commit c8420ab finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Apr 5, 2023 •
edited
Loading

Unit Tests on commit c8420ab finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Apr 5, 2023 •
edited
Loading

Validate Tests on commit c8420ab finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Apr 5, 2023 •
edited
Loading

OpenShift Tests on commit c8420ab finished with errors.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Apr 5, 2023 •
edited
Loading

Kubernetes Tests on commit c8420ab finished successfully.
View logs: TXT HTML

@rm3l rm3l force-pushed the release_pr_v3.9.0 branch from 70ee54b to 97a626b Compare April 6, 2023 13:27
@odo-robot
Copy link

odo-robot bot commented Apr 6, 2023 •
edited
Loading

Windows Tests (OCP) on commit c8420ab finished with errors.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Apr 6, 2023 •
edited
Loading

Kubernetes Docs Tests on commit c941fbd finished successfully.
View logs: TXT HTML

@rm3l
Copy link
Member

rm3l commented Apr 7, 2023

/ok-to-test

@openshift-ci openshift-ci bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. Required by Prow. labels Apr 7, 2023
@rm3l rm3l changed the title [WIP] Release PR for v3.9.0 Release PR for v3.9.0 Apr 11, 2023
@rm3l rm3l marked this pull request as ready for review April 11, 2023 11:28
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. Required by Prow. label Apr 11, 2023
@openshift-ci openshift-ci bot requested a review from valaparthvi April 11, 2023 11:28
@rm3l rm3l requested review from kadel and feloy April 11, 2023 11:28
@rm3l
Copy link
Member

rm3l commented Apr 11, 2023

/hold cancel

Ready for review, now that the binaries are available on https://developers.redhat.com/content-gateway/rest/mirror/pub/openshift-v4/clients/odo/v3.9.0

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. Required by Prow. label Apr 11, 2023
@rm3l rm3l removed their request for review April 11, 2023 11:29
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Apr 11, 2023
@rm3l
Copy link
Member

rm3l commented Apr 11, 2023 


  [FAILED] Expected
      <*url.Error | 0xc00064a720>: {
          Op: "Post",
          URL: "http://127.0.0.1:62164/api/newuser",
          Err: <*errors.errorString | 0xc00008a130>{s: "EOF"},
      }
  to be nil
  In [It] at: C:/Users/Administrator.ANSIBLE-TEST-VS/3645/tests/e2escenarios/e2e_test.go:306 @ 04/06/23 10:06:56.44

  There were additional failures detected.  To view them in detail run ginkgo -vv
------------------------------

Summarizing 1 Failure:
  [FAIL] E2E Test starting with non-empty Directory add Binding [It] should verify developer workflow of using binding as env in innerloop
  C:/Users/Administrator.ANSIBLE-TEST-VS/3645/tests/e2escenarios/e2e_test.go:306

Flaky E2E test (#6582)

/override OpenShift-Integration-tests/OpenShift-Integration-tests

@openshift-ci
Copy link

openshift-ci bot commented Apr 11, 2023

@rm3l: Overrode contexts on behalf of rm3l: OpenShift-Integration-tests/OpenShift-Integration-tests

In response to this:


 [FAILED] Expected
     <*url.Error | 0xc00064a720>: {
         Op: "Post",
         URL: "http://127.0.0.1:62164/api/newuser",
         Err: <*errors.errorString | 0xc00008a130>{s: "EOF"},
     }
 to be nil
 In [It] at: C:/Users/Administrator.ANSIBLE-TEST-VS/3645/tests/e2escenarios/e2e_test.go:306 @ 04/06/23 10:06:56.44

 There were additional failures detected.  To view them in detail run ginkgo -vv
------------------------------

Summarizing 1 Failure:
 [FAIL] E2E Test starting with non-empty Directory add Binding [It] should verify developer workflow of using binding as env in innerloop
 C:/Users/Administrator.ANSIBLE-TEST-VS/3645/tests/e2escenarios/e2e_test.go:306

Flaky E2E test (#6582)

/override OpenShift-Integration-tests/OpenShift-Integration-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@rm3l rm3l closed this Apr 11, 2023
@rm3l rm3l reopened this Apr 11, 2023
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@odo-robot
Copy link

odo-robot bot commented Apr 11, 2023

OpenShift Unauthenticated Tests on commit c8420ab finished successfully.
View logs: TXT HTML

@rm3l
Copy link
Member

rm3l commented Apr 11, 2023 

  [oc] Unable to connect to the server: dial tcp 158.177.79.34:31700: connectex: A connection attempt failed because the connected party did not properly respond after a period of time, or established connection failed because connected host has failed to respond.
[...]
Summarizing 1 Failure:
  [FAIL] odo delete command tests [AfterEach] when a component is bootstrapped using a devfile.yaml with URI-referenced Kubernetes components when the component is deployed in DEPLOY mode when a resource is changed in the devfile and the component is deleted while having access to the devfile.yaml with --files=true --running-in=dev should delete the component
  C:/Users/Administrator.ANSIBLE-TEST-VS/3665/tests/helper/helper_cmd_wrapper.go:101

Ran 432 of 800 Specs in 1115.174 seconds
FAIL! -- 431 Passed | 1 Failed | 0 Pending | 368 Skipped

Unrelated.

/override windows-integration-test/Windows-test

@openshift-ci
Copy link

openshift-ci bot commented Apr 11, 2023

@rm3l: Overrode contexts on behalf of rm3l: windows-integration-test/Windows-test

In response to this:

 [oc] Unable to connect to the server: dial tcp 158.177.79.34:31700: connectex: A connection attempt failed because the connected party did not properly respond after a period of time, or established connection failed because connected host has failed to respond.
[...]
Summarizing 1 Failure:
 [FAIL] odo delete command tests [AfterEach] when a component is bootstrapped using a devfile.yaml with URI-referenced Kubernetes components when the component is deployed in DEPLOY mode when a resource is changed in the devfile and the component is deleted while having access to the devfile.yaml with --files=true --running-in=dev should delete the component
 C:/Users/Administrator.ANSIBLE-TEST-VS/3665/tests/helper/helper_cmd_wrapper.go:101

Ran 432 of 800 Specs in 1115.174 seconds
FAIL! -- 431 Passed | 1 Failed | 0 Pending | 368 Skipped

Unrelated.

/override windows-integration-test/Windows-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@rm3l
Copy link
Member

rm3l commented Apr 11, 2023 


Summarizing 2 Failures:
  [FAIL] odo delete command tests when deleting a component containing preStop event that is deployed with DEV and --files=true [BeforeEach] should delete the component
  /go/odo_1/tests/helper/helper_run.go:54
  [FAIL] odo describe/list binding command tests when creating a component with a binding as environment variables (service in namespace "binding-sha") when Starting a Pg service when running dev session [BeforeEach] should list the binding
  /go/odo_1/tests/helper/helper_run.go:54

Ran 439 of 800 Specs in 1695.992 seconds
FAIL! -- 437 Passed | 2 Failed | 0 Pending | 361 Skipped

Previous run passed.

/override OpenShift-Integration-tests/OpenShift-Integration-tests

@openshift-ci
Copy link

openshift-ci bot commented Apr 11, 2023

@rm3l: Overrode contexts on behalf of rm3l: OpenShift-Integration-tests/OpenShift-Integration-tests

In response to this:


Summarizing 2 Failures:
 [FAIL] odo delete command tests when deleting a component containing preStop event that is deployed with DEV and --files=true [BeforeEach] should delete the component
 /go/odo_1/tests/helper/helper_run.go:54
 [FAIL] odo describe/list binding command tests when creating a component with a binding as environment variables (service in namespace "binding-sha") when Starting a Pg service when running dev session [BeforeEach] should list the binding
 /go/odo_1/tests/helper/helper_run.go:54

Ran 439 of 800 Specs in 1695.992 seconds
FAIL! -- 437 Passed | 2 Failed | 0 Pending | 361 Skipped

Previous run passed.

/override OpenShift-Integration-tests/OpenShift-Integration-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot openshift-merge-robot merged commit fa9524e into main Apr 11, 2023
@rm3l rm3l deleted the release_pr_v3.9.0 branch May 4, 2023 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@valaparthvi valaparthvi valaparthvi approved these changes

@kadel kadel Awaiting requested review from kadel

@feloy feloy Awaiting requested review from feloy

Assignees

@valaparthvi valaparthvi

Labels
area/documentation Issues or PRs related to documentation or the 'odo.dev' website area/release-eng Issues or PRs related to the Release Engineering lgtm Indicates that a PR is ready to be merged. Required by Prow. ok-to-test Indicates a non-member PR verified by an org member that is safe to test.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

🎉 Release for Sprints 233 through 234 (v3.9.0) 🎉
3 participants
@rm3l @valaparthvi @openshift-merge-robot