Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: PodSecurity Admission: Display duplicate warnings only once #6733

Merged

Conversation

valaparthvi
Copy link
Contributor

What type of PR is this:
/kind bug

What does this PR do / why we need it:

Which issue(s) this PR fixes:

Fixes #6699

PR acceptance criteria:

  • Unit test

  • Integration test

  • Documentation

How to test changes / Special notes to the reviewer:

  1. Run odo dev and ensure that the warning is printed only once.
  2. Run odo dev or odo deploy with Devfile containing multiple containers and ensure that a warning is printed only once per container.

@netlify
Copy link

netlify bot commented Apr 13, 2023

Deploy Preview for odo-docusaurus-preview canceled.

Name Link
🔨 Latest commit c66b03f
🔍 Latest deploy log https://app.netlify.com/sites/odo-docusaurus-preview/deploys/6437f891f8dfdd00083c396d

@openshift-ci openshift-ci bot added the kind/bug Categorizes issue or PR as related to a bug. label Apr 13, 2023
@openshift-ci openshift-ci bot requested review from anandrkskd and feloy April 13, 2023 06:55
@odo-robot
Copy link

odo-robot bot commented Apr 13, 2023

NoCluster Tests on commit da41036 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Apr 13, 2023

OpenShift Unauthenticated Tests on commit da41036 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Apr 13, 2023

Unit Tests on commit da41036 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Apr 13, 2023

Validate Tests on commit da41036 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Apr 13, 2023

Windows Tests (OCP) on commit da41036 finished with errors.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Apr 13, 2023

Kubernetes Tests on commit da41036 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Apr 13, 2023

OpenShift Tests on commit da41036 finished with errors.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Apr 13, 2023

Kubernetes Docs Tests on commit 72ea3cd finished successfully.
View logs: TXT HTML

Signed-off-by: Parthvi Vala <pvala@redhat.com>
Copy link
Member

@rm3l rm3l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works fine - thanks!

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Apr 13, 2023
@valaparthvi valaparthvi reopened this Apr 13, 2023
@valaparthvi valaparthvi reopened this Apr 13, 2023
@sonarcloud
Copy link

sonarcloud bot commented Apr 13, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.3% 0.3% Duplication

@valaparthvi
Copy link
Contributor Author

/override OpenShift-Integration-tests/OpenShift-Integration-tests

[FAILED] Timed out after 180.001s.
  Expected process to exit.  It did not.
  In [AfterEach] at: /go/odo_1/tests/helper/helper_dev.go:211 @ 04/13/23 18:08:18.49

Summarizing 1 Failure:
  [FAIL] odo dev command tests when Starting a PostgreSQL service when creating local files and dir and running odo dev - with metadata.name [AfterEach] when deleting local files and dir and waiting for sync should not list deleted dir and file in container
  /go/odo_1/tests/helper/helper_dev.go:211

/override windows-integration-test/Windows-test

  [odo] Error occurred on Push - unable to generate component from watch parameters: failed to populateAndParseDevfile: failed to read devfile from path 'C:\Users\Administrator.ANSIBLE-TEST-VS\AppData\Local\Temp\2299748754\devfile.yaml': open C:\Users\Administrator.ANSIBLE-TEST-VS\AppData\Local\Temp\2299748754\devfile.yaml: The system cannot find the file specified.
  [odo] 
  Deleting dir: C:\Users\Administrator.ANSIBLE-TEST-VS\AppData\Local\Temp\2299748754
  Unable to delete C:\Users\Administrator.ANSIBLE-TEST-VS\AppData\Local\Temp\2299748754 on attempt #11, trying again...
  [FAILED] in [AfterEach] - C:/Users/Administrator.ANSIBLE-TEST-VS/3696/tests/helper/helper_filesystem.go:45 @ 04/13/23 12:56:30.022
  << Timeline

  [FAILED] Expected
      <*url.Error | 0xc000348510>: {
          Op: "Post",
          URL: "http://127.0.0.1:56925/api/newuser",
          Err: <*errors.errorString | 0xc000108100>{s: "EOF"},
      }
  to be nil
  In [It] at: C:/Users/Administrator.ANSIBLE-TEST-VS/3696/tests/e2escenarios/e2e_test.go:319 @ 04/13/23 12:54:23.639

  There were additional failures detected.  To view them in detail run ginkgo -vv
------------------------------

Summarizing 1 Failure:
  [FAIL] E2E Test starting with non-empty Directory add Binding [It] should verify developer workflow of using binding as env in innerloop
  C:/Users/Administrator.ANSIBLE-TEST-VS/3696/tests/e2escenarios/e2e_test.go:319

@openshift-ci
Copy link

openshift-ci bot commented Apr 14, 2023

@valaparthvi: Overrode contexts on behalf of valaparthvi: OpenShift-Integration-tests/OpenShift-Integration-tests, windows-integration-test/Windows-test

In response to this:

/override OpenShift-Integration-tests/OpenShift-Integration-tests

[FAILED] Timed out after 180.001s.
 Expected process to exit.  It did not.
 In [AfterEach] at: /go/odo_1/tests/helper/helper_dev.go:211 @ 04/13/23 18:08:18.49

Summarizing 1 Failure:
 [FAIL] odo dev command tests when Starting a PostgreSQL service when creating local files and dir and running odo dev - with metadata.name [AfterEach] when deleting local files and dir and waiting for sync should not list deleted dir and file in container
 /go/odo_1/tests/helper/helper_dev.go:211

/override windows-integration-test/Windows-test

 [odo] Error occurred on Push - unable to generate component from watch parameters: failed to populateAndParseDevfile: failed to read devfile from path 'C:\Users\Administrator.ANSIBLE-TEST-VS\AppData\Local\Temp\2299748754\devfile.yaml': open C:\Users\Administrator.ANSIBLE-TEST-VS\AppData\Local\Temp\2299748754\devfile.yaml: The system cannot find the file specified.
 [odo] 
 Deleting dir: C:\Users\Administrator.ANSIBLE-TEST-VS\AppData\Local\Temp\2299748754
 Unable to delete C:\Users\Administrator.ANSIBLE-TEST-VS\AppData\Local\Temp\2299748754 on attempt #11, trying again...
 [FAILED] in [AfterEach] - C:/Users/Administrator.ANSIBLE-TEST-VS/3696/tests/helper/helper_filesystem.go:45 @ 04/13/23 12:56:30.022
 << Timeline

 [FAILED] Expected
     <*url.Error | 0xc000348510>: {
         Op: "Post",
         URL: "http://127.0.0.1:56925/api/newuser",
         Err: <*errors.errorString | 0xc000108100>{s: "EOF"},
     }
 to be nil
 In [It] at: C:/Users/Administrator.ANSIBLE-TEST-VS/3696/tests/e2escenarios/e2e_test.go:319 @ 04/13/23 12:54:23.639

 There were additional failures detected.  To view them in detail run ginkgo -vv
------------------------------

Summarizing 1 Failure:
 [FAIL] E2E Test starting with non-empty Directory add Binding [It] should verify developer workflow of using binding as env in innerloop
 C:/Users/Administrator.ANSIBLE-TEST-VS/3696/tests/e2escenarios/e2e_test.go:319

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot openshift-merge-robot merged commit 7f25f0c into redhat-developer:main Apr 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. Required by Prow.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PodSecurity Admission: Display duplicate warnings only once
3 participants