Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to cancel execution of odo dev at any phase (e.g. if build command is taking long) #6736

Conversation

rm3l
Copy link
Member

@rm3l rm3l commented Apr 13, 2023

What type of PR is this:
/kind bug

What does this PR do / why we need it:
This works by passing a context around to relevant functions and methods, to allow handling cancellations properly.

Which issue(s) this PR fixes:
Fixes #6196

PR acceptance criteria:

  • Unit test

  • Integration test

  • Documentation

How to test changes / Special notes to the reviewer:
See #6196

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. Required by Prow. label Apr 13, 2023
@openshift-ci
Copy link

openshift-ci bot commented Apr 13, 2023

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@netlify
Copy link

netlify bot commented Apr 13, 2023

Deploy Preview for odo-docusaurus-preview canceled.

Name Link
🔨 Latest commit 98086b0
🔍 Latest deploy log https://app.netlify.com/sites/odo-docusaurus-preview/deploys/643fab87e0c94a000824555a

@openshift-ci openshift-ci bot added the kind/bug Categorizes issue or PR as related to a bug. label Apr 13, 2023
@odo-robot
Copy link

odo-robot bot commented Apr 13, 2023

NoCluster Tests on commit ed48429 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Apr 13, 2023

OpenShift Unauthenticated Tests on commit ed48429 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Apr 13, 2023

Unit Tests on commit ed48429 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Apr 13, 2023

Validate Tests on commit ed48429 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Apr 13, 2023

Kubernetes Tests on commit ed48429 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Apr 13, 2023

Windows Tests (OCP) on commit ed48429 finished with errors.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Apr 13, 2023

Kubernetes Docs Tests on commit bd5098e finished with errors.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Apr 13, 2023

OpenShift Tests on commit ed48429 finished with errors.
View logs: TXT HTML

@rm3l rm3l force-pushed the 6196-ctrl-c-doesn-t-work-during-odo-dev-build-phase-and-if-build-is-stuck-the-only-way-out-is-killing-the-terminal branch 2 times, most recently from cf385f1 to b5ae793 Compare April 13, 2023 18:31
@rm3l rm3l changed the title [WIP] Allow to cancel execution of odo in any phase (e.g. even if build command is taking long) Allow to cancel execution of odo in any phase (e.g. if build command is taking long) Apr 14, 2023
@rm3l rm3l marked this pull request as ready for review April 14, 2023 05:08
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. Required by Prow. label Apr 14, 2023
@openshift-ci openshift-ci bot requested review from anandrkskd and feloy April 14, 2023 05:08
@rm3l rm3l requested review from valaparthvi and removed request for anandrkskd April 14, 2023 05:09
@rm3l rm3l changed the title Allow to cancel execution of odo in any phase (e.g. if build command is taking long) Allow to cancel execution of odo dev at any phase (e.g. if build command is taking long) Apr 14, 2023
Copy link
Contributor

@valaparthvi valaparthvi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall it lgtm, but I noticed that hitting ctrl+c during the build command, it also prints log and an error message, I am not sure if that is something we can/need to hide.

↪ Running on the cluster in Dev mode
 •  Waiting for Kubernetes resources  ...
 ✓  Added storage m2 to component
 ⚠  Pod is Pending
 ⚠  0/1 nodes are available: 1 pod has unbound immediate PersistentVolumeClaims. preemption: 0/1 nodes are available: 1 Preemption is not helpful for scheduling.
 ✓  Pod is Running
 ✓  Syncing files into the container [118ms]
 ✗  Building your application in container (command: build) [8s]
[INFO] Scanning for projects...
Downloading from central: https://repo1.maven.org/maven2/org/springframework/boot/spring-boot-starter-parent/2.3.5.RELEASE/spring-boot-starter-parent-2.3.5.RELEASE.pom
Downloaded from central: https://repo1.maven.org/maven2/org/springframework/boot/spring-boot-starter-parent/2.3.5.RELEASE/spring-boot-starter-parent-2.3.5.RELEASE.pom (8.6 kB at 4.4 kB/s)
Downloading from central: https://repo1.maven.org/maven2/org/springframework/boot/spring-boot-dependencies/2.3.5.RELEASE/spring-boot-dependencies-2.3.5.RELEASE.pom
Downloaded from central: https://repo1.maven.org/maven2/org/springframework/boot/spring-boot-dependencies/2.3.5.RELEASE/spring-boot-dependencies-2.3.5.RELEASE.pom (121 kB at 124 kB/s)
Downloading from central: https://repo1.maven.org/maven2/com/datastax/oss/java-driver-bom/4.6.1/java-driver-bom-4.6.1.pom
Downloaded from central: https://repo1.maven.org/maven2/com/datastax/oss/java-driver-bom/4.6.1/java-driver-bom-4.6.1.pom (3.8 kB at 5.5 kB/s)
Downloading from central: https://repo1.maven.org/maven2/io/dropwizard/metrics/metrics-bom/4.1.14/metrics-bom-4.1.14.pom
Downloaded from central: https://repo1.maven.org/maven2/io/dropwizard/metrics/metrics-bom/4.1.14/metrics-bom-4.1.14.pom (5.3 kB at 8.9 kB/s)
Downloading from central: https://repo1.maven.org/maven2/io/dropwizard/metrics/metrics-parent/4.1.14/metrics-parent-4.1.14.pom
Downloaded from central: https://repo1.maven.org/maven2/io/dropwizard/metrics/metrics-parent/4.1.14/metrics-parent-4.1.14.pom (16 kB at 28 kB/s)
Downloading from central: https://repo1.maven.org/maven2/org/codehaus/groovy/groovy-bom/2.5.13/groovy-bom-2.5.13.pom
Downloaded from central: https://repo1.maven.org/maven2/org/codehaus/groovy/groovy-bom/2.5.13/groovy-bom-2.5.13.pom (26 kB at 41 kB/s)
Downloading from central: https://repo1.maven.org/maven2/com/fasterxml/jackson/jackson-bom/2.11.3/jackson-bom-2.11.3.pom
Downloaded from central: https://repo1.maven.org/maven2/com/fasterxml/jackson/jackson-bom/2.11.3/jackson-bom-2.11.3.pom (14 kB at 24 kB/s)
Downloading from central: https://repo1.maven.org/maven2/com/fasterxml/jackson/jackson-parent/2.11/jackson-parent-2.11.pom
Downloaded from central: https://repo1.maven.org/maven2/com/fasterxml/jackson/jackson-parent/2.11/jackson-parent-2.11.pom (7.8 kB at 13 kB/s)
Downloading from central: https://repo1.maven.org/maven2/com/fasterxml/oss-parent/38/oss-parent-38.pom
Error occurred on Push - watch command was unable to push component: unable to exec command [/bin/sh -c cd ${PROJECT_SOURCE} && (mvn clean -Dmaven.repo.local=/home/user/.m2/repository package -Dmaven.test.skip=true) 1>>/proc/1/fd/1 2>>/proc/1/fd/2]: error while streaming command: context canceled

Cleaning resources, please wait
 ✗  Dev mode interrupted by user

@rm3l
Copy link
Member Author

rm3l commented Apr 17, 2023

Overall it lgtm, but I noticed that hitting ctrl+c during the build command, it also prints log and an error message, I am not sure if that is something we can/need to hide.

↪ Running on the cluster in Dev mode
 •  Waiting for Kubernetes resources  ...
 ✓  Added storage m2 to component
 ⚠  Pod is Pending
 ⚠  0/1 nodes are available: 1 pod has unbound immediate PersistentVolumeClaims. preemption: 0/1 nodes are available: 1 Preemption is not helpful for scheduling.
 ✓  Pod is Running
 ✓  Syncing files into the container [118ms]
 ✗  Building your application in container (command: build) [8s]
[INFO] Scanning for projects...
Downloading from central: https://repo1.maven.org/maven2/org/springframework/boot/spring-boot-starter-parent/2.3.5.RELEASE/spring-boot-starter-parent-2.3.5.RELEASE.pom
Downloaded from central: https://repo1.maven.org/maven2/org/springframework/boot/spring-boot-starter-parent/2.3.5.RELEASE/spring-boot-starter-parent-2.3.5.RELEASE.pom (8.6 kB at 4.4 kB/s)
Downloading from central: https://repo1.maven.org/maven2/org/springframework/boot/spring-boot-dependencies/2.3.5.RELEASE/spring-boot-dependencies-2.3.5.RELEASE.pom
Downloaded from central: https://repo1.maven.org/maven2/org/springframework/boot/spring-boot-dependencies/2.3.5.RELEASE/spring-boot-dependencies-2.3.5.RELEASE.pom (121 kB at 124 kB/s)
Downloading from central: https://repo1.maven.org/maven2/com/datastax/oss/java-driver-bom/4.6.1/java-driver-bom-4.6.1.pom
Downloaded from central: https://repo1.maven.org/maven2/com/datastax/oss/java-driver-bom/4.6.1/java-driver-bom-4.6.1.pom (3.8 kB at 5.5 kB/s)
Downloading from central: https://repo1.maven.org/maven2/io/dropwizard/metrics/metrics-bom/4.1.14/metrics-bom-4.1.14.pom
Downloaded from central: https://repo1.maven.org/maven2/io/dropwizard/metrics/metrics-bom/4.1.14/metrics-bom-4.1.14.pom (5.3 kB at 8.9 kB/s)
Downloading from central: https://repo1.maven.org/maven2/io/dropwizard/metrics/metrics-parent/4.1.14/metrics-parent-4.1.14.pom
Downloaded from central: https://repo1.maven.org/maven2/io/dropwizard/metrics/metrics-parent/4.1.14/metrics-parent-4.1.14.pom (16 kB at 28 kB/s)
Downloading from central: https://repo1.maven.org/maven2/org/codehaus/groovy/groovy-bom/2.5.13/groovy-bom-2.5.13.pom
Downloaded from central: https://repo1.maven.org/maven2/org/codehaus/groovy/groovy-bom/2.5.13/groovy-bom-2.5.13.pom (26 kB at 41 kB/s)
Downloading from central: https://repo1.maven.org/maven2/com/fasterxml/jackson/jackson-bom/2.11.3/jackson-bom-2.11.3.pom
Downloaded from central: https://repo1.maven.org/maven2/com/fasterxml/jackson/jackson-bom/2.11.3/jackson-bom-2.11.3.pom (14 kB at 24 kB/s)
Downloading from central: https://repo1.maven.org/maven2/com/fasterxml/jackson/jackson-parent/2.11/jackson-parent-2.11.pom
Downloaded from central: https://repo1.maven.org/maven2/com/fasterxml/jackson/jackson-parent/2.11/jackson-parent-2.11.pom (7.8 kB at 13 kB/s)
Downloading from central: https://repo1.maven.org/maven2/com/fasterxml/oss-parent/38/oss-parent-38.pom
Error occurred on Push - watch command was unable to push component: unable to exec command [/bin/sh -c cd ${PROJECT_SOURCE} && (mvn clean -Dmaven.repo.local=/home/user/.m2/repository package -Dmaven.test.skip=true) 1>>/proc/1/fd/1 2>>/proc/1/fd/2]: error while streaming command: context canceled

Cleaning resources, please wait
 ✗  Dev mode interrupted by user

It made sense to me to have the logs displayed, as the build command was interrupted. Previously, we were not displaying any logs because we were waiting for the build command to finish.
But let's see if this becomes an issue later on.

@rm3l rm3l force-pushed the 6196-ctrl-c-doesn-t-work-during-odo-dev-build-phase-and-if-build-is-stuck-the-only-way-out-is-killing-the-terminal branch from b5ae793 to 14bea33 Compare April 18, 2023 14:02
@rm3l
Copy link
Member Author

rm3l commented Apr 18, 2023

Rebased and force-pushed to fix a conflict.

@rm3l rm3l force-pushed the 6196-ctrl-c-doesn-t-work-during-odo-dev-build-phase-and-if-build-is-stuck-the-only-way-out-is-killing-the-terminal branch from 14bea33 to d03be77 Compare April 19, 2023 08:40
@rm3l
Copy link
Member Author

rm3l commented Apr 19, 2023

Rebased and force-pushed to fix conflicts.

@rm3l rm3l closed this Apr 19, 2023
@rm3l rm3l reopened this Apr 19, 2023
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Apr 19, 2023
@valaparthvi
Copy link
Contributor

/override Kubernetes-Integration-Tests/Kubernetes-Docs-Integration-Tests

  [FAILED] user-guides/quickstart/docs-mdx/java/java_odo_dev_output.mdx
  Expected
      <string>:   (
        	"""
        	... // 10 identical lines
        	✓  Added storage m2 to component
        	âš   Pod is Pending
      - 	✓  Pod is Running
        	✓  Syncing files into the container [1s]
        	✓  Building your application in container (command: build) [1s]
        	... // 10 identical lines
        	[Ctrl+c] - Exit and delete resources from the cluster
        	[p] - Manually apply local changes to the application on the cluster
      + 	✓  Pod is Running
        	```
        	"""
        )
      
  to be empty
  In [It] at: /go/odo_1/tests/documentation/user-guides/doc_user_guides_quickstart_test.go:256 @ 04/19/23 09:32:53.84

@openshift-ci
Copy link

openshift-ci bot commented Apr 19, 2023

@valaparthvi: Overrode contexts on behalf of valaparthvi: Kubernetes-Integration-Tests/Kubernetes-Docs-Integration-Tests

In response to this:

/override Kubernetes-Integration-Tests/Kubernetes-Docs-Integration-Tests

 [FAILED] user-guides/quickstart/docs-mdx/java/java_odo_dev_output.mdx
 Expected
     <string>:   (
       	"""
       	... // 10 identical lines
       	✓  Added storage m2 to component
       	âš   Pod is Pending
     - 	✓  Pod is Running
       	✓  Syncing files into the container [1s]
       	✓  Building your application in container (command: build) [1s]
       	... // 10 identical lines
       	[Ctrl+c] - Exit and delete resources from the cluster
       	[p] - Manually apply local changes to the application on the cluster
     + 	✓  Pod is Running
       	```
       	"""
       )
     
 to be empty
 In [It] at: /go/odo_1/tests/documentation/user-guides/doc_user_guides_quickstart_test.go:256 @ 04/19/23 09:32:53.84

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@valaparthvi
Copy link
Contributor

OC Failure:

  ======================
  Unexpected error:
      <*xpty.errPassthroughTimeout | 0xc0001500b0>: {
          error: <*errors.errorString | 0xc000150030>{
              s: "passthrough i/o timeout",
          },
      }
      passthrough i/o timeout
  occurred
  In [It] at: /go/odo_1/tests/helper/helper_interactive.go:111 @ 04/19/23 09:16:55.105

  [FAIL] odo dev interactive command tests when a component is bootstrapped [It] should sync files when p is pressed
  /go/odo_1/tests/helper/helper_interactive.go:111


[FAILED] Timed out after 360.001s.
  Expected
      <string>:   __
       /  \__     Developing using the "my-nodejs-app" Devfile
       \__/  \    Namespace: cmd-describe-list-binding-test787hco
       /  \__/    odo version: v3.9.0
       \__/
      
      ↪ Running on the cluster in Dev mode
       •  Waiting for Kubernetes resources  ...
       •  Creating resource ServiceBinding/my-nodejs-app-cluster-sample-k8s  ...
      
 ✓  Creating resource ServiceBinding/my-nodejs-app-cluster-sample-k8s 
       •  Creating resource ServiceBinding/my-nodejs-app-cluster-sample-ocp  ...
      
 ✓  Creating resource ServiceBinding/my-nodejs-app-cluster-sample-ocp 
       âš   Pod is Pending
       âš   Pod is Terminating
       âš   No pod exists
       âš   Pod is Pending
      
  to contain substring
      <string>: [Ctrl+c] - Exit
  In [BeforeEach] at: /go/odo_1/tests/helper/helper_run.go:54 @ 04/19/23 09:15:31.091

  [FAIL] odo describe/list binding command tests when creating a component with a spec binding (service in namespace "") when Starting a Pg service when running dev session [BeforeEach] when changing the current namespace should list the binding with --namespace flag

@valaparthvi
Copy link
Contributor

Windows failure:

  Checking http://127.0.0.1:51593, for Hello from Node.js Starter Application!
  try 0 of 12
  [odo] E0419 04:02:40.057708   11628 portforward.go:407] an error occurred forwarding 51593 -> 3000: error forwarding port 3000 to pod ca7efe30f45d2f03dca12968fd6b01f422b6f89155af2d4e01f79aea6408cbaf, uid : port forward into network namespace "/var/run/netns/5dc26b92-1509-46df-a78c-729c09b38638": failed to connect to localhost:3000 inside namespace ca7efe30f45d2f03dca12968fd6b01f422b6f89155af2d4e01f79aea6408cbaf: dial tcp [::1]:3000: connect: connection refused
  [odo] E0419 04:02:40.058475   11628 portforward.go:233] lost connection to pod
  error while requesting: Get "http://127.0.0.1:51593": EOF
  [odo]  -  Forwarding from 127.0.0.1:51626 -> 3000
  [odo] 
  [odo]  -  Forwarding from 127.0.0.1:51627 -> 5858
  [odo] 
  [odo] I0419 04:02:40.308234   11628 watch.go:382] filesystem watch event: CREATE        "C:\\Users\\Administrator.ANSIBLE-TEST-VS\\AppData\\Local\\Temp\\1633019422\\.odo\\odo-file-index.json"
  [odo] I0419 04:02:40.308490   11628 watch.go:382] filesystem watch event: WRITE         "C:\\Users\\Administrator.ANSIBLE-TEST-VS\\AppData\\Local\\Temp\\1633019422\\.odo\\odo-file-index.json"
  [odo] I0419 04:02:40.308776   11628 watch.go:382] filesystem watch event: WRITE         "C:\\Users\\Administrator.ANSIBLE-TEST-VS\\AppData\\Local\\Temp\\1633019422\\.odo"
  [odo] I0419 04:02:40.309186   11628 file_watcher.go:97] ignoring watch on path C:\Users\Administrator.ANSIBLE-TEST-VS\AppData\Local\Temp\1633019422\.odo
  [odo] I0419 04:02:40.309186   11628 watch.go:382] filesystem watch event: WRITE         "C:\\Users\\Administrator.ANSIBLE-TEST-VS\\AppData\\Local\\Temp\\1633019422\\.odo\\devstate.json"
  [odo] I0419 04:02:40.309438   11628 watch.go:382] filesystem watch event: WRITE         "C:\\Users\\Administrator.ANSIBLE-TEST-VS\\AppData\\Local\\Temp\\1633019422\\.odo\\devstate.json"
  [odo] I0419 04:02:40.309665   11628 watch.go:382] filesystem watch event: WRITE         "C:\\Users\\Administrator.ANSIBLE-TEST-VS\\AppData\\Local\\Temp\\1633019422\\.odo\\devstate.11628.json"
  [odo] I0419 04:02:40.309883   11628 watch.go:382] filesystem watch event: WRITE         "C:\\Users\\Administrator.ANSIBLE-TEST-VS\\AppData\\Local\\Temp\\1633019422\\.odo\\devstate.11628.json"
  [odo] I0419 04:02:40.310102   11628 watch.go:382] filesystem watch event: WRITE         "C:\\Users\\Administrator.ANSIBLE-TEST-VS\\AppData\\Local\\Temp\\1633019422\\.odo\\devstate.json"
  [odo] I0419 04:02:40.310361   11628 watch.go:382] filesystem watch event: WRITE         "C:\\Users\\Administrator.ANSIBLE-TEST-VS\\AppData\\Local\\Temp\\1633019422\\.odo\\devstate.json"
  [odo] I0419 04:02:40.310595   11628 watch.go:382] filesystem watch event: WRITE         "C:\\Users\\Administrator.ANSIBLE-TEST-VS\\AppData\\Local\\Temp\\1633019422\\.odo\\devstate.11628.json"
  [odo] I0419 04:02:40.310832   11628 watch.go:382] filesystem watch event: WRITE         "C:\\Users\\Administrator.ANSIBLE-TEST-VS\\AppData\\Local\\Temp\\1633019422\\.odo\\devstate.11628.json"
  try 1 of 12
  error while requesting: Get "http://127.0.0.1:51593": dial tcp 127.0.0.1:51593: connectex: ...
...
...
  error while requesting: Get "http://127.0.0.1:51593": dial tcp 127.0.0.1:51593: connectex: No connection could be made because the target machine actively refused it.
  Last output from http://127.0.0.1:51593: 
  [FAILED] in [It] - C:/Users/Administrator.ANSIBLE-TEST-VS/3736/tests/helper/helper_http.go:50 @ 04/19/23 04:03:51.334
  [odo] Cleaning resources, please wait




Summarizing 1 Failure:
  [FAIL] odo dev debug command tests when a component is bootstrapped when running odo dev with debug flag [It] should connect to relevant ports forwarded
  C:/Users/Administrator.ANSIBLE-TEST-VS/3736/tests/helper/helper_http.go:50

@rm3l
Copy link
Member Author

rm3l commented Apr 19, 2023

Windows failure:

  Checking http://127.0.0.1:51593, for Hello from Node.js Starter Application!
  try 0 of 12
  [odo] E0419 04:02:40.057708   11628 portforward.go:407] an error occurred forwarding 51593 -> 3000: error forwarding port 3000 to pod ca7efe30f45d2f03dca12968fd6b01f422b6f89155af2d4e01f79aea6408cbaf, uid : port forward into network namespace "/var/run/netns/5dc26b92-1509-46df-a78c-729c09b38638": failed to connect to localhost:3000 inside namespace ca7efe30f45d2f03dca12968fd6b01f422b6f89155af2d4e01f79aea6408cbaf: dial tcp [::1]:3000: connect: connection refused
  [odo] E0419 04:02:40.058475   11628 portforward.go:233] lost connection to pod
  error while requesting: Get "http://127.0.0.1:51593": EOF
  [odo]  -  Forwarding from 127.0.0.1:51626 -> 3000
  [odo] 
  [odo]  -  Forwarding from 127.0.0.1:51627 -> 5858
  [odo] 
  [odo] I0419 04:02:40.308234   11628 watch.go:382] filesystem watch event: CREATE        "C:\\Users\\Administrator.ANSIBLE-TEST-VS\\AppData\\Local\\Temp\\1633019422\\.odo\\odo-file-index.json"
  [odo] I0419 04:02:40.308490   11628 watch.go:382] filesystem watch event: WRITE         "C:\\Users\\Administrator.ANSIBLE-TEST-VS\\AppData\\Local\\Temp\\1633019422\\.odo\\odo-file-index.json"
  [odo] I0419 04:02:40.308776   11628 watch.go:382] filesystem watch event: WRITE         "C:\\Users\\Administrator.ANSIBLE-TEST-VS\\AppData\\Local\\Temp\\1633019422\\.odo"
  [odo] I0419 04:02:40.309186   11628 file_watcher.go:97] ignoring watch on path C:\Users\Administrator.ANSIBLE-TEST-VS\AppData\Local\Temp\1633019422\.odo
  [odo] I0419 04:02:40.309186   11628 watch.go:382] filesystem watch event: WRITE         "C:\\Users\\Administrator.ANSIBLE-TEST-VS\\AppData\\Local\\Temp\\1633019422\\.odo\\devstate.json"
  [odo] I0419 04:02:40.309438   11628 watch.go:382] filesystem watch event: WRITE         "C:\\Users\\Administrator.ANSIBLE-TEST-VS\\AppData\\Local\\Temp\\1633019422\\.odo\\devstate.json"
  [odo] I0419 04:02:40.309665   11628 watch.go:382] filesystem watch event: WRITE         "C:\\Users\\Administrator.ANSIBLE-TEST-VS\\AppData\\Local\\Temp\\1633019422\\.odo\\devstate.11628.json"
  [odo] I0419 04:02:40.309883   11628 watch.go:382] filesystem watch event: WRITE         "C:\\Users\\Administrator.ANSIBLE-TEST-VS\\AppData\\Local\\Temp\\1633019422\\.odo\\devstate.11628.json"
  [odo] I0419 04:02:40.310102   11628 watch.go:382] filesystem watch event: WRITE         "C:\\Users\\Administrator.ANSIBLE-TEST-VS\\AppData\\Local\\Temp\\1633019422\\.odo\\devstate.json"
  [odo] I0419 04:02:40.310361   11628 watch.go:382] filesystem watch event: WRITE         "C:\\Users\\Administrator.ANSIBLE-TEST-VS\\AppData\\Local\\Temp\\1633019422\\.odo\\devstate.json"
  [odo] I0419 04:02:40.310595   11628 watch.go:382] filesystem watch event: WRITE         "C:\\Users\\Administrator.ANSIBLE-TEST-VS\\AppData\\Local\\Temp\\1633019422\\.odo\\devstate.11628.json"
  [odo] I0419 04:02:40.310832   11628 watch.go:382] filesystem watch event: WRITE         "C:\\Users\\Administrator.ANSIBLE-TEST-VS\\AppData\\Local\\Temp\\1633019422\\.odo\\devstate.11628.json"
  try 1 of 12
  error while requesting: Get "http://127.0.0.1:51593": dial tcp 127.0.0.1:51593: connectex: ...
...
...
  error while requesting: Get "http://127.0.0.1:51593": dial tcp 127.0.0.1:51593: connectex: No connection could be made because the target machine actively refused it.
  Last output from http://127.0.0.1:51593: 
  [FAILED] in [It] - C:/Users/Administrator.ANSIBLE-TEST-VS/3736/tests/helper/helper_http.go:50 @ 04/19/23 04:03:51.334
  [odo] Cleaning resources, please wait




Summarizing 1 Failure:
  [FAIL] odo dev debug command tests when a component is bootstrapped when running odo dev with debug flag [It] should connect to relevant ports forwarded
  C:/Users/Administrator.ANSIBLE-TEST-VS/3736/tests/helper/helper_http.go:50

The new run is now passing.

@rm3l rm3l closed this Apr 20, 2023
@rm3l rm3l reopened this Apr 20, 2023
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 14 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@rm3l
Copy link
Member Author

rm3l commented Apr 20, 2023

Summarizing 4 Failures:
  [FAIL] odo dev command tests 1. devfile contains composite apply command the devfile contains an image component that uses a remote Dockerfile when [PODMAN_CMD=echo] remote server returns an error when odo dev is run [It] should not build images when odo dev is run
  /go/odo_1/tests/helper/helper_run.go:54
  [FAIL] odo dev command tests when running odo dev with devfile containing volume-component - without metadata.name [BeforeEach] should successfully use the volume components in container components
  /go/odo_1/tests/helper/helper_run.go:54
  [FAIL] odo delete command tests when a component is bootstrapped using a devfile.yaml with URI-referenced Kubernetes components when the component is deployed in DEV mode and dev mode stopped [BeforeEach] when the component is deleted using its name (and namespace) from another directory (running-in="") should have deleted the component
  /go/odo_1/tests/helper/helper_run.go:54
  [FAIL] odo dev interactive command tests when a component is bootstrapped [It] should sync files when p is pressed
  /go/odo_1/tests/helper/helper_interactive.go:111

Ran 452 of 824 Specs in 2022.289 seconds
FAIL! -- 448 Passed | 4 Failed | 0 Pending | 372 Skipped

Previous runs of those tests passed.

/override OpenShift-Integration-tests/OpenShift-Integration-tests

@openshift-ci
Copy link

openshift-ci bot commented Apr 20, 2023

@rm3l: Overrode contexts on behalf of rm3l: OpenShift-Integration-tests/OpenShift-Integration-tests

In response to this:

Summarizing 4 Failures:
 [FAIL] odo dev command tests 1. devfile contains composite apply command the devfile contains an image component that uses a remote Dockerfile when [PODMAN_CMD=echo] remote server returns an error when odo dev is run [It] should not build images when odo dev is run
 /go/odo_1/tests/helper/helper_run.go:54
 [FAIL] odo dev command tests when running odo dev with devfile containing volume-component - without metadata.name [BeforeEach] should successfully use the volume components in container components
 /go/odo_1/tests/helper/helper_run.go:54
 [FAIL] odo delete command tests when a component is bootstrapped using a devfile.yaml with URI-referenced Kubernetes components when the component is deployed in DEV mode and dev mode stopped [BeforeEach] when the component is deleted using its name (and namespace) from another directory (running-in="") should have deleted the component
 /go/odo_1/tests/helper/helper_run.go:54
 [FAIL] odo dev interactive command tests when a component is bootstrapped [It] should sync files when p is pressed
 /go/odo_1/tests/helper/helper_interactive.go:111

Ran 452 of 824 Specs in 2022.289 seconds
FAIL! -- 448 Passed | 4 Failed | 0 Pending | 372 Skipped

Previous runs of those tests passed.

/override OpenShift-Integration-tests/OpenShift-Integration-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@rm3l
Copy link
Member Author

rm3l commented Apr 20, 2023


Summarizing 2 Failures:
  [FAIL] odo list with devfile [AfterEach] listing non-odo managed components when an operator managed deployment(without instance and managed-by label) is deployed should not be listed in the odo list output
  C:/Users/Administrator.ANSIBLE-TEST-VS/3746/tests/helper/helper_cmd_wrapper.go:101
  [FAIL] odo add binding interactive command tests when running a deployment [BeforeEach] should successfully add binding without devfile (custom naming strategy: "")
  C:/Users/Administrator.ANSIBLE-TEST-VS/3746/tests/helper/helper_oc.go:34

Ran 443 of 824 Specs in 1613.391 seconds
FAIL! -- 441 Passed | 2 Failed | 0 Pending | 381 Skipped

Previous runs of those tests passed.

/override windows-integration-test/Windows-test

@openshift-ci
Copy link

openshift-ci bot commented Apr 20, 2023

@rm3l: Overrode contexts on behalf of rm3l: windows-integration-test/Windows-test

In response to this:


Summarizing 2 Failures:
 [FAIL] odo list with devfile [AfterEach] listing non-odo managed components when an operator managed deployment(without instance and managed-by label) is deployed should not be listed in the odo list output
 C:/Users/Administrator.ANSIBLE-TEST-VS/3746/tests/helper/helper_cmd_wrapper.go:101
 [FAIL] odo add binding interactive command tests when running a deployment [BeforeEach] should successfully add binding without devfile (custom naming strategy: "")
 C:/Users/Administrator.ANSIBLE-TEST-VS/3746/tests/helper/helper_oc.go:34

Ran 443 of 824 Specs in 1613.391 seconds
FAIL! -- 441 Passed | 2 Failed | 0 Pending | 381 Skipped

Previous runs of those tests passed.

/override windows-integration-test/Windows-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot merged commit 4bab928 into redhat-developer:main Apr 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. Required by Prow.
Projects
None yet
2 participants