Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update image for springboot devfiles #6753

Merged
merged 1 commit into from
Apr 20, 2023
Merged

Update image for springboot devfiles #6753

merged 1 commit into from
Apr 20, 2023

Conversation

feloy
Copy link
Contributor

@feloy feloy commented Apr 20, 2023 •
edited
Loading

Updates the springboot devfiles stored in the odo repository with a more up-to-date image.

(devfile/registry@bf3a2ce)

What type of PR is this:

/area testing

What does this PR do / why we need it:

Which issue(s) this PR fixes:

Fixes #6754

PR acceptance criteria:

  • Unit test

  • Integration test

  • Documentation

How to test changes / Special notes to the reviewer:

@openshift-ci openshift-ci bot added the area/testing Issues or PRs related to testing, Quality Assurance or Quality Engineering label Apr 20, 2023
@netlify
Copy link

netlify bot commented Apr 20, 2023 •
edited
Loading

✅ Deploy Preview for odo-docusaurus-preview canceled.

Name Link
🔨 Latest commit 6f8fffc
🔍 Latest deploy log https://app.netlify.com/sites/odo-docusaurus-preview/deploys/6440db4dea9d3e0008f1de3a

@sonarcloud
Copy link

sonarcloud bot commented Apr 20, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@odo-robot
Copy link

odo-robot bot commented Apr 20, 2023

NoCluster Tests on commit finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Apr 20, 2023

OpenShift Unauthenticated Tests on commit finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Apr 20, 2023

Unit Tests on commit finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Apr 20, 2023

Validate Tests on commit finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Apr 20, 2023

Kubernetes Tests on commit finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Apr 20, 2023

Windows Tests (OCP) on commit finished with errors.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Apr 20, 2023

OpenShift Tests on commit finished with errors.
View logs: TXT HTML

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Apr 20, 2023
@rm3l rm3l added this to the v3.10.0 🚀 milestone Apr 20, 2023
@feloy
Copy link
Contributor Author

feloy commented Apr 20, 2023

/override windows-integration-test/Windows-test

Network error

[FAILED] [142.581 seconds]
odo dev command tests when node-js application is created and deployed with devfile schema 2.2.0 [It] should check memory Request and Limit
C:/Users/Administrator.ANSIBLE-TEST-VS/3745/tests/integration/cmd_dev_test.go:2782

[...]

[oc] Unable to connect to the server: dial tcp 149.81.180.122:31700: connectex: A connection attempt failed because the connected party did not properly respond after a period of time, or established connection failed because connected host has failed to respond.
  [FAILED] in [It] - C:/Users/Administrator.ANSIBLE-TEST-VS/3745/tests/helper/helper_oc.go:34 @ 04/20/23 01:34:14.648
  [odo] Cleaning resources, please wait

@openshift-ci
Copy link

openshift-ci bot commented Apr 20, 2023

@feloy: Overrode contexts on behalf of feloy: windows-integration-test/Windows-test

In response to this:

/override windows-integration-test/Windows-test

Network error

[FAILED] [142.581 seconds]
odo dev command tests when node-js application is created and deployed with devfile schema 2.2.0 [It] should check memory Request and Limit
C:/Users/Administrator.ANSIBLE-TEST-VS/3745/tests/integration/cmd_dev_test.go:2782

[...]

[oc] Unable to connect to the server: dial tcp 149.81.180.122:31700: connectex: A connection attempt failed because the connected party did not properly respond after a period of time, or established connection failed because connected host has failed to respond.
 [FAILED] in [It] - C:/Users/Administrator.ANSIBLE-TEST-VS/3745/tests/helper/helper_oc.go:34 @ 04/20/23 01:34:14.648
 [odo] Cleaning resources, please wait

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@feloy
Copy link
Contributor Author

feloy commented Apr 20, 2023

/override OpenShift-Integration-tests/OpenShift-Integration-tests

Flaky test

[FAILED] [174.329 seconds]
odo logs command tests when component is created and odo logs is executed when running in both Dev and Deploy mode [It] should successfully show logs of the running component
/go/odo_1/tests/integration/cmd_logs_test.go:247

@openshift-ci
Copy link

openshift-ci bot commented Apr 20, 2023

@feloy: Overrode contexts on behalf of feloy: OpenShift-Integration-tests/OpenShift-Integration-tests

In response to this:

/override OpenShift-Integration-tests/OpenShift-Integration-tests

Flaky test

[FAILED] [174.329 seconds]
odo logs command tests when component is created and odo logs is executed when running in both Dev and Deploy mode [It] should successfully show logs of the running component
/go/odo_1/tests/integration/cmd_logs_test.go:247

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

rm3l
rm3l reviewed Apr 20, 2023
View reviewed changes
...mples/source/devfiles/springboot/devfile-with-missing-projectType-and-language-metadata.yaml
@@ -20,7 +20,7 @@ components:
mountSources: true
- name: runtime
container:
image: quay.io/eclipse/che-java11-maven:next
image: registry.access.redhat.com/ubi8/openjdk-11:latest
Copy link
Member

@rm3l rm3l Apr 20, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/hold

I checked why the 'spring-boot' Maven plugin was surprisingly not found, and I think this has nothing to do with the container image.
It looks like the run command is being executed in the runtime container which has mountSources set to false. So without any local pom.xml files (coming from the project sources), Maven will try to resolve the short spring-boot plugin name from its known plugins by default.
I tested with the registry.access.redhat.com/ubi8/openjdk-11:latest image, and it behaves the same way, except that the command did not return any logs..
At least, the Dev Session started successfully by setting mountSources to true in the runtime container component. Well, it is still great to update the image name too.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/hold cancel

Unholding as it is still fine, but we can consider updating mountSources in a separate PR.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The error I have seen (and which has been fixed by changing the image) was occuring during the build command.

Copy link
Member

@rm3l rm3l Apr 21, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, for the build, I think it was a DNS resolution error (from what I can see in the job logs):

 [odo]  ✗  Building your application in container (command: defaultbuild) [2s]
  [odo] [INFO] Scanning for projects...
  [odo] Downloading from central: https://repo.maven.apache.org/maven2/org/springframework/boot/spring-boot-starter-parent/2.3.5.RELEASE/spring-boot-starter-parent-2.3.5.RELEASE.pom
  [odo] [ERROR] [ERROR] Some problems were encountered while processing the POMs:
  [odo] [FATAL] Non-resolvable parent POM for com.example:demo:0.0.1-SNAPSHOT: Could not transfer artifact org.springframework.boot:spring-boot-starter-parent:pom:2.3.5.RELEASE from/to central (https://repo.maven.apache.org/maven2): Transfer failed for https://repo.maven.apache.org/maven2/org/springframework/boot/spring-boot-starter-parent/2.3.5.RELEASE/spring-boot-starter-parent-2.3.5.RELEASE.pom and 'parent.relativePath' points at no local POM @ line 5, column 10
  [odo]  @ 
  [odo] [ERROR] The build could not read 1 project -> [Help 1]
  [odo] [ERROR]   
  [odo] [ERROR]   The project com.example:demo:0.0.1-SNAPSHOT (/projects/pom.xml) has 1 error
  [odo] [ERROR]     Non-resolvable parent POM for com.example:demo:0.0.1-SNAPSHOT: Could not transfer artifact org.springframework.boot:spring-boot-starter-parent:pom:2.3.5.RELEASE from/to central (https://repo.maven.apache.org/maven2): Transfer failed for https://repo.maven.apache.org/maven2/org/springframework/boot/spring-boot-starter-parent/2.3.5.RELEASE/spring-boot-starter-parent-2.3.5.RELEASE.pom and 'parent.relativePath' points at no local POM @ line 5, column 10: 

Unknown host repo.maven.apache.org: Name or service not known -> [Help 2]

But once that passes, the run command (which runs the spring-boot:run goal) cannot run if the sources are not mounted (or if the Maven settings in the container image do not indicate how to resolve the spring-boot plugin).
I'll create a separate PR to mount the sources so that this can run properly..

@openshift-ci openshift-ci bot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. Required by Prow. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. Required by Prow. labels Apr 20, 2023
@openshift-ci openshift-ci bot merged commit 32f92d1 into redhat-developer:main Apr 20, 2023
@rm3l rm3l removed this from the v3.10.0 🚀 milestone May 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rm3l rm3l rm3l approved these changes

@anandrkskd anandrkskd Awaiting requested review from anandrkskd

@valaparthvi valaparthvi Awaiting requested review from valaparthvi

Assignees

@rm3l rm3l

Labels
area/testing Issues or PRs related to testing, Quality Assurance or Quality Engineering lgtm Indicates that a PR is ready to be merged. Required by Prow.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Springboot tests are failing
2 participants
@feloy @rm3l