Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doc automation:Command reference: odo delete,list and set namespace #6756

Merged
merged 4 commits into from
Apr 27, 2023

Conversation

ritudes
Copy link
Contributor

@ritudes ritudes commented Apr 20, 2023

What type of PR is this:

area/documentation

What does this PR do / why we need it:

Which issue(s) this PR fixes:

Fixes #6724

PR acceptance criteria:

  • Unit test

  • Integration test

  • Documentation

How to test changes / Special notes to the reviewer:

Signed-off-by: Ritu Deshmukh <rideshmu@redhat.com>
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. Required by Prow. label Apr 20, 2023
@netlify
Copy link

netlify bot commented Apr 20, 2023

Deploy Preview for odo-docusaurus-preview ready!

Name Link
🔨 Latest commit de7de4f
🔍 Latest deploy log https://app.netlify.com/sites/odo-docusaurus-preview/deploys/6448fec754dee600084c751b
😎 Deploy Preview https://deploy-preview-6756--odo-docusaurus-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@odo-robot
Copy link

odo-robot bot commented Apr 20, 2023

OpenShift Unauthenticated Tests on commit f9a2e5e finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Apr 20, 2023

NoCluster Tests on commit f9a2e5e finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Apr 20, 2023

Unit Tests on commit f9a2e5e finished with errors.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Apr 20, 2023

Validate Tests on commit f9a2e5e finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Apr 20, 2023

Kubernetes Tests on commit f9a2e5e finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Apr 20, 2023

Windows Tests (OCP) on commit f9a2e5e finished with errors.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Apr 20, 2023

OpenShift Tests on commit f9a2e5e finished with errors.
View logs: TXT HTML

ritudes added 2 commits April 24, 2023 13:32
Signed-off-by: Ritu Deshmukh <rideshmu@redhat.com>
Signed-off-by: Ritu Deshmukh <rideshmu@redhat.com>
@ritudes ritudes added area/documentation Issues or PRs related to documentation or the 'odo.dev' website and removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. Required by Prow. labels Apr 24, 2023
@ritudes ritudes changed the title [WIP] Doc automation:Command reference: odo delete,list and set namespace Doc automation:Command reference: odo delete,list and set namespace Apr 24, 2023
@ritudes ritudes added the area/testing Issues or PRs related to testing, Quality Assurance or Quality Engineering label Apr 24, 2023
@openshift-ci
Copy link

openshift-ci bot commented Apr 25, 2023

@ritudes: ritudes unauthorized: /override is restricted to Repo administrators, approvers in top level OWNERS file, and the following github teams:.

In response to this:

/override OpenShift-Integration-tests/OpenShift-Integration-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@feloy feloy closed this Apr 25, 2023
@feloy feloy reopened this Apr 25, 2023
@valaparthvi valaparthvi reopened this Apr 25, 2023
@ritudes ritudes closed this Apr 25, 2023
@ritudes ritudes reopened this Apr 25, 2023
@odo-robot
Copy link

odo-robot bot commented Apr 25, 2023

Kubernetes Docs Tests on commit b57d3e2 finished successfully.
View logs: TXT HTML

@feloy
Copy link
Contributor

feloy commented Apr 25, 2023

I can see 3 tests failing:

FAILED] [2.655 seconds]
doc command reference odo delete namespace To delete a namespace resource [It] Deletes a namespace resource for a kubernetes cluster
/go/odo_1/tests/documentation/command-reference/doc_command_reference_deletenamespace_test.go:40

[FAILED] [6.054 seconds]
doc command reference odo create namespace To create a namespace resource [It] Creates a namespace resource for a kubernetes cluster
/go/odo_1/tests/documentation/command-reference/doc_command_reference_createnamespace_test.go:35

[FAILED] [2.446 seconds]
doc command reference odo delete namespace To delete a namespace resource [It] Deletes a project resource for a openshift cluster
/go/odo_1/tests/documentation/command-reference/doc_command_reference_deletenamespace_test.go:57

@ritudes ritudes closed this Apr 26, 2023
@ritudes ritudes reopened this Apr 26, 2023
@feloy
Copy link
Contributor

feloy commented Apr 26, 2023

I can see 3 tests failing:

FAILED] [2.655 seconds]
doc command reference odo delete namespace To delete a namespace resource [It] Deletes a namespace resource for a kubernetes cluster
/go/odo_1/tests/documentation/command-reference/doc_command_reference_deletenamespace_test.go:40

[FAILED] [6.054 seconds]
doc command reference odo create namespace To create a namespace resource [It] Creates a namespace resource for a kubernetes cluster
/go/odo_1/tests/documentation/command-reference/doc_command_reference_createnamespace_test.go:35

[FAILED] [2.446 seconds]
doc command reference odo delete namespace To delete a namespace resource [It] Deletes a project resource for a openshift cluster
/go/odo_1/tests/documentation/command-reference/doc_command_reference_deletenamespace_test.go:57

@ritudes I can see these tests failing when running them locally. I think you will need to fix them

@ritudes
Copy link
Contributor Author

ritudes commented Apr 26, 2023

Yes @feloy , I am looking into it.

Signed-off-by: Ritu Deshmukh <rideshmu@redhat.com>
@ritudes ritudes closed this Apr 26, 2023
@ritudes ritudes reopened this Apr 26, 2023
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 11 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@feloy
Copy link
Contributor

feloy commented Apr 27, 2023

/lgtm

Thanks @ritudes for this work

/override windows-integration-test/Windows-test

[FAILED] [288.498 seconds]
odo dev command tests 1. devfile contains composite apply command when odo dev is running [It] should execute the composite apply commands successfully
C:/Users/Administrator.ANSIBLE-TEST-VS/3813/tests/integration/cmd_dev_test.go:1930

/override OpenShift-Integration-tests/OpenShift-Integration-tests

[FAILED] [368.941 seconds]
odo dev command tests when node-js application is created and deployed with devfile schema 2.2.0 when Update the devfile.yaml, and waiting synchronization [BeforeEach] should check cpuLimit, cpuRequests, memoryRequests after restart

/override Unit-Tests/Unit-Tests
Flaky test

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Apr 27, 2023
@openshift-ci
Copy link

openshift-ci bot commented Apr 27, 2023

@feloy: Overrode contexts on behalf of feloy: OpenShift-Integration-tests/OpenShift-Integration-tests, Unit-Tests/Unit-Tests, windows-integration-test/Windows-test

In response to this:

/lgtm

Thanks @ritudes for this work

/override windows-integration-test/Windows-test

[FAILED] [288.498 seconds]
odo dev command tests 1. devfile contains composite apply command when odo dev is running [It] should execute the composite apply commands successfully
C:/Users/Administrator.ANSIBLE-TEST-VS/3813/tests/integration/cmd_dev_test.go:1930

/override OpenShift-Integration-tests/OpenShift-Integration-tests

[FAILED] [368.941 seconds]
odo dev command tests when node-js application is created and deployed with devfile schema 2.2.0 when Update the devfile.yaml, and waiting synchronization [BeforeEach] should check cpuLimit, cpuRequests, memoryRequests after restart

/override Unit-Tests/Unit-Tests
Flaky test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot openshift-merge-robot merged commit 5913097 into redhat-developer:main Apr 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/documentation Issues or PRs related to documentation or the 'odo.dev' website area/testing Issues or PRs related to testing, Quality Assurance or Quality Engineering lgtm Indicates that a PR is ready to be merged. Required by Prow.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Automate Doc: odo delete namespace, odo list namespace, and odo set namespace
4 participants