Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blog: Helm integration with odo #6775

Merged

Conversation

valaparthvi
Copy link
Contributor

@valaparthvi valaparthvi commented Apr 27, 2023

What type of PR is this:
/area documentation

What does this PR do / why we need it:

Which issue(s) this PR fixes:

Fixes #6645

PR acceptance criteria:

  • Unit test

  • Integration test

  • Documentation

How to test changes / Special notes to the reviewer:
https://deploy-preview-6775--odo-docusaurus-preview.netlify.app/blog/using-helm-with-odo

@openshift-ci openshift-ci bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. Required by Prow. area/documentation Issues or PRs related to documentation or the 'odo.dev' website labels Apr 27, 2023
@netlify
Copy link

netlify bot commented Apr 27, 2023

Deploy Preview for odo-docusaurus-preview ready!

Name Link
🔨 Latest commit 6084720
🔍 Latest deploy log https://app.netlify.com/sites/odo-docusaurus-preview/deploys/64535fc0a497f900076a82e5
😎 Deploy Preview https://deploy-preview-6775--odo-docusaurus-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@openshift-ci openshift-ci bot requested review from kadel and rm3l April 27, 2023 05:46
@odo-robot
Copy link

odo-robot bot commented Apr 27, 2023

NoCluster Tests on commit b436267 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Apr 27, 2023

OpenShift Unauthenticated Tests on commit b436267 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Apr 27, 2023

Unit Tests on commit b436267 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Apr 27, 2023

Validate Tests on commit b436267 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Apr 27, 2023

Kubernetes Tests on commit b436267 finished with errors.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Apr 27, 2023

Windows Tests (OCP) on commit b436267 finished with errors.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Apr 27, 2023

Kubernetes Docs Tests on commit d0ba624 finished with errors.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Apr 27, 2023

OpenShift Tests on commit b436267 finished successfully.
View logs: TXT HTML

@valaparthvi valaparthvi changed the title [WIP] Blog: Helm integration with odo Blog: Helm integration with odo Apr 27, 2023
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. Required by Prow. label Apr 27, 2023
Copy link
Member

@rm3l rm3l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1:27:19 PM: [ERROR] Unable to build website for locale en.
1:27:19 PM: [ERROR] Error: Docusaurus found broken links!
1:27:19 PM: 
1:27:19 PM: Please check the pages of your site in the list below, and make sure you don't reference any path that does not exist.
Note: it's possible to ignore broken links with the 'onBrokenLinks' Docusaurus configuration, and let the build pass.
1:27:19 PM: Exhaustive list of all broken links found:
1:27:19 PM: 
1:27:19 PM: - On source page path = /blog:
1:27:19 PM:    -> linking to github.com/redhat-developer/odo/releases/tag/v3.8.0 (resolved as: /github.com/redhat-developer/odo/releases/tag/v3.8.0)
1:27:19 PM: 
1:27:19 PM: - On source page path = /blog/using-helm-with-odo:
1:27:19 PM:    -> linking to github.com/redhat-developer/odo/releases/tag/v3.8.0 (resolved as: /blog/github.com/redhat-developer/odo/releases/tag/v3.8.0)
1:27:19 PM: 
1:27:19 PM:     at throwError (/opt/build/repo/docs/website/node_modules/@docusaurus/logger/lib/index.js:76:11)
1:27:19 PM:     at handleBrokenLinks (/opt/build/repo/docs/website/node_modules/@docusaurus/core/lib/server/brokenLinks.js:153:47)
1:27:19 PM:     at async buildLocale (/opt/build/repo/docs/website/node_modules/@docusaurus/core/lib/commands/build.js:186:5)
1:27:19 PM:     at async tryToBuildLocale (/opt/build/repo/docs/website/node_modules/@docusaurus/core/lib/commands/build.js:41:20)
1:27:19 PM:     at async mapAsyncSequential (/opt/build/repo/docs/website/node_modules/@docusaurus/utils/lib/jsUtils.js:34:24)
1:27:19 PM:     at async Command.build (/opt/build/repo/docs/website/node_modules/@docusaurus/core/lib/commands/build.js:76:21)

Looks like there are broken links in this blog post..

Signed-off-by: Parthvi Vala <pvala@redhat.com>
@feloy
Copy link
Contributor

feloy commented May 2, 2023

Could you add a <!--truncate--> line somewhere, or the complete article is displayed in the blogs page?

Co-authored-by: Armel Soro <asoro@redhat.com>
Signed-off-by: Parthvi Vala <pvala@redhat.com>
@sonarcloud
Copy link

sonarcloud bot commented May 4, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 5 Code Smells

No Coverage information No Coverage information
0.2% 0.2% Duplication

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label May 4, 2023
@rm3l
Copy link
Member

rm3l commented May 4, 2023

/override ODO-PODMAN-TEST
/override Kubernetes-Integration-Tests/Kubernetes-Integration-Tests
/override windows-integration-test/Windows-test

Not related - doc-only.

@openshift-ci
Copy link

openshift-ci bot commented May 4, 2023

@rm3l: Overrode contexts on behalf of rm3l: Kubernetes-Integration-Tests/Kubernetes-Integration-Tests, ODO-PODMAN-TEST, windows-integration-test/Windows-test

In response to this:

/override ODO-PODMAN-TEST
/override Kubernetes-Integration-Tests/Kubernetes-Integration-Tests
/override windows-integration-test/Windows-test

Not related - doc-only.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot openshift-merge-robot merged commit 6dd357d into redhat-developer:main May 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/documentation Issues or PRs related to documentation or the 'odo.dev' website lgtm Indicates that a PR is ready to be merged. Required by Prow.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Blog Post: pick a use case for using exec for Deploy (e.g., DB Migration, Helm, Kustomize, ..)
4 participants