-
Notifications
You must be signed in to change notification settings - Fork 243
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updating the oudated release script #6801
Updating the oudated release script #6801
Conversation
Signed-off-by: Ritu Deshmukh <rideshmu@redhat.com>
✅ Deploy Preview for odo-docusaurus-preview canceled.
|
Co-authored-by: Armel Soro <armel@rm3l.org>
Co-authored-by: Armel Soro <armel@rm3l.org>
scripts/release-bit-verification.sh
Outdated
WORKING_DIR=$(mktemp -d) | ||
shout "WORKING_DIR=$WORKING_DIR" | ||
export REPO_URL=${REPO_URL:-"https://github.com/redhat-developer/odo.git"} | ||
if [ -f ${1} ]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This would still create the temporary directory if the file is not valid.
I'd suggest inverting the condition: exit if the file does not exist, without even creating the temporary directory.
Once all checks are done on the first argument, we can proceed with creating the temporary directory.
Kudos, SonarCloud Quality Gate passed! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the changes.
Unrelated. /override ODO-PODMAN-TEST |
@rm3l: Overrode contexts on behalf of rm3l: ODO-PODMAN-TEST In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Network issues on Windows - tracked in #6838 /override windows-integration-test/Windows-test |
@rm3l: Overrode contexts on behalf of rm3l: windows-integration-test/Windows-test In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/override ODO-PODMAN-TEST |
@rm3l: /override requires failed status contexts, check run or a prowjob name to operate on.
Only the following failed contexts/checkruns were expected:
If you are trying to override a checkrun that has a space in it, you must put a double quote on the context. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What type of PR is this:
What does this PR do / why we need it:
Which issue(s) this PR fixes:
Fixes #6730
PR acceptance criteria:
Unit test
Integration test
Documentation
How to test changes / Special notes to the reviewer: