Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete previous pod and creates new ond when modifying devfile on podman #6802

Conversation

feloy
Copy link
Contributor

@feloy feloy commented May 9, 2023

What type of PR is this:

/kind feature

What does this PR do / why we need it:

Which issue(s) this PR fixes:

Fixes #6458

PR acceptance criteria:

  • Unit test

  • Integration test

  • Documentation

How to test changes / Special notes to the reviewer:

@netlify
Copy link

netlify bot commented May 9, 2023

Deploy Preview for odo-docusaurus-preview canceled.

Name Link
🔨 Latest commit 9918103
🔍 Latest deploy log https://app.netlify.com/sites/odo-docusaurus-preview/deploys/645a73fef493e50008036154

@openshift-ci openshift-ci bot added the kind/feature Categorizes issue as a feature request. For PRs, that means that the PR is the implementation label May 9, 2023
@openshift-ci openshift-ci bot requested review from anandrkskd and kadel May 9, 2023 08:15
@feloy feloy requested review from valaparthvi and rm3l and removed request for kadel and anandrkskd May 9, 2023 08:16
@odo-robot
Copy link

odo-robot bot commented May 9, 2023

NoCluster Tests on commit 23b0c4f finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented May 9, 2023

OpenShift Unauthenticated Tests on commit 23b0c4f finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented May 9, 2023

Unit Tests on commit 23b0c4f finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented May 9, 2023

Validate Tests on commit 23b0c4f finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented May 9, 2023

Kubernetes Tests on commit 23b0c4f finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented May 9, 2023

Windows Tests (OCP) on commit 23b0c4f finished with errors.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented May 9, 2023

OpenShift Tests on commit 23b0c4f finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented May 9, 2023

Kubernetes Docs Tests on commit 5459326 finished successfully.
View logs: TXT HTML

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label May 10, 2023
@valaparthvi valaparthvi reopened this May 10, 2023
@sonarcloud
Copy link

sonarcloud bot commented May 10, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@valaparthvi
Copy link
Contributor

  [FAILED] Expected
      <*url.Error | 0xc00070e7e0>: {
          Op: "Post",
          URL: "http://127.0.0.1:58103/api/newuser",
          Err: <*errors.errorString | 0xc00008a130>{s: "EOF"},
      }
  to be nil
  In [It] at: C:/Users/Administrator.ANSIBLE-TEST-VS/3913/tests/e2escenarios/e2e_test.go:431 @ 05/10/23 03:21:17.334

  There were additional failures detected.  To view them in detail run ginkgo -vv
------------------------------
+ [259.440 seconds]
E2E Test starting with non-empty Directory should verify developer workflow from non-empty Directory
C:/Users/Administrator.ANSIBLE-TEST-VS/3913/tests/e2escenarios/e2e_test.go:197

  Captured StdOut/StdErr Output >>
  Spawning 'C:\Users\Administrator.ANSIBLE-TEST-VS\3913\bin\odo.exe init' from C:\Users\Administrator.ANSIBLE-TEST-VS\AppData\Local\Temp\2670130904
  Spawning 'C:\Users\Administrator.ANSIBLE-TEST-VS\3913\bin\odo.exe delete component' from C:\Users\Administrator.ANSIBLE-TEST-VS\AppData\Local\Temp\2670130904
  << Captured StdOut/StdErr Output
------------------------------

Summarizing 1 Failure:
  [FAIL] E2E Test starting with non-empty Directory add Binding [It] should verify developer workflow of using binding as env in innerloop
  C:/Users/Administrator.ANSIBLE-TEST-VS/3913/tests/e2escenarios/e2e_test.go:431

/override
windows-integration-test/Windows-test

@valaparthvi
Copy link
Contributor

/override windows-integration-test/Windows-test

@openshift-ci
Copy link

openshift-ci bot commented May 10, 2023

@valaparthvi: Overrode contexts on behalf of valaparthvi: windows-integration-test/Windows-test

In response to this:

/override windows-integration-test/Windows-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot openshift-merge-robot merged commit da28e7d into redhat-developer:main May 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue as a feature request. For PRs, that means that the PR is the implementation lgtm Indicates that a PR is ready to be merged. Required by Prow.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Restart pod on Podman when related information is changed in Devfile
3 participants