-
Notifications
You must be signed in to change notification settings - Fork 243
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace deprecated --slow-spec-threshold
Ginkgo flag with --poll-progress-after
#6834
Replace deprecated --slow-spec-threshold
Ginkgo flag with --poll-progress-after
#6834
Conversation
…rogress-after' Per [1], this instructs Ginkgo to automatically emit a progress report whenever a node takes too long to complete. The Progress Report includes information about which node is currently running and the exact line of code that it is currently executing, along with any relevant goroutines that were launched by the spec. [1] https://onsi.github.io/ginkgo/#getting-visibility-into-long-running-specs
✅ Deploy Preview for odo-docusaurus-preview canceled.
|
Kudos, SonarCloud Quality Gate passed! |
/override windows-integration-test/Windows-test |
@valaparthvi: Overrode contexts on behalf of valaparthvi: windows-integration-test/Windows-test In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/override ODO-PODMAN-TEST |
@valaparthvi: Overrode contexts on behalf of valaparthvi: ODO-PODMAN-TEST In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What type of PR is this:
/area testing
What does this PR do / why we need it:
Per [1], this instructs Ginkgo to automatically emit a progress report whenever a node takes too long to complete.
The Progress Report includes information about which node is currently running and the exact line of code that it is currently executing, along with any relevant goroutines that were launched by the spec.
[1] https://onsi.github.io/ginkgo/#getting-visibility-into-long-running-specs
Which issue(s) this PR fixes:
Deprecation warnings as seen at the end of all our tests, like here:
PR acceptance criteria:
Unit test
Integration test
Documentation
How to test changes / Special notes to the reviewer: