Fix issues with describe/list binding tests #6839
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Parthvi Vala <pvala@redhat.com> Co-authored-by: Armel Soro <asoro@redhat.com>
✅ Deploy Preview for odo-docusaurus-preview ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
openshift-ci
bot
added
kind/bug
valaparthvi
changed the title
openshift-ci
bot
added
the
do-not-merge/work-in-progress
Signed-off-by: Parthvi Vala <pvala@redhat.com>
Signed-off-by: Parthvi Vala <pvala@redhat.com>
|
Kudos, SonarCloud Quality Gate passed!
|
valaparthvi
changed the title
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
feloy
approved these changes
May 26, 2023
openshift-ci
bot
added
the
lgtm
|
/override windows-integration-test/Windows-test connectex errors |
|
@feloy: Overrode contexts on behalf of feloy: windows-integration-test/Windows-test In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this:
/kind bug
/area testing
What does this PR do / why we need it:
This PR fixes some issues we discovered with the describe/list binding tests while working on #6829.
Which issue(s) this PR fixes:
Fixes #6846
PR acceptance criteria:
Unit test
Integration test
Documentation
How to test changes / Special notes to the reviewer: