Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix should print warning about default namespace when running odo dev test when Dev Session does not start correctly #6848

Conversation

rm3l
Copy link
Member

@rm3l rm3l commented May 26, 2023

What type of PR is this:
/kind bug
/area testing

What does this PR do / why we need it:
The goal of this test is to ensure that the warning message is displayed when using the default namespace/project;
so it does not matter if the Dev Session does not start correctly (as can be the case in certain environments like OCP 4.14).

Which issue(s) this PR fixes:
Fixes #6847

PR acceptance criteria:

  • Unit test

  • Integration test

  • Documentation

How to test changes / Special notes to the reviewer:

…v` test when Dev Session does not start correctly

The goal of this test is to ensure that the warning message is displayed,
so it does not matter if the Dev Session does not start correctly.
@openshift-ci openshift-ci bot added the kind/bug Categorizes issue or PR as related to a bug. label May 26, 2023
@netlify
Copy link

netlify bot commented May 26, 2023

Deploy Preview for odo-docusaurus-preview canceled.

Name Link
🔨 Latest commit 2636c25
🔍 Latest deploy log https://app.netlify.com/sites/odo-docusaurus-preview/deploys/647086d4e69e9a0008bc8144

@openshift-ci openshift-ci bot added the area/testing Issues or PRs related to testing, Quality Assurance or Quality Engineering label May 26, 2023
@openshift-ci openshift-ci bot requested review from ritudes and rnapoles-rh May 26, 2023 10:16
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@rm3l rm3l added this to the v3.11.0 🚀 milestone May 26, 2023
@odo-robot
Copy link

odo-robot bot commented May 26, 2023

NoCluster Tests on commit finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented May 26, 2023

OpenShift Unauthenticated Tests on commit finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented May 26, 2023

Unit Tests on commit finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented May 26, 2023

Validate Tests on commit finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented May 26, 2023

Kubernetes Tests on commit finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented May 26, 2023

OpenShift Tests on commit finished with errors.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented May 26, 2023

Windows Tests (OCP) on commit finished with errors.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented May 26, 2023

Kubernetes Docs Tests on commit b60fc5b finished successfully.
View logs: TXT HTML

@rm3l rm3l requested review from feloy and valaparthvi May 26, 2023 13:08
@rm3l
Copy link
Member Author

rm3l commented May 26, 2023

  [odo] I0526 10:44:15.079858   10344 watch.go:428] Error from Push: watch command was unable to push component: unable to delete remote resources: unable to delete resource: ServiceBinding/my-nodejs-app-cluster-sample-k8s: timeout while waiting for "my-nodejs-app-cluster-sample-k8s" resource to be deleted

...
Summarizing 1 Failure:
  [FAIL] odo remove binding command tests when the component with binding is bootstrapped (bindingName=my-nodejs-app-cluster-sample-k8s) when odo dev is running when binding is removed [It] should have led odo dev to delete ServiceBinding from the cluster
  /go/odo_1/tests/integration/cmd_remove_binding_test.go:73

Ran 487 of 890 Specs in 1706.019 seconds
FAIL! -- 486 Passed | 1 Failed | 0 Pending | 403 Skipped

Unrelated test.

/override OpenShift-Integration-tests/OpenShift-Integration-tests

@openshift-ci
Copy link

openshift-ci bot commented May 26, 2023

@rm3l: Overrode contexts on behalf of rm3l: OpenShift-Integration-tests/OpenShift-Integration-tests

In response to this:

 [odo] I0526 10:44:15.079858   10344 watch.go:428] Error from Push: watch command was unable to push component: unable to delete remote resources: unable to delete resource: ServiceBinding/my-nodejs-app-cluster-sample-k8s: timeout while waiting for "my-nodejs-app-cluster-sample-k8s" resource to be deleted

...
Summarizing 1 Failure:
 [FAIL] odo remove binding command tests when the component with binding is bootstrapped (bindingName=my-nodejs-app-cluster-sample-k8s) when odo dev is running when binding is removed [It] should have led odo dev to delete ServiceBinding from the cluster
 /go/odo_1/tests/integration/cmd_remove_binding_test.go:73

Ran 487 of 890 Specs in 1706.019 seconds
FAIL! -- 486 Passed | 1 Failed | 0 Pending | 403 Skipped

Unrelated test.

/override OpenShift-Integration-tests/OpenShift-Integration-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@rm3l
Copy link
Member Author

rm3l commented May 26, 2023

  [FAILED] Timed out after 420.007s.
  Expected
      <string>:   __
       /  \__     Developing using the "srcdjf" Devfile
       \__/  \    Namespace: cmd-dev-test468qmj
       /  \__/    odo version: v3.10.0
       \__/
      
      - Running on the cluster in Dev mode
       -  Waiting for Kubernetes resources  ...
       !  0/3 nodes are available: 3 pod has unbound immediate PersistentVolumeClaims. preemption: 0/3 nodes are available: 3 Preemption is not helpful for scheduling.
       !  Pod is Pending
       !  0/3 nodes are available: 3 pod has unbound immediate PersistentVolumeClaims. preemption: 0/3 nodes are available: 3 Preemption is not helpful for scheduling.
       !  AttachVolume.Attach failed for volume "pvc-9e0290e7-1ad1-4709-9485-1117e70e2060" : timed out waiting for external-attacher of vpc.block.csi.ibm.io CSI driver to attach volume r010-4e3f29d0-3cb6-4e82-b560-becdc0c144fe
       !  Unable to attach or mount volumes: unmounted volumes=[odo-projects], unattached volumes=[kube-api-access-hfsgd odo-projects odo-shared-data]: timed out waiting for the condition
       !  AttachVolume.Attach failed for volume "pvc-9e0290e7-1ad1-4709-9485-1117e70e2060" : timed out waiting for external-attacher of vpc.block.csi.ibm.io CSI driver to attach volume r010-4e3f29d0-3cb6-4e82-b560-becdc0c144fe
       !  Unable to attach or mount volumes: unmounted volumes=[odo-projects], unattached volumes=[odo-projects odo-shared-data kube-api-access-hfsgd]: timed out waiting for the condition
       !  AttachVolume.Attach failed for volume "pvc-9e0290e7-1ad1-4709-9485-1117e70e2060" : timed out waiting for external-attacher of vpc.block.csi.ibm.io CSI driver to attach volume r010-4e3f29d0-3cb6-4e82-b560-becdc0c144fe
       !  Unable to attach or mount volumes: unmounted volumes=[odo-projects], unattached volumes=[odo-projects odo-shared-data kube-api-access-hfsgd]: timed out waiting for the condition
      
  to contain substring
      <string>: [Ctrl+c] - Exit
  In [BeforeEach] at: C:/Users/Administrator.ANSIBLE-TEST-VS/4028/tests/helper/helper_run.go:54 @ 05/26/23 05:48:04.518

  There were additional failures detected.  To view them in detail run ginkgo -vv
------------------------------

Summarizing 1 Failure:
  [FAIL] odo dev command tests when a component is bootstrapped when odo dev is executed and Ephemeral is set to false [BeforeEach] when killing odo dev and running odo delete component --wait should have deleted all resources before returning
  C:/Users/Administrator.ANSIBLE-TEST-VS/4028/tests/helper/helper_run.go:54

Ran 473 of 890 Specs in 1707.322 seconds
FAIL! -- 472 Passed | 1 Failed | 0 Pending | 417 Skipped

Unrelated test.

/override windows-integration-test/Windows-test

@openshift-ci
Copy link

openshift-ci bot commented May 26, 2023

@rm3l: Overrode contexts on behalf of rm3l: windows-integration-test/Windows-test

In response to this:

 [FAILED] Timed out after 420.007s.
 Expected
     <string>:   __
      /  \__     Developing using the "srcdjf" Devfile
      \__/  \    Namespace: cmd-dev-test468qmj
      /  \__/    odo version: v3.10.0
      \__/
     
     - Running on the cluster in Dev mode
      -  Waiting for Kubernetes resources  ...
      !  0/3 nodes are available: 3 pod has unbound immediate PersistentVolumeClaims. preemption: 0/3 nodes are available: 3 Preemption is not helpful for scheduling.
      !  Pod is Pending
      !  0/3 nodes are available: 3 pod has unbound immediate PersistentVolumeClaims. preemption: 0/3 nodes are available: 3 Preemption is not helpful for scheduling.
      !  AttachVolume.Attach failed for volume "pvc-9e0290e7-1ad1-4709-9485-1117e70e2060" : timed out waiting for external-attacher of vpc.block.csi.ibm.io CSI driver to attach volume r010-4e3f29d0-3cb6-4e82-b560-becdc0c144fe
      !  Unable to attach or mount volumes: unmounted volumes=[odo-projects], unattached volumes=[kube-api-access-hfsgd odo-projects odo-shared-data]: timed out waiting for the condition
      !  AttachVolume.Attach failed for volume "pvc-9e0290e7-1ad1-4709-9485-1117e70e2060" : timed out waiting for external-attacher of vpc.block.csi.ibm.io CSI driver to attach volume r010-4e3f29d0-3cb6-4e82-b560-becdc0c144fe
      !  Unable to attach or mount volumes: unmounted volumes=[odo-projects], unattached volumes=[odo-projects odo-shared-data kube-api-access-hfsgd]: timed out waiting for the condition
      !  AttachVolume.Attach failed for volume "pvc-9e0290e7-1ad1-4709-9485-1117e70e2060" : timed out waiting for external-attacher of vpc.block.csi.ibm.io CSI driver to attach volume r010-4e3f29d0-3cb6-4e82-b560-becdc0c144fe
      !  Unable to attach or mount volumes: unmounted volumes=[odo-projects], unattached volumes=[odo-projects odo-shared-data kube-api-access-hfsgd]: timed out waiting for the condition
     
 to contain substring
     <string>: [Ctrl+c] - Exit
 In [BeforeEach] at: C:/Users/Administrator.ANSIBLE-TEST-VS/4028/tests/helper/helper_run.go:54 @ 05/26/23 05:48:04.518

 There were additional failures detected.  To view them in detail run ginkgo -vv
------------------------------

Summarizing 1 Failure:
 [FAIL] odo dev command tests when a component is bootstrapped when odo dev is executed and Ephemeral is set to false [BeforeEach] when killing odo dev and running odo delete component --wait should have deleted all resources before returning
 C:/Users/Administrator.ANSIBLE-TEST-VS/4028/tests/helper/helper_run.go:54

Ran 473 of 890 Specs in 1707.322 seconds
FAIL! -- 472 Passed | 1 Failed | 0 Pending | 417 Skipped
``

Unrelated test.

/override windows-integration-test/Windows-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label May 26, 2023
@openshift-merge-robot openshift-merge-robot merged commit 511aaa2 into redhat-developer:main May 26, 2023
@rm3l rm3l deleted the 6847-test-failure-on-ocp-4.14-should-print-warning-about-default-namespace-when-running-odo-dev branch May 26, 2023 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/testing Issues or PRs related to testing, Quality Assurance or Quality Engineering kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. Required by Prow.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test failure on OCP 4.14: should print warning about default namespace when running odo dev
3 participants