Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make sure the "Syncing files into the container" spinner is displayed on Podman #6863

Merged
merged 2 commits into from
Jun 2, 2023
Merged

Make sure the "Syncing files into the container" spinner is displayed on Podman #6863

merged 2 commits into from
Jun 2, 2023

Conversation

rm3l
Copy link
Member

@rm3l rm3l commented Jun 1, 2023

What type of PR is this:
/kind bug
/area odo-on-podman
/area dev
/area UX

What does this PR do / why we need it:
See #6856 for more context. This issue was discovered while working on #6855 , but I preferred to address that in a separate issue and PR.

Which issue(s) this PR fixes:
Fixes #6856

PR acceptance criteria:

  • Unit test

  • Integration test

  • Documentation

How to test changes / Special notes to the reviewer:
See #6856

rm3l added 2 commits June 1, 2023 16:03
@rm3l
Check that the "Syncing files into the container" spinner is correctl…
368ca2b 
…y displayed on both Podman and cluster
@rm3l
Add missing "Syncing files into the container" spinner when running '…
cbcac67 
…odo dev' on Podman

This indicates to the user that we are sync'ing the files,
which might be a potentially long operation.
This is to be consistent with the output when using 'odo dev' on cluster.
@netlify
Copy link

netlify bot commented Jun 1, 2023 •
edited
Loading

✅ Deploy Preview for odo-docusaurus-preview canceled.

Name Link
🔨 Latest commit cbcac67
🔍 Latest deploy log https://app.netlify.com/sites/odo-docusaurus-preview/deploys/6478a75d1a411a0008484279

@openshift-ci openshift-ci bot added kind/bug Categorizes issue or PR as related to a bug. area/odo-on-podman Issues or PRs related to running odo against Podman area/dev Issues or PRs related to `odo dev` area/UX Issues or PRs related to User Experience labels Jun 1, 2023
@openshift-ci openshift-ci bot requested review from anandrkskd and rnapoles-rh June 1, 2023 14:13
@rm3l rm3l requested review from feloy and valaparthvi and removed request for anandrkskd and rnapoles-rh June 1, 2023 14:13
@odo-robot
Copy link

odo-robot bot commented Jun 1, 2023 •
edited
Loading

NoCluster Tests on commit 655c6d0 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Jun 1, 2023 •
edited
Loading

OpenShift Unauthenticated Tests on commit 655c6d0 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Jun 1, 2023 •
edited
Loading

Unit Tests on commit 655c6d0 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Jun 1, 2023 •
edited
Loading

Validate Tests on commit 655c6d0 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Jun 1, 2023 •
edited
Loading

Kubernetes Tests on commit 655c6d0 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Jun 1, 2023 •
edited
Loading

Windows Tests (OCP) on commit 655c6d0 finished with errors.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Jun 1, 2023 •
edited
Loading

OpenShift Tests on commit 655c6d0 finished with errors.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Jun 1, 2023 •
edited
Loading

Kubernetes Docs Tests on commit 08e8b5d finished successfully.
View logs: TXT HTML

@feloy feloy closed this Jun 1, 2023
@feloy feloy reopened this Jun 1, 2023
@feloy feloy closed this Jun 2, 2023
@feloy feloy reopened this Jun 2, 2023
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jun 2, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Jun 2, 2023
@rm3l
Copy link
Member Author

rm3l commented Jun 2, 2023 

  [FAILED] Expected
      <*url.Error | 0xc0005e65d0>: {
          Op: "Post",
          URL: "http://127.0.0.1:41729/api/newuser",
          Err: <*errors.errorString | 0xc000072130>{s: "EOF"},
      }
  to be nil
  In [It] at: /go/odo_1/tests/e2escenarios/e2e_test.go:431 @ 06/02/23 08:08:45.132
...

Summarizing 1 Failure:
  [FAIL] E2E Test starting with non-empty Directory add Binding [It] should verify developer workflow of using binding as env in innerloop
  /go/odo_1/tests/e2escenarios/e2e_test.go:431

Ran 4 of 4 Specs in 246.503 seconds
FAIL! -- 3 Passed | 1 Failed | 0 Pending | 0 Skipped

Flaky E2E test (#6582)

/override OpenShift-Integration-tests/OpenShift-Integration-tests

@openshift-ci
Copy link

openshift-ci bot commented Jun 2, 2023

@rm3l: Overrode contexts on behalf of rm3l: OpenShift-Integration-tests/OpenShift-Integration-tests

In response to this:

 [FAILED] Expected
     <*url.Error | 0xc0005e65d0>: {
         Op: "Post",
         URL: "http://127.0.0.1:41729/api/newuser",
         Err: <*errors.errorString | 0xc000072130>{s: "EOF"},
     }
 to be nil
 In [It] at: /go/odo_1/tests/e2escenarios/e2e_test.go:431 @ 06/02/23 08:08:45.132
...

Summarizing 1 Failure:
 [FAIL] E2E Test starting with non-empty Directory add Binding [It] should verify developer workflow of using binding as env in innerloop
 /go/odo_1/tests/e2escenarios/e2e_test.go:431

Ran 4 of 4 Specs in 246.503 seconds
FAIL! -- 3 Passed | 1 Failed | 0 Pending | 0 Skipped

Flaky E2E test (#6582)

/override OpenShift-Integration-tests/OpenShift-Integration-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@rm3l
Copy link
Member Author

rm3l commented Jun 2, 2023 

...
 [oc] Unable to connect to the server: dial tcp 149.81.180.114:30329: connectex: A connection attempt failed because the connected party did not properly respond after a period of time, or established connection failed because connected host has failed to respond.
  [FAILED] in [BeforeEach] - C:/Users/Administrator.ANSIBLE-TEST-VS/4059/tests/helper/helper_generic.go:58 @ 06/02/23 02:41:47.774
  Deleting project: interactive-add-binding-test378efy
  Running oc.exe with args [oc delete project interactive-add-binding-test378efy --wait=false] and odo env: []
  [oc] project.project.openshift.io "interactive-add-binding-test378efy" deleted
  Setting current dir to: C:\Users\Administrator.ANSIBLE-TEST-VS\4059\tests\integration
  Deleting dir: C:\Users\Administrator.ANSIBLE-TEST-VS\AppData\Local\Temp\2154541628
  Deleting dir: C:\Users\Administrator.ANSIBLE-TEST-VS\AppData\Local\Temp\143336730
  << Timeline

  [FAILED] No future change is possible.  Bailing out early after 21.215s.
  Running oc.exe with args [oc get csv -o jsonpath={.items[?(@.status.phase=="Succeeded")].metadata.name}] and odo env: []
  Expected
      <int>: 1
  to match exit code:
      <int>: 0
  In [BeforeEach] at: C:/Users/Administrator.ANSIBLE-TEST-VS/4059/tests/helper/helper_generic.go:58 @ 06/02/23 02:41:47.774
...
Summarizing 1 Failure:
  [FAIL] odo add binding interactive command tests [BeforeEach] when running a deployment should successfully add binding without devfile (naming strategy: "uppercase")
  C:/Users/Administrator.ANSIBLE-TEST-VS/4059/tests/helper/helper_generic.go:58

Ran 473 of 926 Specs in 1488.717 seconds
FAIL! -- 472 Passed | 1 Failed | 0 Pending | 453 Skipped
...

Network issues on Windows (#6838)

/override windows-integration-test/Windows-test

@openshift-ci
Copy link

openshift-ci bot commented Jun 2, 2023

@rm3l: Overrode contexts on behalf of rm3l: windows-integration-test/Windows-test

In response to this:

...
[oc] Unable to connect to the server: dial tcp 149.81.180.114:30329: connectex: A connection attempt failed because the connected party did not properly respond after a period of time, or established connection failed because connected host has failed to respond.
 [FAILED] in [BeforeEach] - C:/Users/Administrator.ANSIBLE-TEST-VS/4059/tests/helper/helper_generic.go:58 @ 06/02/23 02:41:47.774
 Deleting project: interactive-add-binding-test378efy
 Running oc.exe with args [oc delete project interactive-add-binding-test378efy --wait=false] and odo env: []
 [oc] project.project.openshift.io "interactive-add-binding-test378efy" deleted
 Setting current dir to: C:\Users\Administrator.ANSIBLE-TEST-VS\4059\tests\integration
 Deleting dir: C:\Users\Administrator.ANSIBLE-TEST-VS\AppData\Local\Temp\2154541628
 Deleting dir: C:\Users\Administrator.ANSIBLE-TEST-VS\AppData\Local\Temp\143336730
 << Timeline

 [FAILED] No future change is possible.  Bailing out early after 21.215s.
 Running oc.exe with args [oc get csv -o jsonpath={.items[?(@.status.phase=="Succeeded")].metadata.name}] and odo env: []
 Expected
     <int>: 1
 to match exit code:
     <int>: 0
 In [BeforeEach] at: C:/Users/Administrator.ANSIBLE-TEST-VS/4059/tests/helper/helper_generic.go:58 @ 06/02/23 02:41:47.774
...
Summarizing 1 Failure:
 [FAIL] odo add binding interactive command tests [BeforeEach] when running a deployment should successfully add binding without devfile (naming strategy: "uppercase")
 C:/Users/Administrator.ANSIBLE-TEST-VS/4059/tests/helper/helper_generic.go:58

Ran 473 of 926 Specs in 1488.717 seconds
FAIL! -- 472 Passed | 1 Failed | 0 Pending | 453 Skipped
...

Network issues on Windows (#6838)

/override windows-integration-test/Windows-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot openshift-merge-robot merged commit b6c9c88 into redhat-developer:main Jun 2, 2023
@rm3l rm3l deleted the 6856-ux-odo-dev-on-podman-seems-stuck-after-creating-pod-missing-syncing-files-into-the-container-spinner-message branch June 2, 2023 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@feloy feloy feloy approved these changes

@valaparthvi valaparthvi Awaiting requested review from valaparthvi

Assignees

@feloy feloy

Labels
area/dev Issues or PRs related to `odo dev` area/odo-on-podman Issues or PRs related to running odo against Podman area/UX Issues or PRs related to User Experience kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. Required by Prow.
Projects
None yet
Milestone
No milestone
3 participants
@rm3l @feloy @openshift-merge-robot