Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

blogpost: writing devfile from scratch #6866

Merged
merged 5 commits into from
Oct 3, 2023
Merged

blogpost: writing devfile from scratch #6866

merged 5 commits into from
Oct 3, 2023

Conversation

kadel
Copy link
Member

@kadel kadel commented Jun 2, 2023

/area documentation

Rought cut, there are still a lot of typos.

@openshift-ci openshift-ci bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. Required by Prow. area/documentation Issues or PRs related to documentation or the 'odo.dev' website labels Jun 2, 2023
@netlify
Copy link

netlify bot commented Jun 2, 2023 •
edited by github-actions bot
Loading

🔨 Deploy Preview deleted from internal cluster!

Name Link
🔨 Latest commit 1df97ee
😎 Deploy Preview https://odo-dev-pr-6866.odo-test-kubernete-449701-49529fc6e6a4a9fe7ebba9a3db5b55c4-0000.eu-de.containers.appdomain.cloud/

@openshift-ci openshift-ci bot requested review from feloy and valaparthvi June 2, 2023 16:35
@odo-robot
Copy link

odo-robot bot commented Jun 2, 2023 •
edited
Loading

Windows Tests (OCP) on commit 14f27c9 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Jun 2, 2023 •
edited
Loading

NoCluster Tests on commit 14f27c9 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Jun 2, 2023 •
edited
Loading

OpenShift Unauthenticated Tests on commit 14f27c9 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Jun 2, 2023 •
edited
Loading

Unit Tests on commit 14f27c9 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Jun 2, 2023 •
edited
Loading

Validate Tests on commit 14f27c9 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Jun 2, 2023 •
edited
Loading

Kubernetes Tests on commit 14f27c9 finished with errors.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Jun 2, 2023 •
edited
Loading

OpenShift Tests on commit 14f27c9 finished with errors.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Jun 2, 2023 •
edited
Loading

Kubernetes Docs Tests on commit 1f2214c finished successfully.
View logs: TXT HTML

valaparthvi
valaparthvi suggested changes Jun 5, 2023
View reviewed changes
Copy link
Contributor

@valaparthvi valaparthvi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Devfile worked like a charm for me, there are few nits that I think could improve the doc.

docs/website/blog/2023-06-01-writing-devfile-from-scratch.mdx Outdated Show resolved Hide resolved
docs/website/blog/2023-06-01-writing-devfile-from-scratch.mdx Outdated Show resolved Hide resolved
docs/website/blog/2023-06-01-writing-devfile-from-scratch.mdx Outdated Show resolved Hide resolved
docs/website/blog/2023-06-01-writing-devfile-from-scratch.mdx Outdated Show resolved Hide resolved
docs/website/blog/2023-06-01-writing-devfile-from-scratch.mdx Outdated Show resolved Hide resolved
docs/website/blog/2023-06-01-writing-devfile-from-scratch.mdx Outdated Show resolved Hide resolved
docs/website/blog/2023-06-01-writing-devfile-from-scratch.mdx Outdated Show resolved Hide resolved
docs/website/blog/2023-06-01-writing-devfile-from-scratch.mdx Outdated Show resolved Hide resolved
docs/website/blog/2023-06-01-writing-devfile-from-scratch.mdx Outdated Show resolved Hide resolved
docs/website/blog/2023-06-01-writing-devfile-from-scratch.mdx Outdated Show resolved Hide resolved
@kadel @valaparthvi
Apply suggestions from code review
9003ed4 
Co-authored-by: Parthvi Vala <pvala@redhat.com>
@feloy feloy closed this Jun 7, 2023
@feloy feloy reopened this Jun 7, 2023
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jun 7, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 5 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

feloy
feloy reviewed Jun 7, 2023
View reviewed changes
docs/website/blog/2023-06-01-writing-devfile-from-scratch.mdx Outdated Show resolved Hide resolved
docs/website/blog/2023-06-01-writing-devfile-from-scratch.mdx Outdated Show resolved Hide resolved
docs/website/blog/2023-06-01-writing-devfile-from-scratch.mdx Outdated Show resolved Hide resolved
docs/website/blog/2023-06-01-writing-devfile-from-scratch.mdx Outdated Show resolved Hide resolved
docs/website/blog/2023-06-01-writing-devfile-from-scratch.mdx Outdated Show resolved Hide resolved
docs/website/blog/2023-06-01-writing-devfile-from-scratch.mdx Outdated Show resolved Hide resolved
docs/website/blog/2023-06-01-writing-devfile-from-scratch.mdx Outdated Show resolved Hide resolved
docs/website/blog/2023-06-01-writing-devfile-from-scratch.mdx Outdated Show resolved Hide resolved
@kadel @feloy
Apply suggestions from code review
94c0da3 
Co-authored-by: Philippe Martin <feloy1@gmail.com>
@kadel kadel temporarily deployed to internal July 25, 2023 11:36 — with GitHub Actions Inactive
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 12 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@kadel kadel removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. Required by Prow. label Sep 25, 2023
@kadel kadel changed the title [WIP] blogpost: writing devfile from scratch blogpost: writing devfile from scratch Sep 25, 2023
rm3l
rm3l reviewed Oct 2, 2023
View reviewed changes
Copy link
Member

@rm3l rm3l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, can you rebase your branch onto main, to fix the Pull Request Website Preview job?
https://github.com/redhat-developer/odo/actions/runs/5656269611/job/15323048852?pr=6866

Thanks!

docs/website/blog/2023-06-01-writing-devfile-from-scratch.mdx Outdated Show resolved Hide resolved
@rm3l rm3l added this to the v3.16.0 🚀 milestone Oct 2, 2023
@kadel kadel temporarily deployed to internal October 3, 2023 14:35 — with GitHub Actions Inactive
@kadel kadel temporarily deployed to internal October 3, 2023 14:35 — with GitHub Actions Inactive
@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 3, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.7% 0.7% Duplication

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Oct 3, 2023
@openshift-ci openshift-ci bot merged commit 868501c into redhat-developer:main Oct 3, 2023
7 checks passed
@openshift-ci openshift-ci bot temporarily deployed to internal October 3, 2023 15:16 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@feloy feloy feloy left review comments

@valaparthvi valaparthvi valaparthvi requested changes

@rm3l rm3l rm3l approved these changes

Assignees

@rm3l rm3l

Labels
area/documentation Issues or PRs related to documentation or the 'odo.dev' website lgtm Indicates that a PR is ready to be merged. Required by Prow.
Projects
None yet
Milestone
v3.16.0 🚀
Development

Successfully merging this pull request may close these issues.
4 participants
@kadel @rm3l @feloy @valaparthvi