Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skip tests if all changes in docs #6870

Merged
merged 3 commits into from
Jun 6, 2023
Merged

Skip tests if all changes in docs #6870

merged 3 commits into from
Jun 6, 2023

Conversation

feloy
Copy link
Contributor

@feloy feloy commented Jun 5, 2023

What type of PR is this:

/kind feature
/area testing

What does this PR do / why we need it:

Which issue(s) this PR fixes:

Fixes #6854

PR acceptance criteria:

  • Unit test

  • Integration test

  • Documentation

How to test changes / Special notes to the reviewer:

@netlify
Copy link

netlify bot commented Jun 5, 2023 •
edited
Loading

✅ Deploy Preview for odo-docusaurus-preview ready!

Name Link
🔨 Latest commit b8daa3c
🔍 Latest deploy log https://app.netlify.com/sites/odo-docusaurus-preview/deploys/647ee680c6bd72000898910d
😎 Deploy Preview https://deploy-preview-6870--odo-docusaurus-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@openshift-ci openshift-ci bot added kind/feature Categorizes issue as a feature request. For PRs, that means that the PR is the implementation area/testing Issues or PRs related to testing, Quality Assurance or Quality Engineering labels Jun 5, 2023
@openshift-ci openshift-ci bot requested review from kadel and rm3l June 5, 2023 10:58
@feloy feloy force-pushed the tests-6854/skip-website-only-changes branch from 5c648d5 to 27d121c Compare June 5, 2023 11:03
@odo-robot
Copy link

odo-robot bot commented Jun 5, 2023 •
edited
Loading

Unit Tests on commit 348f2dc finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Jun 5, 2023 •
edited
Loading

OpenShift Unauthenticated Tests on commit 348f2dc finished successfully.
View logs: TXT HTML

@feloy feloy force-pushed the tests-6854/skip-website-only-changes branch from 27d121c to 0be91b6 Compare June 5, 2023 11:37
@odo-robot
Copy link

odo-robot bot commented Jun 5, 2023 •
edited
Loading

NoCluster Tests on commit 348f2dc finished successfully.
View logs: TXT HTML

@feloy feloy force-pushed the tests-6854/skip-website-only-changes branch from 25faa8d to fbd473f Compare June 5, 2023 11:51
@odo-robot
Copy link

odo-robot bot commented Jun 5, 2023 •
edited
Loading

Validate Tests on commit 348f2dc finished successfully.
View logs: TXT HTML

@feloy feloy force-pushed the tests-6854/skip-website-only-changes branch from fbd473f to 37e708c Compare June 5, 2023 12:18
@odo-robot
Copy link

odo-robot bot commented Jun 5, 2023

Windows Tests (OCP) on commit c98c810 finished with errors.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Jun 5, 2023 •
edited
Loading

Kubernetes Tests on commit 348f2dc finished successfully.
View logs: TXT HTML

@feloy feloy changed the title Skip tests if all changes in website (and .ibm for testing this PR) Skip tests if all changes in docs Jun 5, 2023
@odo-robot
Copy link

odo-robot bot commented Jun 5, 2023 •
edited
Loading

OpenShift Tests on commit 348f2dc finished successfully.
View logs: TXT HTML

@feloy feloy force-pushed the tests-6854/skip-website-only-changes branch from 37e708c to b64d2e2 Compare June 5, 2023 12:58
@odo-robot
Copy link

odo-robot bot commented Jun 5, 2023 •
edited
Loading

Kubernetes Docs Tests on commit a830179 finished successfully.
View logs: TXT HTML

@feloy feloy requested review from anandrkskd and removed request for kadel June 5, 2023 13:44
rm3l
rm3l requested changes Jun 5, 2023
View reviewed changes
Copy link
Member

@rm3l rm3l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is also one more point in the acceptance criteria: can you update the podman-test GitHub Workflow to skip the tests for doc-only changes, using paths and paths-ignore filters?

.ibm/pipelines/functions.sh Outdated Show resolved Hide resolved
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jun 6, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
5.8% 5.8% Duplication

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Jun 6, 2023
@feloy
Copy link
Contributor Author

feloy commented Jun 6, 2023

/override "SonarCloud Code Analysis"
Unrelated

@openshift-ci
Copy link

openshift-ci bot commented Jun 6, 2023

@feloy: Overrode contexts on behalf of feloy: SonarCloud Code Analysis

In response to this:

/override "SonarCloud Code Analysis"
Unrelated

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot openshift-merge-robot merged commit 029c538 into redhat-developer:main Jun 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rm3l rm3l rm3l approved these changes

@anandrkskd anandrkskd Awaiting requested review from anandrkskd

Assignees

@rm3l rm3l

Labels
area/testing Issues or PRs related to testing, Quality Assurance or Quality Engineering kind/feature Categorizes issue as a feature request. For PRs, that means that the PR is the implementation lgtm Indicates that a PR is ready to be merged. Required by Prow.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Skip IBM Cloud and Podman tests for doc-only PRs
3 participants
@feloy @rm3l @openshift-merge-robot